Re: RFR 8170618: jmod should validate if any exported or open package is missing

[Mandy Chung]

> On Dec 21, 2016, at 4:08 AM, Sundararajan Athijegannathan 
>  wrote:
> 
> Please review http://cr.openjdk.java.net/~sundar/8170618/webrev.00/ for 
> https://bugs.openjdk.java.net/browse/JDK-8170618

thanks for fixing this Sundar.

Minor comment on the test: the bug id's already listed in @bug.  You
can take out the bug id from line 117.  line 132 should be broken into
multiple lines.

Otherwise, looks good.
Mandy

Re: RFR 8170618: jmod should validate if any exported or open package is missing

[Chris Hegarty]

On 21/12/16 12:08, Sundararajan Athijegannathan wrote:

Please review http://cr.openjdk.java.net/~sundar/8170618/webrev.00/ for
https://bugs.openjdk.java.net/browse/JDK-8170618


Looks good Sundar.

-Chris.

Re: RFR 8170618: jmod should validate if any exported or open package is missing

[Jim Laskey (Oracle)]

+1

> On Dec 21, 2016, at 8:08 AM, Sundararajan Athijegannathan 
>  wrote:
> 
> Please review http://cr.openjdk.java.net/~sundar/8170618/webrev.00/ for 
> https://bugs.openjdk.java.net/browse/JDK-8170618
> 
> Thanks,
> -Sundar

RFR 8170618: jmod should validate if any exported or open package is missing

[Sundararajan Athijegannathan]

Please review http://cr.openjdk.java.net/~sundar/8170618/webrev.00/ for 
https://bugs.openjdk.java.net/browse/JDK-8170618


Thanks,
-Sundar