Re: RFR JDK-8151913: Fix module dependencies in java/net tests

[Alan Bateman]

On 11/06/2016 08:59, John Jiang wrote:

Hi,
Just restarted this job.

On 2016/4/29 15:34, Alan Bateman wrote:


On 28/04/2016 05:50, John Jiang wrote:

Hi,
Please review another webrev: 
http://cr.openjdk.java.net/~jjiang/8151913/webrev.02
The java.httpclient module declaration is removed from all of 
java/net/httpclient tests, even though some ones have to declare 
other modules.
If a test has the @modules tag then then the "modules" key in the 
test suite configuration (TEST.properties) won't be used. That is, 
@modules overrides rather than augments. I just re-read the tag spec 
[1] and I think have this right. In that case, the java.httpclient 
tests that have @modules jdk.httpserver will need to list 
java.httpclient too.
Please review the updated webrev: 
http://cr.openjdk.java.net/~jjiang/8151913/webrev.03
Additionally, test/java/net/CookieHandler/CookieManagerTest.java and 
test/java/net/HttpURLConnection/UnmodifiableMaps.java have defined 
@modules, so this new patch excludes them.

The updated patch looks okay to me.

-Alan

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

[Alan Bateman]

On 28/04/2016 05:50, John Jiang wrote:

Hi,
Please review another webrev: 
http://cr.openjdk.java.net/~jjiang/8151913/webrev.02
The java.httpclient module declaration is removed from all of 
java/net/httpclient tests, even though some ones have to declare other 
modules.
If a test has the @modules tag then then the "modules" key in the test 
suite configuration (TEST.properties) won't be used. That is, @modules 
overrides rather than augments. I just re-read the tag spec [1] and I 
think have this right. In that case, the java.httpclient tests that have 
@modules jdk.httpserver will need to list java.httpclient too.


-Alan

[1] http://openjdk.java.net/jtreg/tag-spec.html

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

[John Jiang]

Hi Amy,
That's case to case.
If a test is using java.logging APIs directly, I declared the module for 
the test. Otherwise, I didn't.

I think that may be more clear.
Although a test is using jdk.httpserver, that doesn't mean it also 
dependents on java.logging.


Best regards,
John Jiang

On 2016/4/28 13:09, Amy Lu wrote:

On 4/28/16 12:50 PM, John Jiang wrote:

Hi,
Please review another webrev: 
http://cr.openjdk.java.net/~jjiang/8151913/webrev.02
The java.httpclient module declaration is removed from all of 
java/net/httpclient tests, even though some ones have to declare 
other modules.


+ * @modules jdk.httpserver
+ *  java.logging

Not necessary to declare java.logging as it’s a dependency of 
jdk.httpserver

(it does not hurt, though)

Please wait for reviewer's feedback...

Thanks,
Amy


Best regards,
John Jiang


On 2016/4/27 23:07, John Jiang wrote:

Hi Alan, Felix,
Thanks for your comments.
Please review the updated webrev: 
http://cr.openjdk.java.net/~jjiang/8151913/webrev.01/


Best regards,
John Jiang


On 2016/4/27 15:08, John Jiang wrote:

Hi,
Please review the fix for explicitly declaring module dependencies 
for java net tests.


Issue: https://bugs.openjdk.java.net/browse/JDK-8151913
Webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.00

Best regards,
John Jiang

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

[Amy Lu]

On 4/28/16 12:50 PM, John Jiang wrote:

Hi,
Please review another webrev: 
http://cr.openjdk.java.net/~jjiang/8151913/webrev.02
The java.httpclient module declaration is removed from all of 
java/net/httpclient tests, even though some ones have to declare other 
modules.


+ * @modules jdk.httpserver
+ *  java.logging

Not necessary to declare java.logging as it’s a dependency of jdk.httpserver
(it does not hurt, though)

Please wait for reviewer's feedback...

Thanks,
Amy


Best regards,
John Jiang


On 2016/4/27 23:07, John Jiang wrote:

Hi Alan, Felix,
Thanks for your comments.
Please review the updated webrev: 
http://cr.openjdk.java.net/~jjiang/8151913/webrev.01/


Best regards,
John Jiang


On 2016/4/27 15:08, John Jiang wrote:

Hi,
Please review the fix for explicitly declaring module dependencies 
for java net tests.


Issue: https://bugs.openjdk.java.net/browse/JDK-8151913
Webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.00

Best regards,
John Jiang

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

[John Jiang]

Hi,
Please review another webrev: 
http://cr.openjdk.java.net/~jjiang/8151913/webrev.02
The java.httpclient module declaration is removed from all of 
java/net/httpclient tests, even though some ones have to declare other 
modules.


Best regards,
John Jiang


On 2016/4/27 23:07, John Jiang wrote:

Hi Alan, Felix,
Thanks for your comments.
Please review the updated webrev: 
http://cr.openjdk.java.net/~jjiang/8151913/webrev.01/


Best regards,
John Jiang


On 2016/4/27 15:08, John Jiang wrote:

Hi,
Please review the fix for explicitly declaring module dependencies 
for java net tests.


Issue: https://bugs.openjdk.java.net/browse/JDK-8151913
Webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.00

Best regards,
John Jiang

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

[Felix Yang]

Hi John,

 I think it is necessary to update the years at the beginning of 
copyright.


-Felix
On 2016/4/27 15:08, John Jiang wrote:

Hi,
Please review the fix for explicitly declaring module dependencies for 
java net tests.


Issue: https://bugs.openjdk.java.net/browse/JDK-8151913
Webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.00

Best regards,
John Jiang

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

[Alan Bateman]

On 27/04/2016 08:08, John Jiang wrote:

Hi,
Please review the fix for explicitly declaring module dependencies for 
java net tests.


Issue: https://bugs.openjdk.java.net/browse/JDK-8151913
Webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.00
Since every test in test/java/net/httpclient/** will require the 
java.httpclient module then we could put a TEST.properties in the 
httpclient directly so that @modules doesn't need to be added to every test.


-Alan

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

[Chris Hegarty]

On 27 Apr 2016, at 08:08, John Jiang  wrote:

> Hi,
> Please review the fix for explicitly declaring module dependencies for java 
> net tests.
> 
> Issue: https://bugs.openjdk.java.net/browse/JDK-8151913
> Webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.00

This looks ok to me.  Thanks,

-Chris.