Re: 8241770: Module xxxAnnotation() methods throw NCDFE if module-info.class found as resource in unnamed module
On 10/06/2020 22:22, Mandy Chung wrote: Nit: A typo in the test s/reflectingly/reflectively/ 102 * Test reflectingly reading annotations on a named module where the module That typo was in two places and I only spotted one of them when creating the webrev. I'll fix the second one before pushing. Thanks! -Alan
Re: 8241770: Module xxxAnnotation() methods throw NCDFE if module-info.class found as resource in unnamed module
On 6/10/20 12:51 PM, Alan Bateman wrote: This is a bug in Module.getXXXAnnotation implementation where it accidentally locates a module-info.class on the class path (say if someone deploys a modular JAR on the class path). An oversight in the original implementation. Simple fix to override loadClass to do the right thing. I've kept the changes as minimal as possible as this is a change that may need to be back-ported. The webrev with the change and updated test is here: http://cr.openjdk.java.net/~alanb/8241770/webrev/ Looks good. Nit: A typo in the test s/reflectingly/reflectively/ 102 * Test reflectingly reading annotations on a named module where the module Mandy
