[jira] [Updated] (ARROW-18250) [R] mutate(x2=x %>% str_replace('^ s*$',NA_character_)) Does not replicate behaviour of R
[
https://issues.apache.org/jira/browse/ARROW-18250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicola Crane updated ARROW-18250:
-
Component/s: R
> [R] mutate(x2=x %>% str_replace('^ s*$',NA_character_)) Does not replicate
> behaviour of R
> --
>
> Key: ARROW-18250
> URL: https://issues.apache.org/jira/browse/ARROW-18250
> Project: Apache Arrow
> Issue Type: Bug
> Components: R
>Reporter: Lucas Mation
>Priority: Minor
>
> {code:r}
> q <- data.table(x=c('','1','2'))
> q %>% write_dataset('q')
> #in R
> q %>% mutate(x2=x %>% str_replace('^
> s*$',NA_character_))
> x x2
> 1:
> 2: 1 1
> 3: 2 2
> #in arrow
> q2 <- 'q' %>% open_dataset %>% mutate(x2=x %>% str_replace('^
> s*$',NA_character_)) %>% collect
> q2
> x x2
> 1:
> 2: 1 1
> 3: 2 2
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (ARROW-18250) [R] mutate(x2=x %>% str_replace('^ s*$',NA_character_)) Does not replicate behaviour of R
[
https://issues.apache.org/jira/browse/ARROW-18250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicola Crane updated ARROW-18250:
-
Description:
{code:r}
q <- data.table(x=c('','1','2'))
q %>% write_dataset('q')
#in R
q %>% mutate(x2=x %>% str_replace('^
s*$',NA_character_))
x x2
1:
2: 1 1
3: 2 2
#in arrow
q2 <- 'q' %>% open_dataset %>% mutate(x2=x %>% str_replace('^
s*$',NA_character_)) %>% collect
q2
x x2
1:
2: 1 1
3: 2 2
{code}
was:
```
q <- data.table(x=c('','1','2'))
q %>% write_dataset('q')
#in R
q %>% mutate(x2=x %>% str_replace('^
s*$',NA_character_))
x x2
1:
2: 1 1
3: 2 2
#in arrow
q2 <- 'q' %>% open_dataset %>% mutate(x2=x %>% str_replace('^
s*$',NA_character_)) %>% collect
q2
x x2
1:
2: 1 1
3: 2 2
```
> [R] mutate(x2=x %>% str_replace('^ s*$',NA_character_)) Does not replicate
> behaviour of R
> --
>
> Key: ARROW-18250
> URL: https://issues.apache.org/jira/browse/ARROW-18250
> Project: Apache Arrow
> Issue Type: Bug
>Reporter: Lucas Mation
>Priority: Minor
>
> {code:r}
> q <- data.table(x=c('','1','2'))
> q %>% write_dataset('q')
> #in R
> q %>% mutate(x2=x %>% str_replace('^
> s*$',NA_character_))
> x x2
> 1:
> 2: 1 1
> 3: 2 2
> #in arrow
> q2 <- 'q' %>% open_dataset %>% mutate(x2=x %>% str_replace('^
> s*$',NA_character_)) %>% collect
> q2
> x x2
> 1:
> 2: 1 1
> 3: 2 2
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (ARROW-16811) [C++] Remove default exec context from Expression::Bind
[ https://issues.apache.org/jira/browse/ARROW-16811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552993#comment-17552993 ] Yaron Gvili edited comment on ARROW-16811 at 11/7/22 6:49 AM: -- You are referring to [this post|https://issues.apache.org/jira/browse/ARROW-16796?focusedCommentId=17552569=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17552569]. This limited-bind is not ideal, though it can be useful as an intermediate solution in places in the code that cannot be easily changed to a work with a non-default ExecContext. I imagine this could be the case in some user-facing APIs that currently do not take an ExecContext, and eventually defaults to the global function registry (perhaps examples exist in the dataset package?). In such cases, there are two options to consider: either break user code to force it to provide an ExecContext, or keep user-code intact but fail on runtime when an expression gets bound in a non-safe way. The latter one is what I wanted to draw attention to. was (Author: JIRAUSER284707): You are referring to this post. This limited-bind is not ideal, though it can be useful as an intermediate solution in places in the code that cannot be easily changed to a work with a non-default ExecContext. I imagine this could be the case in some user-facing APIs that currently do not take an ExecContext, and eventually defaults to the global function registry (perhaps examples exist in the dataset package?). In such cases, there are two options to consider: either break user code to force it to provide an ExecContext, or keep user-code intact but fail on runtime when an expression gets bound in a non-safe way. The latter one is what I wanted to draw attention to. > [C++] Remove default exec context from Expression::Bind > --- > > Key: ARROW-16811 > URL: https://issues.apache.org/jira/browse/ARROW-16811 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Weston Pace >Priority: Minor > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > This came up in https://github.com/apache/arrow/pull/13355. > It is maybe not very intuitive that Expression::Bind would require an > ExecContext and so we never provided one. However, when binding expressions > we need to lookup kernels, and that requires a function registry. Defaulting > to default_exec_context is something that should be done at a higher level > and so we should not allow ExecContext to be omitted when calling Bind. > Furthermore, [~rtpsw] has suggested that we might want to split > Expression::Bind into two variants. One which requires an ExecContext and > one which does not (but fails if it encounters a "call"). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (ARROW-16811) [C++] Remove default exec context from Expression::Bind
[ https://issues.apache.org/jira/browse/ARROW-16811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yaron Gvili reassigned ARROW-16811: --- Assignee: Yaron Gvili > [C++] Remove default exec context from Expression::Bind > --- > > Key: ARROW-16811 > URL: https://issues.apache.org/jira/browse/ARROW-16811 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Weston Pace >Assignee: Yaron Gvili >Priority: Minor > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > This came up in https://github.com/apache/arrow/pull/13355. > It is maybe not very intuitive that Expression::Bind would require an > ExecContext and so we never provided one. However, when binding expressions > we need to lookup kernels, and that requires a function registry. Defaulting > to default_exec_context is something that should be done at a higher level > and so we should not allow ExecContext to be omitted when calling Bind. > Furthermore, [~rtpsw] has suggested that we might want to split > Expression::Bind into two variants. One which requires an ExecContext and > one which does not (but fails if it encounters a "call"). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARROW-18260) [C++][CMake] Add support for x64 for CMAKE_SYSTEM_PROCESSOR
[
https://issues.apache.org/jira/browse/ARROW-18260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ARROW-18260:
---
Labels: pull-request-available (was: )
> [C++][CMake] Add support for x64 for CMAKE_SYSTEM_PROCESSOR
> ---
>
> Key: ARROW-18260
> URL: https://issues.apache.org/jira/browse/ARROW-18260
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
>Reporter: Kouhei Sutou
>Assignee: Kouhei Sutou
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> vcpkg uses {{x64}}:
> https://vcpkg.readthedocs.io/en/latest/users/triplets/
> bq. Valid options are x86, x64, arm, arm64 and wasm32.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (ARROW-18260) [C++][CMake] Add support for x64 for CMAKE_SYSTEM_PROCESSOR
Kouhei Sutou created ARROW-18260:
Summary: [C++][CMake] Add support for x64 for
CMAKE_SYSTEM_PROCESSOR
Key: ARROW-18260
URL: https://issues.apache.org/jira/browse/ARROW-18260
Project: Apache Arrow
Issue Type: Improvement
Components: C++
Reporter: Kouhei Sutou
Assignee: Kouhei Sutou
vcpkg uses {{x64}}:
https://vcpkg.readthedocs.io/en/latest/users/triplets/
bq. Valid options are x86, x64, arm, arm64 and wasm32.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (ARROW-18259) [C++][CMake] Add support for system Thrift CMake package
[ https://issues.apache.org/jira/browse/ARROW-18259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ARROW-18259: --- Labels: pull-request-available (was: ) > [C++][CMake] Add support for system Thrift CMake package > > > Key: ARROW-18259 > URL: https://issues.apache.org/jira/browse/ARROW-18259 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Kouhei Sutou >Assignee: Kouhei Sutou >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARROW-18259) [C++][CMake] Add support for system Thrift CMake package
Kouhei Sutou created ARROW-18259: Summary: [C++][CMake] Add support for system Thrift CMake package Key: ARROW-18259 URL: https://issues.apache.org/jira/browse/ARROW-18259 Project: Apache Arrow Issue Type: Improvement Components: C++ Reporter: Kouhei Sutou Assignee: Kouhei Sutou -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARROW-18258) [Docker] Substrait Integration Testing
Vibhatha Lakmal Abeykoon created ARROW-18258: Summary: [Docker] Substrait Integration Testing Key: ARROW-18258 URL: https://issues.apache.org/jira/browse/ARROW-18258 Project: Apache Arrow Issue Type: New Feature Reporter: Vibhatha Lakmal Abeykoon Assignee: Vibhatha Lakmal Abeykoon Fix For: 11.0.0 At the moment the Substrait consumer test suite is developed at [https://github.com/substrait-io/consumer-testing.] To evaluate the performance and functionality against Acero/Substrait development, an integration test suite is important. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARROW-18258) [Docker] Substrait Integration Testing
[ https://issues.apache.org/jira/browse/ARROW-18258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ARROW-18258: --- Labels: pull-request-available (was: ) > [Docker] Substrait Integration Testing > -- > > Key: ARROW-18258 > URL: https://issues.apache.org/jira/browse/ARROW-18258 > Project: Apache Arrow > Issue Type: New Feature >Reporter: Vibhatha Lakmal Abeykoon >Assignee: Vibhatha Lakmal Abeykoon >Priority: Major > Labels: pull-request-available > Fix For: 11.0.0 > > Time Spent: 10m > Remaining Estimate: 0h > > At the moment the Substrait consumer test suite is developed at > [https://github.com/substrait-io/consumer-testing.] To evaluate the > performance and functionality against Acero/Substrait development, an > integration test suite is important. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (ARROW-18249) Update vcpkg port to arrow 10.0.0
[ https://issues.apache.org/jira/browse/ARROW-18249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kouhei Sutou reassigned ARROW-18249: Assignee: Kouhei Sutou > Update vcpkg port to arrow 10.0.0 > - > > Key: ARROW-18249 > URL: https://issues.apache.org/jira/browse/ARROW-18249 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Affects Versions: 10.0.0 >Reporter: Bernhard Manfred Gruber >Assignee: Kouhei Sutou >Priority: Minor > > Please update the [vcpkg|https://github.com/microsoft/vcpkg] port of arrow to > the newly released version 10.0.0. The current version on vcpkg is 9.0.0. > I found this documentation on how to do it: > https://cwiki.apache.org/confluence/display/ARROW/Release+Management+Guide#ReleaseManagementGuide-Updatingthevcpkgport > I need this downstream to update the xsimd port on vcpkg, which I need > downstream in another project. Thank you! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARROW-18249) Update vcpkg port to arrow 10.0.0
[ https://issues.apache.org/jira/browse/ARROW-18249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629578#comment-17629578 ] Kouhei Sutou commented on ARROW-18249: -- https://github.com/microsoft/vcpkg/pull/27687 > Update vcpkg port to arrow 10.0.0 > - > > Key: ARROW-18249 > URL: https://issues.apache.org/jira/browse/ARROW-18249 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Affects Versions: 10.0.0 >Reporter: Bernhard Manfred Gruber >Assignee: Kouhei Sutou >Priority: Minor > > Please update the [vcpkg|https://github.com/microsoft/vcpkg] port of arrow to > the newly released version 10.0.0. The current version on vcpkg is 9.0.0. > I found this documentation on how to do it: > https://cwiki.apache.org/confluence/display/ARROW/Release+Management+Guide#ReleaseManagementGuide-Updatingthevcpkgport > I need this downstream to update the xsimd port on vcpkg, which I need > downstream in another project. Thank you! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARROW-18256) [C++][Windows] External/shared libthrift requires IMPORTED_IMPLIB in FindThrift.cmake
[
https://issues.apache.org/jira/browse/ARROW-18256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ARROW-18256:
---
Labels: pull-request-available (was: )
> [C++][Windows] External/shared libthrift requires IMPORTED_IMPLIB in
> FindThrift.cmake
> --
>
> Key: ARROW-18256
> URL: https://issues.apache.org/jira/browse/ARROW-18256
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
>Affects Versions: 10.0.0
>Reporter: Maarten Pronk
>Assignee: Kouhei Sutou
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As mentioned in ARROW-18255, over at
> [https://github.com/JuliaPackaging/Yggdrasil/pull/5425,] we cross-compile
> Arrow to make it easily available within the Julia ecosystem.
> When compiling with `DARROW_THRIFT_USE_SHARED=ON` and using an external
> libthrift, CMAKE warns with:
>
> {quote}[12:00:54] CMake Warning (dev) in CMakeLists.txt:
> [12:00:54] Policy CMP0111 is not set: An imported target missing its
> location property
> [12:00:54] fails during generation. Run "cmake --help-policy CMP0111" for
> policy
> [12:00:54] details. Use the cmake_policy command to set the policy and
> suppress this
> [12:00:54] warning.
> [12:00:54]
> [12:00:54] IMPORTED_IMPLIB not set for imported target "thrift::thrift"
> configuration
> [12:00:54] "RELEASE".
> [12:00:54] This warning is for project developers. Use -Wno-dev to suppress
> it.
> {quote}
> This will lead to linking errors later on. I've fixed the warning with the
> following patch for v10.
>
> {quote}{{diff --git a/cpp/cmake_modules/FindThrift.cmake
> b/cpp/cmake_modules/FindThrift.cmake}}
> {{index 2f20a5cb5..2d1e728aa 100644}}
> {{--- a/cpp/cmake_modules/FindThrift.cmake}}
> {{+++ b/cpp/cmake_modules/FindThrift.cmake}}
> {{@@ -146,6 +146,7 @@ if(Thrift_FOUND)}}
> {{ endif()}}
> {{ set_target_properties(thrift::thrift}}
> {{ PROPERTIES IMPORTED_LOCATION "${THRIFT_LIB}"}}
> {{+ IMPORTED_IMPLIB "${THRIFT_LIB}"}}
> {{ INTERFACE_INCLUDE_DIRECTORIES
> "${THRIFT_INCLUDE_DIR}")}}
> {{ if(WIN32 AND NOT MSVC_TOOLCHAIN)}}
> {{ # We don't need this for Visual C++ because Thrift uses}}
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (ARROW-18256) [C++][Windows] External/shared libthrift requires IMPORTED_IMPLIB in FindThrift.cmake
[
https://issues.apache.org/jira/browse/ARROW-18256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kouhei Sutou updated ARROW-18256:
-
Summary: [C++][Windows] External/shared libthrift requires IMPORTED_IMPLIB
in FindThrift.cmake (was: [C++] External/shared libthrift requires
IMPORTED_IMPLIB in FindThrift.cmake )
> [C++][Windows] External/shared libthrift requires IMPORTED_IMPLIB in
> FindThrift.cmake
> --
>
> Key: ARROW-18256
> URL: https://issues.apache.org/jira/browse/ARROW-18256
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
>Affects Versions: 10.0.0
>Reporter: Maarten Pronk
>Assignee: Kouhei Sutou
>Priority: Major
>
> As mentioned in ARROW-18255, over at
> [https://github.com/JuliaPackaging/Yggdrasil/pull/5425,] we cross-compile
> Arrow to make it easily available within the Julia ecosystem.
> When compiling with `DARROW_THRIFT_USE_SHARED=ON` and using an external
> libthrift, CMAKE warns with:
>
> {quote}[12:00:54] CMake Warning (dev) in CMakeLists.txt:
> [12:00:54] Policy CMP0111 is not set: An imported target missing its
> location property
> [12:00:54] fails during generation. Run "cmake --help-policy CMP0111" for
> policy
> [12:00:54] details. Use the cmake_policy command to set the policy and
> suppress this
> [12:00:54] warning.
> [12:00:54]
> [12:00:54] IMPORTED_IMPLIB not set for imported target "thrift::thrift"
> configuration
> [12:00:54] "RELEASE".
> [12:00:54] This warning is for project developers. Use -Wno-dev to suppress
> it.
> {quote}
> This will lead to linking errors later on. I've fixed the warning with the
> following patch for v10.
>
> {quote}{{diff --git a/cpp/cmake_modules/FindThrift.cmake
> b/cpp/cmake_modules/FindThrift.cmake}}
> {{index 2f20a5cb5..2d1e728aa 100644}}
> {{--- a/cpp/cmake_modules/FindThrift.cmake}}
> {{+++ b/cpp/cmake_modules/FindThrift.cmake}}
> {{@@ -146,6 +146,7 @@ if(Thrift_FOUND)}}
> {{ endif()}}
> {{ set_target_properties(thrift::thrift}}
> {{ PROPERTIES IMPORTED_LOCATION "${THRIFT_LIB}"}}
> {{+ IMPORTED_IMPLIB "${THRIFT_LIB}"}}
> {{ INTERFACE_INCLUDE_DIRECTORIES
> "${THRIFT_INCLUDE_DIR}")}}
> {{ if(WIN32 AND NOT MSVC_TOOLCHAIN)}}
> {{ # We don't need this for Visual C++ because Thrift uses}}
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (ARROW-18256) [C++] External/shared libthrift requires IMPORTED_IMPLIB in FindThrift.cmake
[
https://issues.apache.org/jira/browse/ARROW-18256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kouhei Sutou reassigned ARROW-18256:
Assignee: Kouhei Sutou
> [C++] External/shared libthrift requires IMPORTED_IMPLIB in FindThrift.cmake
> -
>
> Key: ARROW-18256
> URL: https://issues.apache.org/jira/browse/ARROW-18256
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
>Affects Versions: 10.0.0
>Reporter: Maarten Pronk
>Assignee: Kouhei Sutou
>Priority: Major
>
> As mentioned in ARROW-18255, over at
> [https://github.com/JuliaPackaging/Yggdrasil/pull/5425,] we cross-compile
> Arrow to make it easily available within the Julia ecosystem.
> When compiling with `DARROW_THRIFT_USE_SHARED=ON` and using an external
> libthrift, CMAKE warns with:
>
> {quote}[12:00:54] CMake Warning (dev) in CMakeLists.txt:
> [12:00:54] Policy CMP0111 is not set: An imported target missing its
> location property
> [12:00:54] fails during generation. Run "cmake --help-policy CMP0111" for
> policy
> [12:00:54] details. Use the cmake_policy command to set the policy and
> suppress this
> [12:00:54] warning.
> [12:00:54]
> [12:00:54] IMPORTED_IMPLIB not set for imported target "thrift::thrift"
> configuration
> [12:00:54] "RELEASE".
> [12:00:54] This warning is for project developers. Use -Wno-dev to suppress
> it.
> {quote}
> This will lead to linking errors later on. I've fixed the warning with the
> following patch for v10.
>
> {quote}{{diff --git a/cpp/cmake_modules/FindThrift.cmake
> b/cpp/cmake_modules/FindThrift.cmake}}
> {{index 2f20a5cb5..2d1e728aa 100644}}
> {{--- a/cpp/cmake_modules/FindThrift.cmake}}
> {{+++ b/cpp/cmake_modules/FindThrift.cmake}}
> {{@@ -146,6 +146,7 @@ if(Thrift_FOUND)}}
> {{ endif()}}
> {{ set_target_properties(thrift::thrift}}
> {{ PROPERTIES IMPORTED_LOCATION "${THRIFT_LIB}"}}
> {{+ IMPORTED_IMPLIB "${THRIFT_LIB}"}}
> {{ INTERFACE_INCLUDE_DIRECTORIES
> "${THRIFT_INCLUDE_DIR}")}}
> {{ if(WIN32 AND NOT MSVC_TOOLCHAIN)}}
> {{ # We don't need this for Visual C++ because Thrift uses}}
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARROW-16778) [C++] 32 bit MSVC doesn't build
[
https://issues.apache.org/jira/browse/ARROW-16778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629525#comment-17629525
]
Apache Arrow JIRA Bot commented on ARROW-16778:
---
This issue was last updated over 90 days ago, which may be an indication it is
no longer being actively worked. To better reflect the current state, the issue
is being unassigned per [project
policy|https://arrow.apache.org/docs/dev/developers/bug_reports.html#issue-assignment].
Please feel free to re-take assignment of the issue if it is being actively
worked, or if you plan to start that work soon.
> [C++] 32 bit MSVC doesn't build
> ---
>
> Key: ARROW-16778
> URL: https://issues.apache.org/jira/browse/ARROW-16778
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Environment: Win32, MSVC
>Reporter: Arkadiy Vertleyb
>Assignee: Arkadiy Vertleyb
>Priority: Major
> Labels: pull-request-available
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> When specifying Win32 as a platform, and building with MSVC, the build fails
> with the following compile errors :
> {noformat}
> C:\Users\avertleyb\git\arrow\cpp\src\arrow/util/bit_util.h(70,59): error
> C3861: '__popcnt64': identifier not found
> [C:\Users\avertleyb\git\arrow\cpp\build32\src\arrow\arrow_shared.vcxproj]
> C:\Users\avertleyb\git\arrow\cpp\src\arrow/util/bit_util.h(204,7): error
> C3861: '_BitScanReverse64': identifier not found
> [C:\Users\avertleyb\git\arrow\cpp\build32\src\arrow\arrow_shared.vcxproj]
> C:\Users\avertleyb\git\arrow\cpp\src\arrow/util/bit_util.h(250,7): error
> C3861: '_BitScanForward64': identifier not found
> [C:\Users\avertleyb\git\arrow\cpp\build32\src\arrow\arrow_shared.vcxproj]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (ARROW-16778) [C++] 32 bit MSVC doesn't build
[
https://issues.apache.org/jira/browse/ARROW-16778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apache Arrow JIRA Bot reassigned ARROW-16778:
-
Assignee: (was: Arkadiy Vertleyb)
> [C++] 32 bit MSVC doesn't build
> ---
>
> Key: ARROW-16778
> URL: https://issues.apache.org/jira/browse/ARROW-16778
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Environment: Win32, MSVC
>Reporter: Arkadiy Vertleyb
>Priority: Major
> Labels: pull-request-available
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> When specifying Win32 as a platform, and building with MSVC, the build fails
> with the following compile errors :
> {noformat}
> C:\Users\avertleyb\git\arrow\cpp\src\arrow/util/bit_util.h(70,59): error
> C3861: '__popcnt64': identifier not found
> [C:\Users\avertleyb\git\arrow\cpp\build32\src\arrow\arrow_shared.vcxproj]
> C:\Users\avertleyb\git\arrow\cpp\src\arrow/util/bit_util.h(204,7): error
> C3861: '_BitScanReverse64': identifier not found
> [C:\Users\avertleyb\git\arrow\cpp\build32\src\arrow\arrow_shared.vcxproj]
> C:\Users\avertleyb\git\arrow\cpp\src\arrow/util/bit_util.h(250,7): error
> C3861: '_BitScanForward64': identifier not found
> [C:\Users\avertleyb\git\arrow\cpp\build32\src\arrow\arrow_shared.vcxproj]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (ARROW-18255) [C++] Support armv6
[ https://issues.apache.org/jira/browse/ARROW-18255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yibo Cai reassigned ARROW-18255: Assignee: Yibo Cai > [C++] Support armv6 > --- > > Key: ARROW-18255 > URL: https://issues.apache.org/jira/browse/ARROW-18255 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Affects Versions: 10.0.0 >Reporter: Maarten Pronk >Assignee: Yibo Cai >Priority: Critical > Fix For: 11.0.0 > > > Over at [https://github.com/JuliaPackaging/Yggdrasil/pull/5425,] we > cross-compile Arrow to make it easily available within the Julia ecosystem. > This will for example enable a GDAL with Arrow/Parquet driver support that > can be installed for everyone. > We noticed when going from v9 to v10, `armv6` (or any non-defined cpu > architecture really) now gives an error when compiling. The change is in > `cpp/cmake_modules/SetupCxxFlags.cmake`. We now patch the code by giving > armv6 the same status as armv7, which seems to work. > Would it be possible to not error out on unknown platforms? A warning with > this platform is not officially supported could be an alternative. Or, the > other way, you could confirm that armv6 (and others) are just _really_ > unsupported (as in probably breaking) and we should not attempt to compile > for those platforms? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARROW-18255) [C++] Support armv6
[ https://issues.apache.org/jira/browse/ARROW-18255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629486#comment-17629486 ] Yibo Cai commented on ARROW-18255: -- [~evetion], thanks for the report. We did have a short discussion about whether to fail loudly or warn on unknown arch. https://github.com/apache/arrow/pull/13902/files#r947586245 Given this issue, looks a warning is better? BTW: Is Julia tested on armv6 platform since it publishes armv6 binary? > [C++] Support armv6 > --- > > Key: ARROW-18255 > URL: https://issues.apache.org/jira/browse/ARROW-18255 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Affects Versions: 10.0.0 >Reporter: Maarten Pronk >Priority: Critical > Fix For: 11.0.0 > > > Over at [https://github.com/JuliaPackaging/Yggdrasil/pull/5425,] we > cross-compile Arrow to make it easily available within the Julia ecosystem. > This will for example enable a GDAL with Arrow/Parquet driver support that > can be installed for everyone. > We noticed when going from v9 to v10, `armv6` (or any non-defined cpu > architecture really) now gives an error when compiling. The change is in > `cpp/cmake_modules/SetupCxxFlags.cmake`. We now patch the code by giving > armv6 the same status as armv7, which seems to work. > Would it be possible to not error out on unknown platforms? A warning with > this platform is not officially supported could be an alternative. Or, the > other way, you could confirm that armv6 (and others) are just _really_ > unsupported (as in probably breaking) and we should not attempt to compile > for those platforms? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARROW-18257) [Python] array of time64 type changes from Time64Type to DataType
created ARROW-18257:
Summary: [Python] array of time64 type changes from Time64Type to
DataType
Key: ARROW-18257
URL: https://issues.apache.org/jira/browse/ARROW-18257
Project: Apache Arrow
Issue Type: Bug
Environment: python 3.9
pyarrow 10.0.0
No pandas installed
Reporter:
When creating an array of time64 elements, the array type information is
changed from Time64Type to DataType.
While it's not an issue as such, given it still looks like an array of time64,
I can't access special attributes of the Time64Type (for example unit)
{code:java}
dtype = pa.time64("ns")
time_array = pa.array(
[
1,
2,
3
],
dtype
)
assert pa.types.is_time64(time_array.type) is True
assert isinstance(dtype, pa.Time64Type) is True
assert isinstance(time_array.type, pa.Time64Type) is False # Wrong
assert isinstance(time_array.type, pa.DataType) is True # Wrong
assert dtype == time_array.type
assert dtype.unit == "ns"
with pytest.raises(AttributeError, match=r"'pyarrow.lib.DataType' object has no
attribute 'unit'"):
# Should be able to access unit:
time_array.type.unit{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (ARROW-18256) [C++] External/shared libthrift requires IMPORTED_IMPLIB in FindThrift.cmake
Maarten Pronk created ARROW-18256:
-
Summary: [C++] External/shared libthrift requires IMPORTED_IMPLIB
in FindThrift.cmake
Key: ARROW-18256
URL: https://issues.apache.org/jira/browse/ARROW-18256
Project: Apache Arrow
Issue Type: Bug
Components: C++
Affects Versions: 10.0.0
Reporter: Maarten Pronk
As mentioned in ARROW-18255, over at
[https://github.com/JuliaPackaging/Yggdrasil/pull/5425,] we cross-compile Arrow
to make it easily available within the Julia ecosystem.
When compiling with `DARROW_THRIFT_USE_SHARED=ON` and using an external
libthrift, CMAKE warns with:
{quote}[12:00:54] CMake Warning (dev) in CMakeLists.txt:
[12:00:54] Policy CMP0111 is not set: An imported target missing its location
property
[12:00:54] fails during generation. Run "cmake --help-policy CMP0111" for
policy
[12:00:54] details. Use the cmake_policy command to set the policy and
suppress this
[12:00:54] warning.
[12:00:54]
[12:00:54] IMPORTED_IMPLIB not set for imported target "thrift::thrift"
configuration
[12:00:54] "RELEASE".
[12:00:54] This warning is for project developers. Use -Wno-dev to suppress it.
{quote}
This will lead to linking errors later on. I've fixed the warning with the
following patch for v10.
{quote}{{diff --git a/cpp/cmake_modules/FindThrift.cmake
b/cpp/cmake_modules/FindThrift.cmake}}
{{index 2f20a5cb5..2d1e728aa 100644}}
{{--- a/cpp/cmake_modules/FindThrift.cmake}}
{{+++ b/cpp/cmake_modules/FindThrift.cmake}}
{{@@ -146,6 +146,7 @@ if(Thrift_FOUND)}}
{{ endif()}}
{{ set_target_properties(thrift::thrift}}
{{ PROPERTIES IMPORTED_LOCATION "${THRIFT_LIB}"}}
{{+ IMPORTED_IMPLIB "${THRIFT_LIB}"}}
{{ INTERFACE_INCLUDE_DIRECTORIES
"${THRIFT_INCLUDE_DIR}")}}
{{ if(WIN32 AND NOT MSVC_TOOLCHAIN)}}
{{ # We don't need this for Visual C++ because Thrift uses}}
{quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARROW-18255) [C++] Support armv6
[ https://issues.apache.org/jira/browse/ARROW-18255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629446#comment-17629446 ] Antoine Pitrou commented on ARROW-18255: While I don't know about "armv6" specifically, I agree that we should probably not error out just because the architecture is unknown. cc [~yibocai] [~kou] > [C++] Support armv6 > --- > > Key: ARROW-18255 > URL: https://issues.apache.org/jira/browse/ARROW-18255 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Affects Versions: 10.0.0 >Reporter: Maarten Pronk >Priority: Major > > Over at [https://github.com/JuliaPackaging/Yggdrasil/pull/5425,] we > cross-compile Arrow to make it easily available within the Julia ecosystem. > This will for example enable a GDAL with Arrow/Parquet driver support that > can be installed for everyone. > We noticed when going from v9 to v10, `armv6` (or any non-defined cpu > architecture really) now gives an error when compiling. The change is in > `cpp/cmake_modules/SetupCxxFlags.cmake`. We now patch the code by giving > armv6 the same status as armv7, which seems to work. > Would it be possible to not error out on unknown platforms? A warning with > this platform is not officially supported could be an alternative. Or, the > other way, you could confirm that armv6 (and others) are just _really_ > unsupported (as in probably breaking) and we should not attempt to compile > for those platforms? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARROW-18255) [C++] Support armv6
[ https://issues.apache.org/jira/browse/ARROW-18255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antoine Pitrou updated ARROW-18255: --- Priority: Critical (was: Major) > [C++] Support armv6 > --- > > Key: ARROW-18255 > URL: https://issues.apache.org/jira/browse/ARROW-18255 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Affects Versions: 10.0.0 >Reporter: Maarten Pronk >Priority: Critical > Fix For: 11.0.0 > > > Over at [https://github.com/JuliaPackaging/Yggdrasil/pull/5425,] we > cross-compile Arrow to make it easily available within the Julia ecosystem. > This will for example enable a GDAL with Arrow/Parquet driver support that > can be installed for everyone. > We noticed when going from v9 to v10, `armv6` (or any non-defined cpu > architecture really) now gives an error when compiling. The change is in > `cpp/cmake_modules/SetupCxxFlags.cmake`. We now patch the code by giving > armv6 the same status as armv7, which seems to work. > Would it be possible to not error out on unknown platforms? A warning with > this platform is not officially supported could be an alternative. Or, the > other way, you could confirm that armv6 (and others) are just _really_ > unsupported (as in probably breaking) and we should not attempt to compile > for those platforms? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARROW-18255) [C++] Support armv6
[ https://issues.apache.org/jira/browse/ARROW-18255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antoine Pitrou updated ARROW-18255: --- Fix Version/s: 11.0.0 > [C++] Support armv6 > --- > > Key: ARROW-18255 > URL: https://issues.apache.org/jira/browse/ARROW-18255 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Affects Versions: 10.0.0 >Reporter: Maarten Pronk >Priority: Major > Fix For: 11.0.0 > > > Over at [https://github.com/JuliaPackaging/Yggdrasil/pull/5425,] we > cross-compile Arrow to make it easily available within the Julia ecosystem. > This will for example enable a GDAL with Arrow/Parquet driver support that > can be installed for everyone. > We noticed when going from v9 to v10, `armv6` (or any non-defined cpu > architecture really) now gives an error when compiling. The change is in > `cpp/cmake_modules/SetupCxxFlags.cmake`. We now patch the code by giving > armv6 the same status as armv7, which seems to work. > Would it be possible to not error out on unknown platforms? A warning with > this platform is not officially supported could be an alternative. Or, the > other way, you could confirm that armv6 (and others) are just _really_ > unsupported (as in probably breaking) and we should not attempt to compile > for those platforms? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARROW-18255) [C++] Support armv6
[ https://issues.apache.org/jira/browse/ARROW-18255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antoine Pitrou updated ARROW-18255: --- Component/s: C++ > [C++] Support armv6 > --- > > Key: ARROW-18255 > URL: https://issues.apache.org/jira/browse/ARROW-18255 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Affects Versions: 10.0.0 >Reporter: Maarten Pronk >Priority: Major > > Over at [https://github.com/JuliaPackaging/Yggdrasil/pull/5425,] we > cross-compile Arrow to make it easily available within the Julia ecosystem. > This will for example enable a GDAL with Arrow/Parquet driver support that > can be installed for everyone. > We noticed when going from v9 to v10, `armv6` (or any non-defined cpu > architecture really) now gives an error when compiling. The change is in > `cpp/cmake_modules/SetupCxxFlags.cmake`. We now patch the code by giving > armv6 the same status as armv7, which seems to work. > Would it be possible to not error out on unknown platforms? A warning with > this platform is not officially supported could be an alternative. Or, the > other way, you could confirm that armv6 (and others) are just _really_ > unsupported (as in probably breaking) and we should not attempt to compile > for those platforms? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARROW-18255) [C++] Support armv6
Maarten Pronk created ARROW-18255: - Summary: [C++] Support armv6 Key: ARROW-18255 URL: https://issues.apache.org/jira/browse/ARROW-18255 Project: Apache Arrow Issue Type: Improvement Affects Versions: 10.0.0 Reporter: Maarten Pronk Over at [https://github.com/JuliaPackaging/Yggdrasil/pull/5425,] we cross-compile Arrow to make it easily available within the Julia ecosystem. This will for example enable a GDAL with Arrow/Parquet driver support that can be installed for everyone. We noticed when going from v9 to v10, `armv6` (or any non-defined cpu architecture really) now gives an error when compiling. The change is in `cpp/cmake_modules/SetupCxxFlags.cmake`. We now patch the code by giving armv6 the same status as armv7, which seems to work. Would it be possible to not error out on unknown platforms? A warning with this platform is not officially supported could be an alternative. Or, the other way, you could confirm that armv6 (and others) are just _really_ unsupported (as in probably breaking) and we should not attempt to compile for those platforms? -- This message was sent by Atlassian Jira (v8.20.10#820010)
