[jira] [Comment Edited] (ARROW-17937) [C++] Building of Arrow C++ (dataset) errors on Windows

2022-10-13 Thread Ben Harkins (Jira) 


[ 
https://issues.apache.org/jira/browse/ARROW-17937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617452#comment-17617452
 ] 

Ben Harkins edited comment on ARROW-17937 at 10/14/22 4:25 AM:
---

Unfortunately, I haven't been able to reproduce this, but FWIW, It looks like 
{{-DARROW_DS_STATIC}} isn't being forwarded to the compiler for some reason. 
Normally, there wouldn't be a linkage discrepancy. See: 
([1|https://github.com/apache/arrow/blob/master/cpp/src/arrow/dataset/visibility.h#L30])

For reference, my output looks like this:
{code:java}
C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\MSVC\1433~1.316\bin\Hostx64\x64\cl.exe
  /nologo /TP -DARROW_DS_EXPORTING -DARROW_DS_STATIC -DARROW_FLIGHT_SQL_STATIC 
-DARROW_FLIGHT_STATIC -DARROW_HAVE_RUNTIME_AVX2 -DARROW_HAVE_RUNTIME_AVX512 
-DARROW_HAVE_RUNTIME_BMI2 -DARROW_HAVE_RUNTIME_SSE4_2 -DARROW_HAVE_SSE4_2 
-DARROW_HDFS -DARROW_STATIC -DARROW_WITH_LZ4 -DARROW_WITH_RE2 
-DARROW_WITH_SNAPPY -DARROW_WITH_TIMING_TESTS -DARROW_WITH_UTF8PROC 
-DARROW_WITH_ZLIB -DARROW_WITH_ZSTD -DBOOST_ALL_DYN_LINK -DBOOST_ALL_NO_LIB 
-DPARQUET_STATIC -DURI_STATIC_BUILD -D_CRT_SECURE_NO_WARNINGS 
-D_ENABLE_EXTENDED_ALIGNED_STORAGE -IC:\Users\Ben\Dev\arrow\cpp\build\src 
-IC:\Users\Ben\Dev\arrow\cpp\src -IC:\Users\Ben\Dev\arrow\cpp\src\generated 
-IC:\Users\Ben\Dev\arrow\cpp\src\parquet 
-external:IC:\Users\Ben\Dev\arrow\cpp\thirdparty\flatbuffers\include 
-external:IC:\Users\Ben\Dev\arrow\cpp\thirdparty\hadoop\include 
-external:IC:\Users\Ben\miniconda3\envs\pyarrow-dev\Library\include 
-external:W0 /DWIN32 /D_WINDOWS  /GR /EHsc 
/D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING   /EHsc /wd5105 /bigobj /utf-8 /W3 
/wd4800 /wd4996 /wd4065  /WX /MP /MD /O2 /Ob2 /DNDEBUG -std:c++17 /showIncludes 
/Fosrc\arrow\dataset\CMakeFiles\arrow_dataset_static.dir\discovery.cc.obj{code}


was (Author: JIRAUSER295145):
Unfortunately, I haven't been able to reproduce this, but FWIW, It looks like 
{{-DARROW_DS_STATIC}} isn't being forwarded to the compiler for some reason. 
Normally, there wouldn't be a linkage discrepancy. See: 
[[1|https://github.com/apache/arrow/blob/master/cpp/src/arrow/dataset/visibility.h#L30]]

For reference, my output looks like this:
{code:java}
C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\MSVC\1433~1.316\bin\Hostx64\x64\cl.exe
  /nologo /TP -DARROW_DS_EXPORTING -DARROW_DS_STATIC -DARROW_FLIGHT_SQL_STATIC 
-DARROW_FLIGHT_STATIC -DARROW_HAVE_RUNTIME_AVX2 -DARROW_HAVE_RUNTIME_AVX512 
-DARROW_HAVE_RUNTIME_BMI2 -DARROW_HAVE_RUNTIME_SSE4_2 -DARROW_HAVE_SSE4_2 
-DARROW_HDFS -DARROW_STATIC -DARROW_WITH_LZ4 -DARROW_WITH_RE2 
-DARROW_WITH_SNAPPY -DARROW_WITH_TIMING_TESTS -DARROW_WITH_UTF8PROC 
-DARROW_WITH_ZLIB -DARROW_WITH_ZSTD -DBOOST_ALL_DYN_LINK -DBOOST_ALL_NO_LIB 
-DPARQUET_STATIC -DURI_STATIC_BUILD -D_CRT_SECURE_NO_WARNINGS 
-D_ENABLE_EXTENDED_ALIGNED_STORAGE -IC:\Users\Ben\Dev\arrow\cpp\build\src 
-IC:\Users\Ben\Dev\arrow\cpp\src -IC:\Users\Ben\Dev\arrow\cpp\src\generated 
-IC:\Users\Ben\Dev\arrow\cpp\src\parquet 
-external:IC:\Users\Ben\Dev\arrow\cpp\thirdparty\flatbuffers\include 
-external:IC:\Users\Ben\Dev\arrow\cpp\thirdparty\hadoop\include 
-external:IC:\Users\Ben\miniconda3\envs\pyarrow-dev\Library\include 
-external:W0 /DWIN32 /D_WINDOWS  /GR /EHsc 
/D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING   /EHsc /wd5105 /bigobj /utf-8 /W3 
/wd4800 /wd4996 /wd4065  /WX /MP /MD /O2 /Ob2 /DNDEBUG -std:c++17 /showIncludes 
/Fosrc\arrow\dataset\CMakeFiles\arrow_dataset_static.dir\discovery.cc.obj{code}

> [C++] Building of Arrow C++ (dataset) errors on Windows
> ---
>
> Key: ARROW-17937
> URL: https://issues.apache.org/jira/browse/ARROW-17937
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: C++
>Reporter: Alenka Frim
>Priority: Major
>
> Building of Arrow C++ fails for me on Windows if I keep static build on by 
> default and works with ARROW_STATIC=OFF:
> {code:java}
> (pyarrow-dev310) C:\Users\Alenka\repos\arrow\cpp\build>cmake --build . 
> --target install --config Release[482/590] Building CXX object 
> src\arrow\dataset\CMakeFiles\arrow_dataset_static.dir\discovery.cc.objFAILED: 
> src/arrow/dataset/CMakeFiles/arrow_dataset_static.dir/discovery.cc.objC:\PROGRA~2\MIB055~1\2017\COMMUN~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\cl.exe
>   /nologo /TP -DARROW_DS_EXPORTING -DARROW_FLIGHT_SQL_STATIC 
> -DARROW_FLIGHT_STATIC -DARROW_HAVE_RUNTIME_AVX2 -DARROW_HAVE_RUNTIME_AVX512 
> -DARROW_HAVE_RUNTIME_BMI2 -DARROW_HAVE_RUNTIME_SSE4_2 -DARROW_HAVE_SSE4_2 
> -DARROW_HDFS -DARROW_STATIC -DARROW_WITH_LZ4 -DARROW_WITH_RE2 
> -DARROW_WITH_SNAPPY -DARROW_WITH_TIMING_TESTS -DARROW_WITH_UTF8PROC 
> -DARROW_WITH_ZLIB -DARROW_WITH_ZSTD -DBOOST_ALL_DYN_LINK -DBOOST_ALL_NO_LIB 
> -DPARQUET_STATIC -DURI_STATIC_BUILD -D_CRT_SECURE_NO_WARNINGS 
> -D_ENABL

[jira] [Comment Edited] (ARROW-17937) [C++] Building of Arrow C++ (dataset) errors on Windows

2022-10-13 Thread Ben Harkins (Jira) 


[ 
https://issues.apache.org/jira/browse/ARROW-17937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617452#comment-17617452
 ] 

Ben Harkins edited comment on ARROW-17937 at 10/14/22 4:22 AM:
---

Unfortunately, I haven't been able to reproduce this, but FWIW, It looks like 
{{-DARROW_DS_STATIC}} isn't being forwarded to the compiler for some reason. 
Normally, there wouldn't be a linkage discrepancy. See: 
[[1|https://github.com/apache/arrow/blob/master/cpp/src/arrow/dataset/visibility.h#L30]]

For reference, my output looks like this:
{code:java}
C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\MSVC\1433~1.316\bin\Hostx64\x64\cl.exe
  /nologo /TP -DARROW_DS_EXPORTING -DARROW_DS_STATIC -DARROW_FLIGHT_SQL_STATIC 
-DARROW_FLIGHT_STATIC -DARROW_HAVE_RUNTIME_AVX2 -DARROW_HAVE_RUNTIME_AVX512 
-DARROW_HAVE_RUNTIME_BMI2 -DARROW_HAVE_RUNTIME_SSE4_2 -DARROW_HAVE_SSE4_2 
-DARROW_HDFS -DARROW_STATIC -DARROW_WITH_LZ4 -DARROW_WITH_RE2 
-DARROW_WITH_SNAPPY -DARROW_WITH_TIMING_TESTS -DARROW_WITH_UTF8PROC 
-DARROW_WITH_ZLIB -DARROW_WITH_ZSTD -DBOOST_ALL_DYN_LINK -DBOOST_ALL_NO_LIB 
-DPARQUET_STATIC -DURI_STATIC_BUILD -D_CRT_SECURE_NO_WARNINGS 
-D_ENABLE_EXTENDED_ALIGNED_STORAGE -IC:\Users\Ben\Dev\arrow\cpp\build\src 
-IC:\Users\Ben\Dev\arrow\cpp\src -IC:\Users\Ben\Dev\arrow\cpp\src\generated 
-IC:\Users\Ben\Dev\arrow\cpp\src\parquet 
-external:IC:\Users\Ben\Dev\arrow\cpp\thirdparty\flatbuffers\include 
-external:IC:\Users\Ben\Dev\arrow\cpp\thirdparty\hadoop\include 
-external:IC:\Users\Ben\miniconda3\envs\pyarrow-dev\Library\include 
-external:W0 /DWIN32 /D_WINDOWS  /GR /EHsc 
/D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING   /EHsc /wd5105 /bigobj /utf-8 /W3 
/wd4800 /wd4996 /wd4065  /WX /MP /MD /O2 /Ob2 /DNDEBUG -std:c++17 /showIncludes 
/Fosrc\arrow\dataset\CMakeFiles\arrow_dataset_static.dir\discovery.cc.obj{code}


was (Author: JIRAUSER295145):
Unfortunately, I haven't been able to reproduce this, but FWIW, It looks like 
{{-DARROW_DS_STATIC}} isn't being forwarded to the compiler for some reason. 
Normally, there wouldn't be a linkage discrepancy 
[[https://github.com/apache/arrow/blob/master/cpp/src/arrow/dataset/visibility.h#L30]].

For reference, my output looks like this:
{code:java}
C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\MSVC\1433~1.316\bin\Hostx64\x64\cl.exe
  /nologo /TP -DARROW_DS_EXPORTING -DARROW_DS_STATIC -DARROW_FLIGHT_SQL_STATIC 
-DARROW_FLIGHT_STATIC -DARROW_HAVE_RUNTIME_AVX2 -DARROW_HAVE_RUNTIME_AVX512 
-DARROW_HAVE_RUNTIME_BMI2 -DARROW_HAVE_RUNTIME_SSE4_2 -DARROW_HAVE_SSE4_2 
-DARROW_HDFS -DARROW_STATIC -DARROW_WITH_LZ4 -DARROW_WITH_RE2 
-DARROW_WITH_SNAPPY -DARROW_WITH_TIMING_TESTS -DARROW_WITH_UTF8PROC 
-DARROW_WITH_ZLIB -DARROW_WITH_ZSTD -DBOOST_ALL_DYN_LINK -DBOOST_ALL_NO_LIB 
-DPARQUET_STATIC -DURI_STATIC_BUILD -D_CRT_SECURE_NO_WARNINGS 
-D_ENABLE_EXTENDED_ALIGNED_STORAGE -IC:\Users\Ben\Dev\arrow\cpp\build\src 
-IC:\Users\Ben\Dev\arrow\cpp\src -IC:\Users\Ben\Dev\arrow\cpp\src\generated 
-IC:\Users\Ben\Dev\arrow\cpp\src\parquet 
-external:IC:\Users\Ben\Dev\arrow\cpp\thirdparty\flatbuffers\include 
-external:IC:\Users\Ben\Dev\arrow\cpp\thirdparty\hadoop\include 
-external:IC:\Users\Ben\miniconda3\envs\pyarrow-dev\Library\include 
-external:W0 /DWIN32 /D_WINDOWS  /GR /EHsc 
/D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING   /EHsc /wd5105 /bigobj /utf-8 /W3 
/wd4800 /wd4996 /wd4065  /WX /MP /MD /O2 /Ob2 /DNDEBUG -std:c++17 /showIncludes 
/Fosrc\arrow\dataset\CMakeFiles\arrow_dataset_static.dir\discovery.cc.obj{code}

> [C++] Building of Arrow C++ (dataset) errors on Windows
> ---
>
> Key: ARROW-17937
> URL: https://issues.apache.org/jira/browse/ARROW-17937
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: C++
>Reporter: Alenka Frim
>Priority: Major
>
> Building of Arrow C++ fails for me on Windows if I keep static build on by 
> default and works with ARROW_STATIC=OFF:
> {code:java}
> (pyarrow-dev310) C:\Users\Alenka\repos\arrow\cpp\build>cmake --build . 
> --target install --config Release[482/590] Building CXX object 
> src\arrow\dataset\CMakeFiles\arrow_dataset_static.dir\discovery.cc.objFAILED: 
> src/arrow/dataset/CMakeFiles/arrow_dataset_static.dir/discovery.cc.objC:\PROGRA~2\MIB055~1\2017\COMMUN~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\cl.exe
>   /nologo /TP -DARROW_DS_EXPORTING -DARROW_FLIGHT_SQL_STATIC 
> -DARROW_FLIGHT_STATIC -DARROW_HAVE_RUNTIME_AVX2 -DARROW_HAVE_RUNTIME_AVX512 
> -DARROW_HAVE_RUNTIME_BMI2 -DARROW_HAVE_RUNTIME_SSE4_2 -DARROW_HAVE_SSE4_2 
> -DARROW_HDFS -DARROW_STATIC -DARROW_WITH_LZ4 -DARROW_WITH_RE2 
> -DARROW_WITH_SNAPPY -DARROW_WITH_TIMING_TESTS -DARROW_WITH_UTF8PROC 
> -DARROW_WITH_ZLIB -DARROW_WITH_ZSTD -DBOOST_ALL_DYN_LINK -DBOOST_ALL_NO_LIB 
> -DPARQUET_STATIC -DURI_STATIC_BUILD -D_CRT_SECURE_NO_WARNINGS 
> -D_ENABLE_EXTEN