[jira] [Commented] (ARROW-13598) [C++] Deprecate Datum::COLLECTION

2021-11-23 Thread David Li (Jira)


[ 
https://issues.apache.org/jira/browse/ARROW-13598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17448155#comment-17448155
 ] 

David Li commented on ARROW-13598:
--

If it's not used, I think we may as well remove it. We can always restore it if 
it does turn out to be useful. It seems to me, though, that instead of having a 
Datum contain more Datums, we'd rather instead have a stream of Datums (as 
indeed the query engine effectively does).

> [C++] Deprecate Datum::COLLECTION
> -
>
> Key: ARROW-13598
> URL: https://issues.apache.org/jira/browse/ARROW-13598
> Project: Apache Arrow
>  Issue Type: Task
>  Components: C++
>Reporter: Antoine Pitrou
>Priority: Minor
> Fix For: 7.0.0
>
>
> It looks like "collection" datums are not used anywhere. Where we want to 
> return several pieces of data, we generally return a Struct array or scalar 
> wrapping them.
> Perhaps we should simply deprecate or even remove them.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (ARROW-13598) [C++] Deprecate Datum::COLLECTION

2021-11-23 Thread Antoine Pitrou (Jira)


[ 
https://issues.apache.org/jira/browse/ARROW-13598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17448152#comment-17448152
 ] 

Antoine Pitrou commented on ARROW-13598:


[~lidavidm] What do you think?

> [C++] Deprecate Datum::COLLECTION
> -
>
> Key: ARROW-13598
> URL: https://issues.apache.org/jira/browse/ARROW-13598
> Project: Apache Arrow
>  Issue Type: Task
>  Components: C++
>Reporter: Antoine Pitrou
>Priority: Minor
> Fix For: 7.0.0
>
>
> It looks like "collection" datums are not used anywhere. Where we want to 
> return several pieces of data, we generally return a Struct array or scalar 
> wrapping them.
> Perhaps we should simply deprecate or even remove them.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (ARROW-13598) [C++] Deprecate Datum::COLLECTION

2021-08-10 Thread Antoine Pitrou (Jira)


[ 
https://issues.apache.org/jira/browse/ARROW-13598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396745#comment-17396745
 ] 

Antoine Pitrou commented on ARROW-13598:


[~wesm] [~bkietz] What do you think?

> [C++] Deprecate Datum::COLLECTION
> -
>
> Key: ARROW-13598
> URL: https://issues.apache.org/jira/browse/ARROW-13598
> Project: Apache Arrow
>  Issue Type: Task
>  Components: C++
>Reporter: Antoine Pitrou
>Priority: Minor
> Fix For: 6.0.0
>
>
> It looks like "collection" datums are not used anywhere. Where we want to 
> return several pieces of data, we generally return a Struct array or scalar 
> wrapping them.
> Perhaps we should simply deprecate or even remove them.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)