[
https://issues.apache.org/jira/browse/ARROW-15774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497626#comment-17497626
]
Antoine Pitrou commented on ARROW-15774:
----------------------------------------
I took some time looking at this. It appears that {{ARROW_HIVESERVER2}} is
currently completely broken (it probably has been for a long time).
Observations:
* we should track the generated {{ErrorCodes.thrift}} in the repository,
instead of having to run the Python script generating it on each build
* we should put the generated C++ files for thrift definitions inside a new
{{src/generated/hiveserver2}} directory
* we should update {{build-support/update-thrift.sh}} to recreate said C++
generated files
* when I tried to do all the above, it appears that _some_ files are not
generated by the Thrift compiler even though they should, and no error of any
sort is printed out; trying to ignore those absent files doesn't work, as there
are (predictably) missing symbol errors when linking the tests
> [C++] [CMake] Missing hiveserver2 ErrorCodes_types
> --------------------------------------------------
>
> Key: ARROW-15774
> URL: https://issues.apache.org/jira/browse/ARROW-15774
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Environment: Arch Linux 5.16.10; All dependencies are system packages
> Reporter: Pradeep Garigipati
> Priority: Major
> Attachments: cmake_config_generate.log
>
>
> With cmake preset `ninja-release-maximal`, one of the auto-generated files
> seems to be missing and that in turn is resulting in the following error
> {code:sh}
> [96/576] Building CXX object
> src/arrow/dbi/hiveserver2/CMakeFiles/arrow_hiveserver2_thrift.dir/ErrorCodes_types.cpp.o
> FAILED:
> src/arrow/dbi/hiveserver2/CMakeFiles/arrow_hiveserver2_thrift.dir/ErrorCodes_types.cpp.o
>
> /usr/bin/ccache /usr/bin/c++ -DARROW_HAVE_RUNTIME_AVX2
> -DARROW_HAVE_RUNTIME_AVX512 -DARROW_HAVE_RUNTIME_BMI2
> -DARROW_HAVE_RUNTIME_SSE4_2 -DARROW_HAVE_SSE4_2 -DARROW_HDFS -DARROW_JEMALLOC
> -DARROW_JEMALLOC_INCLUDE_DIR="" -DARROW_MIMALLOC -DARROW_WITH_BROTLI
> -DARROW_WITH_BZ2 -DARROW_WITH_LZ4 -DARROW_WITH_RE2 -DARROW_WITH_SNAPPY
> -DARROW_WITH_TIMING_TESTS -DARROW_WITH_UTF8PROC -DARROW_WITH_ZLIB
> -DARROW_WITH_ZSTD -DURI_STATIC_BUILD
> -I/home/pradeep/gitroot/ArrowWorkspace/arrow/cpp/build/src
> -I/home/pradeep/gitroot/ArrowWorkspace/arrow/cpp/src
> -I/home/pradeep/gitroot/ArrowWorkspace/arrow/cpp/src/generated -isystem
> /home/pradeep/gitroot/ArrowWorkspace/arrow/cpp/thirdparty/flatbuffers/include
> -isystem
> /home/pradeep/gitroot/ArrowWorkspace/arrow/cpp/build/jemalloc_ep-prefix/src
> -isystem
> /home/pradeep/gitroot/ArrowWorkspace/arrow/cpp/build/mimalloc_ep/src/mimalloc_ep/include/mimalloc-1.7
> -isystem
> /home/pradeep/gitroot/ArrowWorkspace/arrow/cpp/build/xsimd_ep/src/xsimd_ep-install/include
> -isystem
> /home/pradeep/gitroot/ArrowWorkspace/arrow/cpp/build/zstd_ep-install/include
> -isystem
> /home/pradeep/gitroot/ArrowWorkspace/arrow/cpp/thirdparty/hadoop/include
> -isystem
> /home/pradeep/gitroot/ArrowWorkspace/arrow/cpp/build/orc_ep-install/include
> -Wno-noexcept-type -fdiagnostics-color=always -O3 -DNDEBUG -Wall
> -fno-semantic-interposition -msse4.2 -O3 -DNDEBUG -fPIC -std=c++11
> -Wno-unused-variable -Wno-shadow-field -MD -MT
> src/arrow/dbi/hiveserver2/CMakeFiles/arrow_hiveserver2_thrift.dir/ErrorCodes_types.cpp.o
> -MF
> src/arrow/dbi/hiveserver2/CMakeFiles/arrow_hiveserver2_thrift.dir/ErrorCodes_types.cpp.o.d
> -o
> src/arrow/dbi/hiveserver2/CMakeFiles/arrow_hiveserver2_thrift.dir/ErrorCodes_types.cpp.o
> -c
> /home/pradeep/gitroot/ArrowWorkspace/arrow/cpp/build/src/arrow/dbi/hiveserver2/ErrorCodes_types.cpp
> cc1plus: fatal error:
> /home/pradeep/gitroot/ArrowWorkspace/arrow/cpp/build/src/arrow/dbi/hiveserver2/ErrorCodes_types.cpp:
> No such file or directory
> {code}
> I have attached the cmake log of configuration/generation steps.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
