[jira] [Commented] (ARROW-17598) [C++] Arrow io memory_benchmark does not compile if SIMD level is NEON
[
https://issues.apache.org/jira/browse/ARROW-17598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17599671#comment-17599671
]
Aldrin Montana commented on ARROW-17598:
sounds good [~yibocai]. I wasn't sure if it would need any more discussion
(which is why I made a JIRA instead of submitted a MINOR pr).
I opened a PR, but I don't think the CI will exercise it, so not sure what to
do about that. Let me know if you'd like any other follow up!
> [C++] Arrow io memory_benchmark does not compile if SIMD level is NEON
> --
>
> Key: ARROW-17598
> URL: https://issues.apache.org/jira/browse/ARROW-17598
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
>Reporter: Aldrin Montana
>Assignee: Aldrin Montana
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When compiling Arrow with the following parameter:
> {code:bash}
> -DARROW_BUILD_BENCHMARKS_REFERENCE="ON"
> {code}
> I get this error and other similar ones:
> {code:bash}
> cpp/src/arrow/io/memory_benchmark.cc:244:26: error: use of undeclared
> identifier 'Read'; did you mean 'read'?
> using ApplyFn = decltype(Read);
> {code}
>
> The reason is that `memory_benchmark.cc` does not define the Read function,
> and others, if the SIMD level is NEON (`ARROW_HAVE_NEON` is true).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARROW-17598) [C++] Arrow io memory_benchmark does not compile if SIMD level is NEON
[
https://issues.apache.org/jira/browse/ARROW-17598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17599217#comment-17599217
]
Yibo Cai commented on ARROW-17598:
--
Thanks [~octalene], will you open a PR?
> [C++] Arrow io memory_benchmark does not compile if SIMD level is NEON
> --
>
> Key: ARROW-17598
> URL: https://issues.apache.org/jira/browse/ARROW-17598
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
>Reporter: Aldrin Montana
>Priority: Minor
>
> When compiling Arrow with the following parameter:
> {code:bash}
> -DARROW_BUILD_BENCHMARKS_REFERENCE="ON"
> {code}
> I get this error and other similar ones:
> {code:bash}
> cpp/src/arrow/io/memory_benchmark.cc:244:26: error: use of undeclared
> identifier 'Read'; did you mean 'read'?
> using ApplyFn = decltype(Read);
> {code}
>
> The reason is that `memory_benchmark.cc` does not define the Read function,
> and others, if the SIMD level is NEON (`ARROW_HAVE_NEON` is true).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARROW-17598) [C++] Arrow io memory_benchmark does not compile if SIMD level is NEON
[
https://issues.apache.org/jira/browse/ARROW-17598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17599184#comment-17599184
]
Aldrin Montana commented on ARROW-17598:
I think the easiest thing to do would be to change cmake to not add the
benchmark if the SIMD level is NEON:
{code:cpp}
diff --git a/cpp/src/arrow/io/CMakeLists.txt b/cpp/src/arrow/io/CMakeLists.txt
index 33de37c84..ddf10078b 100644
--- a/cpp/src/arrow/io/CMakeLists.txt
+++ b/cpp/src/arrow/io/CMakeLists.txt
@@ -36,7 +36,8 @@ add_arrow_test(memory_test PREFIX "arrow-io")
add_arrow_benchmark(file_benchmark PREFIX "arrow-io")-if(NOT
(${ARROW_SIMD_LEVEL} STREQUAL "NONE"))
+if(NOT (${ARROW_SIMD_LEVEL} STREQUAL "NONE") AND
+ NOT (${ARROW_SIMD_LEVEL} STREQUAL "NEON"))
# This benchmark either requires SSE4.2 or ARMV8 SIMD to be enabled
add_arrow_benchmark(memory_benchmark PREFIX "arrow-io")
endif()
{code}
> [C++] Arrow io memory_benchmark does not compile if SIMD level is NEON
> --
>
> Key: ARROW-17598
> URL: https://issues.apache.org/jira/browse/ARROW-17598
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
>Reporter: Aldrin Montana
>Priority: Minor
>
> When compiling Arrow with the following parameter:
> ```bash
> -DARROW_BUILD_BENCHMARKS_REFERENCE="ON"
> ```
>
> I get this error and other similar ones:
> ```bash
> cpp/src/arrow/io/memory_benchmark.cc:244:26: error: use of undeclared
> identifier 'Read'; did you mean 'read'?
> using ApplyFn = decltype(Read);
> ```
>
> The reason is that `memory_benchmark.cc` does not define the Read function,
> and others, if the SIMD level is NEON (`ARROW_HAVE_NEON` is true).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
