[jira] [Commented] (ARROW-17696) [C++] arrow-compute-asof-join-node-test inordinately slow
[
https://issues.apache.org/jira/browse/ARROW-17696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17607718#comment-17607718
]
Yaron Gvili commented on ARROW-17696:
-
Note that I'll set the timeout at the test-case level, not for the entire test
executable. I'll cut it down by a factor of 10.
> [C++] arrow-compute-asof-join-node-test inordinately slow
> -
>
> Key: ARROW-17696
> URL: https://issues.apache.org/jira/browse/ARROW-17696
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
>Reporter: Antoine Pitrou
>Priority: Major
>
> It seems that {{arrow-compute-asof-join-node-test}} is designed such as each
> sub-test takes 2 seconds. The entire test file takes 120 seconds here.
> This is much too slow for a single test file and should drastically be
> reduced.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARROW-17696) [C++] arrow-compute-asof-join-node-test inordinately slow
[
https://issues.apache.org/jira/browse/ARROW-17696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17607697#comment-17607697
]
Antoine Pitrou commented on ARROW-17696:
300 seconds might be the timeout set on CI in case a test is stuck, but a test
file shouldn't certainly not come near that duration.
10 seconds max would be a reasonable target IMHO.
> [C++] arrow-compute-asof-join-node-test inordinately slow
> -
>
> Key: ARROW-17696
> URL: https://issues.apache.org/jira/browse/ARROW-17696
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
>Reporter: Antoine Pitrou
>Priority: Major
>
> It seems that {{arrow-compute-asof-join-node-test}} is designed such as each
> sub-test takes 2 seconds. The entire test file takes 120 seconds here.
> This is much too slow for a single test file and should drastically be
> reduced.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARROW-17696) [C++] arrow-compute-asof-join-node-test inordinately slow
[
https://issues.apache.org/jira/browse/ARROW-17696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17607689#comment-17607689
]
Yaron Gvili commented on ARROW-17696:
-
IIRC, at the time, I asked about the timeout for this test, and the answer was
something like 300 seconds. How much do we want it to be? I can set it rather
flexibly.
> [C++] arrow-compute-asof-join-node-test inordinately slow
> -
>
> Key: ARROW-17696
> URL: https://issues.apache.org/jira/browse/ARROW-17696
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
>Reporter: Antoine Pitrou
>Priority: Major
>
> It seems that {{arrow-compute-asof-join-node-test}} is designed such as each
> sub-test takes 2 seconds. The entire test file takes 120 seconds here.
> This is much too slow for a single test file and should drastically be
> reduced.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARROW-17696) [C++] arrow-compute-asof-join-node-test inordinately slow
[
https://issues.apache.org/jira/browse/ARROW-17696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17607597#comment-17607597
]
Antoine Pitrou commented on ARROW-17696:
[~rtpsw] Could you take a look and try to improve things here?
> [C++] arrow-compute-asof-join-node-test inordinately slow
> -
>
> Key: ARROW-17696
> URL: https://issues.apache.org/jira/browse/ARROW-17696
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
>Reporter: Antoine Pitrou
>Priority: Major
>
> It seems that {{arrow-compute-asof-join-node-test}} is designed such as each
> sub-test takes 2 seconds. The entire test file takes 120 seconds here.
> This is much too slow for a single test file and should drastically be
> reduced.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARROW-17696) [C++] arrow-compute-asof-join-node-test inordinately slow
[
https://issues.apache.org/jira/browse/ARROW-17696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603420#comment-17603420
]
Antoine Pitrou commented on ARROW-17696:
Test log here: https://gist.github.com/pitrou/bb973cd20df555a798b2709eb304da45
> [C++] arrow-compute-asof-join-node-test inordinately slow
> -
>
> Key: ARROW-17696
> URL: https://issues.apache.org/jira/browse/ARROW-17696
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
>Reporter: Antoine Pitrou
>Priority: Major
>
> It seems that {{arrow-compute-asof-join-node-test}} is designed such as each
> sub-test takes 2 seconds. The entire test file takes 120 seconds here.
> This is much too slow for a single test file and should drastically be
> reduced.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARROW-17696) [C++] arrow-compute-asof-join-node-test inordinately slow
[
https://issues.apache.org/jira/browse/ARROW-17696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603418#comment-17603418
]
Antoine Pitrou commented on ARROW-17696:
cc [~aucahuasi] [~westonpace]
> [C++] arrow-compute-asof-join-node-test inordinately slow
> -
>
> Key: ARROW-17696
> URL: https://issues.apache.org/jira/browse/ARROW-17696
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
>Reporter: Antoine Pitrou
>Priority: Major
>
> It seems that {{arrow-compute-asof-join-node-test}} is designed such as each
> sub-test takes 2 seconds. The entire test file takes 120 seconds here.
> This is much too slow for a single test file and should drastically be
> reduced.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
