[jira] [Commented] (ARROW-18371) [C++] Expose *FromJSON helpers
[
https://issues.apache.org/jira/browse/ARROW-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17647959#comment-17647959
]
Yaron Gvili commented on ARROW-18371:
-
The discussion went beyond the current subject of `*FromJSON` - let's update
the subject or split the discussion.
I agree that `MakeBasicBatches` is not needed. While I'm less sure about
whether `BatchesWithSchema` is indeed not needed, I'll take your opinion.
Regarding random data generation, I'd prioritize having the functions; the node
could come later. Regarding the assertion macros, they are specific to `gtest`
and I'm wondering whether we could make them flexible and less opinionated -
that would be a separate issue. Note that I have my own subset of these macros
specific to `Catch2`, so this flexibility can be obtained.
> [C++] Expose *FromJSON helpers
> --
>
> Key: ARROW-18371
> URL: https://issues.apache.org/jira/browse/ARROW-18371
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++
>Reporter: Rok Mihevc
>Assignee: Bryce Mecum
>Priority: Major
> Labels: testing
>
> {Array,{{Exec,Record}Batch}FromJSON helper functions would be useful when
> testing in projects that use Arrow. BatchesWithSchema and MakeBasicBatches
> could be considered as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARROW-18371) [C++] Expose *FromJSON helpers
[
https://issues.apache.org/jira/browse/ARROW-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641250#comment-17641250
]
Antoine Pitrou commented on ARROW-18371:
We would have to prefix those macros with {{ARROW_}}.
> [C++] Expose *FromJSON helpers
> --
>
> Key: ARROW-18371
> URL: https://issues.apache.org/jira/browse/ARROW-18371
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++
>Reporter: Rok Mihevc
>Priority: Major
> Labels: testing
>
> {Array,{{Exec,Record}Batch}FromJSON helper functions would be useful when
> testing in projects that use Arrow. BatchesWithSchema and MakeBasicBatches
> could be considered as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARROW-18371) [C++] Expose *FromJSON helpers
[
https://issues.apache.org/jira/browse/ARROW-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641241#comment-17641241
]
Rok Mihevc commented on ARROW-18371:
Random array generators would indeed be useful.
How about macros from gtest_util.h such as
[ASSERT_OK_AND_ASSIGN|https://github.com/apache/arrow/blob/df07b9160d7c8537d5d9f93cd6f25bdbef334ed6/cpp/src/arrow/testing/gtest_util.h#L119]?
These macros would potentially be useful when testing another library with
Arrow data.
> [C++] Expose *FromJSON helpers
> --
>
> Key: ARROW-18371
> URL: https://issues.apache.org/jira/browse/ARROW-18371
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++
>Reporter: Rok Mihevc
>Priority: Major
> Labels: testing
>
> {Array,{{Exec,Record}Batch}FromJSON helper functions would be useful when
> testing in projects that use Arrow. BatchesWithSchema and MakeBasicBatches
> could be considered as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARROW-18371) [C++] Expose *FromJSON helpers
[
https://issues.apache.org/jira/browse/ARROW-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636820#comment-17636820
]
Weston Pace commented on ARROW-18371:
-
{{MakeBasicBatches}} I agree is a definite no. The new source types being
added in ARROW-17610 should remove any real need for {{BatchesWithSchema}} so I
think that is a no too.
I agree the random data generation could be quite useful. I think it would
also be quite interesting to expose random data generation as an exec node but
probably shouldn't add more work :)
> [C++] Expose *FromJSON helpers
> --
>
> Key: ARROW-18371
> URL: https://issues.apache.org/jira/browse/ARROW-18371
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++
>Reporter: Rok Mihevc
>Priority: Major
> Labels: testing
>
> {Array,{{Exec,Record}Batch}FromJSON helper functions would be useful when
> testing in projects that use Arrow. BatchesWithSchema and MakeBasicBatches
> could be considered as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARROW-18371) [C++] Expose *FromJSON helpers
[
https://issues.apache.org/jira/browse/ARROW-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636794#comment-17636794
]
Antoine Pitrou commented on ARROW-18371:
> I assume the comment is regarding BatchesWithSchema and MakeBasicBatches.
Yes, this is what I meant. Sorry for the imprecision.
> [C++] Expose *FromJSON helpers
> --
>
> Key: ARROW-18371
> URL: https://issues.apache.org/jira/browse/ARROW-18371
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++
>Reporter: Rok Mihevc
>Priority: Major
> Labels: testing
>
> {Array,{{Exec,Record}Batch}FromJSON helper functions would be useful when
> testing in projects that use Arrow. BatchesWithSchema and MakeBasicBatches
> could be considered as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARROW-18371) [C++] Expose *FromJSON helpers
[
https://issues.apache.org/jira/browse/ARROW-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636755#comment-17636755
]
Rok Mihevc commented on ARROW-18371:
I assume the comment regarding BatchesWithSchema and MakeBasicBatches.
> [C++] Expose *FromJSON helpers
> --
>
> Key: ARROW-18371
> URL: https://issues.apache.org/jira/browse/ARROW-18371
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++
>Reporter: Rok Mihevc
>Priority: Major
> Labels: testing
>
> {Array,{{Exec,Record}Batch}FromJSON helper functions would be useful when
> testing in projects that use Arrow. BatchesWithSchema and MakeBasicBatches
> could be considered as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARROW-18371) [C++] Expose *FromJSON helpers
[
https://issues.apache.org/jira/browse/ARROW-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636754#comment-17636754
]
Li Jin commented on ARROW-18371:
> Definitely not. These are functions generating ad hoc data tailored for
> specific tests, with little consistency.
To clarify, do you know the \{Array,{{Exec,Record}Batch}FromJSON or
BatchesWithSchema/MakeBasicBatches
> [C++] Expose *FromJSON helpers
> --
>
> Key: ARROW-18371
> URL: https://issues.apache.org/jira/browse/ARROW-18371
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++
>Reporter: Rok Mihevc
>Priority: Major
> Labels: testing
>
> {Array,{{Exec,Record}Batch}FromJSON helper functions would be useful when
> testing in projects that use Arrow. BatchesWithSchema and MakeBasicBatches
> could be considered as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARROW-18371) [C++] Expose *FromJSON helpers
[
https://issues.apache.org/jira/browse/ARROW-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636747#comment-17636747
]
Antoine Pitrou commented on ARROW-18371:
Definitely not. These are functions generating ad hoc data tailored for
specific tests, with little consistency.
We could expose the Random generation class, though, possibly together with
some API cleanup.
> [C++] Expose *FromJSON helpers
> --
>
> Key: ARROW-18371
> URL: https://issues.apache.org/jira/browse/ARROW-18371
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++
>Reporter: Rok Mihevc
>Priority: Major
> Labels: testing
>
> {Array,{{Exec,Record}Batch}FromJSON helper functions would be useful when
> testing in projects that use Arrow. BatchesWithSchema and MakeBasicBatches
> could be considered as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARROW-18371) [C++] Expose *FromJSON helpers
[
https://issues.apache.org/jira/browse/ARROW-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636736#comment-17636736
]
Rok Mihevc commented on ARROW-18371:
*FromJSON functions seem clear cut. How about also adding BatchesWithSchema and
MakeBasicBatches. [~apitrou] [~westonpace]
> [C++] Expose *FromJSON helpers
> --
>
> Key: ARROW-18371
> URL: https://issues.apache.org/jira/browse/ARROW-18371
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++
>Reporter: Rok Mihevc
>Priority: Major
> Labels: testing
>
> {Array,{{Exec,Record}Batch}FromJSON helper functions would be useful when
> testing in projects that use Arrow. BatchesWithSchema and MakeBasicBatches
> could be considered as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
