[jira] [Resolved] (KAFKA-15077) FileTokenRetriever doesn't trim the token before returning it.
[
https://issues.apache.org/jira/browse/KAFKA-15077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar resolved KAFKA-15077.
---
Resolution: Fixed
> FileTokenRetriever doesn't trim the token before returning it.
> --
>
> Key: KAFKA-15077
> URL: https://issues.apache.org/jira/browse/KAFKA-15077
> Project: Kafka
> Issue Type: Bug
> Components: clients
>Reporter: Sushant Mahajan
>Assignee: Sushant Mahajan
>Priority: Minor
> Fix For: 3.6.0
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The {{FileTokenRetriever}} class is used to read the access_token from a file
> on the clients system and then the info is passed along with jaas config to
> the {{{}OAuthBearerSaslServer{}}}.
> The server uses the class {{OAuthBearerClientInitialResponse}} to validate
> the token format.
> In case the token was sent using {{FileTokenRetriever}} on the client side,
> some EOL character is getting appended to the token, causing authentication
> to fail with the message (in case to topic create):
> {{ERROR org.apache.kafka.common.errors.SaslAuthenticationException:
> Authentication failed during authentication due to invalid credentials with
> SASL mechanism OAUTHBEARER}}
>
> On the server side the following line
> [https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/OAuthBearerClientInitialResponse.java#L68]
> with throw an exception failing the request.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [kafka] omkreddy merged pull request #13835: KAFKA-15077: Added code to trim token in FileTokenRetriever, added test.
omkreddy merged PR #13835: URL: https://github.com/apache/kafka/pull/13835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] omkreddy commented on pull request #13835: KAFKA-15077: Added code to trim token in FileTokenRetriever, added test.
omkreddy commented on PR #13835: URL: https://github.com/apache/kafka/pull/13835#issuecomment-1586036037 Test failures are not related -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] wcarlson5 merged pull request #13830: KAFKA-14936: Change Time Ordered Buffer to not require Change<> 0/N
wcarlson5 merged PR #13830: URL: https://github.com/apache/kafka/pull/13830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] wcarlson5 commented on pull request #13830: KAFKA-14936: Change Time Ordered Buffer to not require Change<> 0/N
wcarlson5 commented on PR #13830: URL: https://github.com/apache/kafka/pull/13830#issuecomment-1585833983 https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-13830/2/tests Test failures unrelated. As it is a simple type changing PR I'm just going to merge it as is -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #13840: MINOR: Upgrade Scala for Java 20/21 support
ijuma commented on PR #13840: URL: https://github.com/apache/kafka/pull/13840#issuecomment-1585822711 JDK 8 and 17 builds passed, 11 is queued. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13084: KAFKA-14598: Fix flaky ConnectRestApiTest
github-actions[bot] commented on PR #13084: URL: https://github.com/apache/kafka/pull/13084#issuecomment-1585816432 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13090: KAFKA-14605 Change the log level to info when logIfAllowed is set, warn when logIfDenied is set.
github-actions[bot] commented on PR #13090: URL: https://github.com/apache/kafka/pull/13090#issuecomment-1585816423 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13096: MINOR: Multiple clean ups associated with scala collection
github-actions[bot] commented on PR #13096: URL: https://github.com/apache/kafka/pull/13096#issuecomment-1585816415 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13099: KAFKA-14604: avoid SASL session expiration time overflowed when calculation
github-actions[bot] commented on PR #13099: URL: https://github.com/apache/kafka/pull/13099#issuecomment-1585816407 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13111: KAFKA-14190: Update Zk TopicId from locally stored cache in controller
github-actions[bot] commented on PR #13111: URL: https://github.com/apache/kafka/pull/13111#issuecomment-1585816395 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13105: MINOR: fix typo in KafkaConsumer.java
github-actions[bot] commented on PR #13105: URL: https://github.com/apache/kafka/pull/13105#issuecomment-1585816401 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13113: KAFKA-5238: BrokerTopicMetrics can be recreated after topic is deleted
github-actions[bot] commented on PR #13113: URL: https://github.com/apache/kafka/pull/13113#issuecomment-1585816388 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13133: MINOR: Fix some typos in remote.metadata.storage
github-actions[bot] commented on PR #13133: URL: https://github.com/apache/kafka/pull/13133#issuecomment-1585816378 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13125: KAFKA-14626: Kafka Consumer Coordinator does not cleanup all metrics after shutdown
github-actions[bot] commented on PR #13125: URL: https://github.com/apache/kafka/pull/13125#issuecomment-1585816382 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13146: KIP-991 Add deletedConnector flag when stopping tasks
github-actions[bot] commented on PR #13146: URL: https://github.com/apache/kafka/pull/13146#issuecomment-1585816371 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13150: MINOR: Add new functions to client example Producer for sending messages to multiple topics, with key, and timestamp
github-actions[bot] commented on PR #13150: URL: https://github.com/apache/kafka/pull/13150#issuecomment-1585816364 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13155: [DO NOT MERGE] KAFKA-14533: re-enable the 'false' parameter of SmokeTestDriverIntegrationTest
github-actions[bot] commented on PR #13155: URL: https://github.com/apache/kafka/pull/13155#issuecomment-1585813288 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13157: KAFKA-14599 Enable javadoc for :connect:mirror module
github-actions[bot] commented on PR #13157: URL: https://github.com/apache/kafka/pull/13157#issuecomment-1585813283 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13162: fix: replace an inefficient loop in kafka internals
github-actions[bot] commented on PR #13162: URL: https://github.com/apache/kafka/pull/13162#issuecomment-1585813278 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13173: Demo of leaks file descriptors of deleted logs on KafkaEmbedded#stopAsync
github-actions[bot] commented on PR #13173: URL: https://github.com/apache/kafka/pull/13173#issuecomment-1585813266 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13177: [KAFKA-14441] Benchmark performance impact of metrics library
github-actions[bot] commented on PR #13177: URL: https://github.com/apache/kafka/pull/13177#issuecomment-1585813259 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13187: MINOR: Log lastCaughtUpTime on ISR shrinkage
github-actions[bot] commented on PR #13187: URL: https://github.com/apache/kafka/pull/13187#issuecomment-1585813244 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13180: MINOR: Add a summary of the metadata migration
github-actions[bot] commented on PR #13180: URL: https://github.com/apache/kafka/pull/13180#issuecomment-1585813252 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13201: KAFKA-14596: Move TopicCommand to tools
github-actions[bot] commented on PR #13201: URL: https://github.com/apache/kafka/pull/13201#issuecomment-1585813229 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13223: MINOR: fix some typo in SharedServer.scala/KafkaRaftServer.scala
github-actions[bot] commented on PR #13223: URL: https://github.com/apache/kafka/pull/13223#issuecomment-1585813215 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13197: Minor: Decode the envelope requests for the request log
github-actions[bot] commented on PR #13197: URL: https://github.com/apache/kafka/pull/13197#issuecomment-1585813236 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13217: Prototype take 2
github-actions[bot] commented on PR #13217: URL: https://github.com/apache/kafka/pull/13217#issuecomment-1585813223 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13220: Kafka 14253
github-actions[bot] commented on PR #13220: URL: https://github.com/apache/kafka/pull/13220#issuecomment-1585813219 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13204: KAFKA-14593: Move LeaderElectionCommand to tools
github-actions[bot] commented on PR #13204: URL: https://github.com/apache/kafka/pull/13204#issuecomment-1585813226 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13224: KAFKA-14700: Produce request interceptors
github-actions[bot] commented on PR #13224: URL: https://github.com/apache/kafka/pull/13224#issuecomment-1585813204 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13236: MINOR: Few cleanups to JaasContext/Utils classes for fix CVE-2023-25194
github-actions[bot] commented on PR #13236: URL: https://github.com/apache/kafka/pull/13236#issuecomment-1585813195 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13299: MINOR: Fix flaky testIdleConnection() test (cherry-pick from apache/kafka #11996)
github-actions[bot] commented on PR #13299: URL: https://github.com/apache/kafka/pull/13299#issuecomment-1585813152 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13247: KAFKA-14595 Move value objects of ReassignPartitionsCommand to java
github-actions[bot] commented on PR #13247: URL: https://github.com/apache/kafka/pull/13247#issuecomment-1585813185 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13285: KAFKA-13874 Avoid synchronization in SocketServer metrics
github-actions[bot] commented on PR #13285: URL: https://github.com/apache/kafka/pull/13285#issuecomment-1585813159 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13254: KAFKA-14719: Fix a return code during broker is bootstrapping
github-actions[bot] commented on PR #13254: URL: https://github.com/apache/kafka/pull/13254#issuecomment-1585813174 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13265: Prototype consumer stubs
github-actions[bot] commented on PR #13265: URL: https://github.com/apache/kafka/pull/13265#issuecomment-1585813172 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13278: KAFKA-14591 DeleteRecordsCommand moved to tools
github-actions[bot] commented on PR #13278: URL: https://github.com/apache/kafka/pull/13278#issuecomment-1585813165 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] mumrah merged pull request #13841: MINOR: Add the schedule, fix label, fix defaults
mumrah merged PR #13841: URL: https://github.com/apache/kafka/pull/13841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] jlprat commented on a diff in pull request #13841: MINOR: Add the schedule, fix label, fix defaults
jlprat commented on code in PR #13841:
URL: https://github.com/apache/kafka/pull/13841#discussion_r1225488034
##
.github/workflows/stale.yml:
##
@@ -40,13 +40,16 @@ jobs:
steps:
- uses: actions/stale@v8
with:
- debug-only: ${{ inputs.dryRun }}
- operations-per-run: ${{ inputs.operationsPerRun }}
+ debug-only: ${{ inputs.dryRun || false }}
+ operations-per-run: ${{ inputs.operationsPerRun || 30 }}
days-before-stale: 90
days-before-close: -1
- stale-issue-label: 'stale'
+ stale-pr-label: 'stale'
stale-pr-message: >
This PR is being marked as stale since it has not had any activity
in 90 days. If you
would like to keep this PR alive, please ask a committer for
review. If the PR has
merge conflicts, please update it with the latest from trunk (or
appropriate release branch)
+If this PR is no longer valid or desired, please feel free to
close it. If no activity
Review Comment:
Ah, good addition!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] ijuma commented on a diff in pull request #13582: MINOR: Fix lossy conversions flagged by Java 20
ijuma commented on code in PR #13582: URL: https://github.com/apache/kafka/pull/13582#discussion_r1225487332 ## clients/src/main/java/org/apache/kafka/common/record/CompressionType.java: ## @@ -128,11 +128,11 @@ public InputStream wrapForInput(ByteBuffer buffer, byte messageVersion, BufferSu } }; -public final int id; +public final byte id; Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] mumrah commented on pull request #13841: MINOR: Add the schedule, fix label, fix defaults
mumrah commented on PR #13841: URL: https://github.com/apache/kafka/pull/13841#issuecomment-1585748873 The dry-run worked fine, so I did a small run limited to 30 PRs: ``` Statistics: Processed PRs: 117 New stale PRs: 7 Added PRs labels: 7 Added PRs comments: 7 Fetched items: 200 Fetched items events: 7 Fetched items comments: 7 Operations performed: 30 ``` Here are the 7 PRs it found https://github.com/apache/kafka/pulls?q=is%3Aopen+is%3Apr+label%3AStale -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] mumrah commented on pull request #13841: MINOR: Add the schedule, fix label, fix defaults
mumrah commented on PR #13841: URL: https://github.com/apache/kafka/pull/13841#issuecomment-1585748371 attn @jlprat @dajac -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] mumrah opened a new pull request, #13841: MINOR: Add the schedule, fix label, fix defaults
mumrah opened a new pull request, #13841: URL: https://github.com/apache/kafka/pull/13841 Small follow-up to #13827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] hudeqi commented on pull request #13421: KAFKA-14824: ReplicaAlterLogDirsThread may cause serious disk growing in case of potential exception
hudeqi commented on PR #13421: URL: https://github.com/apache/kafka/pull/13421#issuecomment-1585730961 > So I have some context with the replica fetcher area (mostly by reading and debugging), I hope I can help. > > First, since the conversation is a bit long, let me summarize what I understand: > > * The problem is disk A reaches its capacity limits > * The solution is to move partition X-1 to disk B > * During the reassignment, log cleaning is disabled on X-1 (which can therefore fill disk A) > * The reassignment of X-1 fails, it is left failed there on B and X-1 on A keeps growing > Is this correct? > > If it is, we may need to separate the deletion and compaction cases. I think resuming deletion is safe, however resuming compaction might not be, since compaction alters the log. If an operator somehow resumes B and lets replication continue, then the history of X-1 in A and B might be different (I'm still working on a local test case that reproduces this). What do you think? Thank you for your review, @viktorsomogyi . Your summarize and understanding are very correct, I think carefully, for the distinction between compact and delete processing, I think it is very reasonable logically, for the case of turning on compact, regardless of whether delete is enabled or not, when B fails, we resume cleaning A, and when B resumes replicating, it is entirely possible inconsistent between A and B (I don't know if it has reproduced on your side). I thought for a moment, for compact, when we resume cleaning for A, is it OK to clean B completely(clear all segments of B directly and start over)? I don't know if there's a better way? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (KAFKA-15079) Offset expirations in topics with less event generation results in messages that take months to be delivered.
[ https://issues.apache.org/jira/browse/KAFKA-15079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-15079: --- Assignee: Ritika Muduganti > Offset expirations in topics with less event generation results in messages > that take months to be delivered. > - > > Key: KAFKA-15079 > URL: https://issues.apache.org/jira/browse/KAFKA-15079 > Project: Kafka > Issue Type: Bug > Components: group-coordinator >Reporter: Ritika Muduganti >Assignee: Ritika Muduganti >Priority: Major > > It was observed that messages were taking months to be delivered in certain > pipelines. The offsets had been reset and consumption restarted from messages > that were a couple months old. > On further investigation the team found that once the > offsets.retention.minutes (7 days) elapses and there's no subscribers to the > topic, the offsets are subject to immediate expiration. This can be a problem > when we close the current consumer and the retention period has already > passed due to the infrequent nature of offset commits. The offsets then > expire before a new consumer can come up and subscribe to the topic again. > Since only one consumer could be subscribed to the topic it will be removed > from the subscription list as soon as the consumer leaves. > Two things to keep in mind here are :- > # The consumer group has different consumers subscribed to different topics. > # Events aren't generated very frequently to these topics. > [https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala#LL766C1-L825C4] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [kafka] ijuma opened a new pull request, #13840: MINOR: Upgrade Scala for Java 20/21 support
ijuma opened a new pull request, #13840: URL: https://github.com/apache/kafka/pull/13840 Upgrade to Scala 2.13.11 and Scala 2.12.18. Scala 2.13 release notes: * https://github.com/scala/scala/releases/tag/v2.13.11 Scala 2.12 release notes: * https://github.com/scala/scala/releases/tag/v2.12.16 * https://github.com/scala/scala/releases/tag/v2.12.17 * https://github.com/scala/scala/releases/tag/v2.12.18 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] hudeqi commented on a diff in pull request #13421: KAFKA-14824: ReplicaAlterLogDirsThread may cause serious disk growing in case of potential exception
hudeqi commented on code in PR #13421:
URL: https://github.com/apache/kafka/pull/13421#discussion_r1225448529
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -447,11 +447,11 @@ class Partition(val topicPartition: TopicPartition,
private[cluster] def createLog(isNew: Boolean, isFutureReplica: Boolean,
offsetCheckpoints: OffsetCheckpoints, topicId: Option[Uuid]): UnifiedLog = {
def updateHighWatermark(log: UnifiedLog): Unit = {
val checkpointHighWatermark = offsetCheckpoints.fetch(log.parentDir,
topicPartition).getOrElse {
-info(s"No checkpointed highwatermark is found for partition
$topicPartition")
+info(s"No checkpointed highwatermark is found for ${if
(isFutureReplica) "Future partition" else "partition"} $topicPartition")
Review Comment:
nice catch! thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #13313: KAFKA-14760: Move ThroughputThrottler from tools to clients, remove tools dependency from connect-runtime
ijuma commented on PR #13313: URL: https://github.com/apache/kafka/pull/13313#issuecomment-1585713997 I started a system tests run for this branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] maniekes commented on pull request #13321: MINOR: added compatibility for MinGW
maniekes commented on PR #13321: URL: https://github.com/apache/kafka/pull/13321#issuecomment-1585694903 hi @divijvaidya @mimaison @ijuma this PR got marked as stale, what do you think about merging it or closing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KAFKA-14218) replace temp file handler with JUnit 5 Temporary Directory Support
[ https://issues.apache.org/jira/browse/KAFKA-14218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731215#comment-17731215 ] Starchenko Ilya commented on KAFKA-14218: - Hello. I noticed no progress on this issue, so I went ahead and took care of it myself. I've created a pull request: https://github.com/apache/kafka/pull/13836. Could you please review it when you get a chance? [~showuon] [~divijvaidya] > replace temp file handler with JUnit 5 Temporary Directory Support > -- > > Key: KAFKA-14218 > URL: https://issues.apache.org/jira/browse/KAFKA-14218 > Project: Kafka > Issue Type: Improvement > Components: unit tests >Reporter: Luke Chen >Assignee: Ganesh Sahu >Priority: Major > Labels: Newbie, newbie > > We created many temp files in tests, and sometimes we forgot to delete them > after usage. Instead of polluting @AfterEach for each test, we should > consider to use JUnit 5 TempDirectory Extension. > > REF: 1. [https://github.com/apache/kafka/pull/12591#issuecomment-1243001431] > 2. [https://www.baeldung.com/junit-5-temporary-directory] > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [kafka] github-actions[bot] commented on pull request #13310: KAFKA-14587: Move AclCommand to tools [WIP]
github-actions[bot] commented on PR #13310: URL: https://github.com/apache/kafka/pull/13310#issuecomment-1585687245 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13321: MINOR: added compatibility for MinGW
github-actions[bot] commented on PR #13321: URL: https://github.com/apache/kafka/pull/13321#issuecomment-1585687212 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13335: KAFKA-14768-KIP912: add new configure to reduce the max.block.ms safely
github-actions[bot] commented on PR #13335: URL: https://github.com/apache/kafka/pull/13335#issuecomment-1585687170 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13315: KAFKA-14767: Fix missing commitId build error after git gc
github-actions[bot] commented on PR #13315: URL: https://github.com/apache/kafka/pull/13315#issuecomment-1585687231 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13320: KAFKA-14768_KIP913: add new method to provide possibility for warming up first record's sending and reducing the max.block.ms saf
github-actions[bot] commented on PR #13320: URL: https://github.com/apache/kafka/pull/13320#issuecomment-1585687226 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13330: Prototyping Rebalance Protocol
github-actions[bot] commented on PR #13330: URL: https://github.com/apache/kafka/pull/13330#issuecomment-1585687205 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13333: MINOR: Cleanup TestPlugins and normalize TestPlugin enum
github-actions[bot] commented on PR #1: URL: https://github.com/apache/kafka/pull/1#issuecomment-1585687198 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] hudeqi opened a new pull request, #13839: MINOR:Fill missing parameter annotations for some LogCleaner methods
hudeqi opened a new pull request, #13839: URL: https://github.com/apache/kafka/pull/13839 When reading the LogCleaner-related code, it is found that some methods do not update and improve the parameter annotations in time, and it is hoped that added annotations will be helpful to read the relevant logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] mumrah merged pull request #13827: KAFKA-15073: Add a Github action to mark PRs as stale
mumrah merged PR #13827: URL: https://github.com/apache/kafka/pull/13827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] jlprat commented on a diff in pull request #13827: KAFKA-15073: Add a Github action to mark PRs as stale
jlprat commented on code in PR #13827:
URL: https://github.com/apache/kafka/pull/13827#discussion_r1225356594
##
.github/workflows/stale.yml:
##
@@ -0,0 +1,52 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: 'Close stale issues and PRs'
+on:
+ #schedule:
+ # - cron: '30 3 * * *'
+ workflow_dispatch:
+inputs:
+ dryRun:
+description: 'Dry Run'
+required: true
+default: true
+type: boolean
+ operationsPerRun:
+description: 'Max GitHub API operations'
+required: true
+default: 30
+type: number
+
+permissions:
+ issues: write
+ pull-requests: write
+
+jobs:
+ stale:
+runs-on: ubuntu-latest
+steps:
+ - uses: actions/stale@v8
+with:
+ debug-only: ${{ inputs.dryRun }}
+ operations-per-run: ${{ inputs.operationsPerRun }}
+ days-before-stale: 90
+ days-before-close: -1
+ stale-issue-label: 'stale'
+ stale-pr-message: >
+This PR is being marked as stale since it has not had any activity
in 90 days. If you
+would like to keep this PR alive, please update it with the latest
from trunk and ask
Review Comment:
There are plenty of PRs that are stale but no further action from the author
is needed. I would add a conditional in there.
"...please update it with the latest from trunk if there is a merge conflict
and ask..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] jlprat commented on a diff in pull request #13827: KAFKA-15073: Add a Github action to mark PRs as stale
jlprat commented on code in PR #13827:
URL: https://github.com/apache/kafka/pull/13827#discussion_r1225354535
##
.github/workflows/stale.yml:
##
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: 'Close stale issues and PRs'
+on:
+ #schedule:
+ # - cron: '30 3 * * *'
+ workflow_dispatch:
+inputs:
+ dryRun:
+description: 'Dry Run'
+required: true
+default: true
+type: boolean
+ operationsPerRun:
+description: 'Max GitHub API operations'
+required: true
+default: 30
+type: number
+
+permissions:
+ issues: write
+ pull-requests: write
+
+jobs:
+ stale:
+runs-on: ubuntu-latest
+steps:
+ - uses: actions/stale@v8
+with:
+ debug-only: ${{ inputs.dryRun }}
+ operations-per-run: ${{ inputs.operationsPerRun }}
+ days-before-stale: 90
+ days-before-close: -1
Review Comment:
I also think that having a dry run first and see that the right PRs would be
flagged is a good approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] mumrah commented on a diff in pull request #13827: KAFKA-15073: Add a Github action to mark PRs as stale
mumrah commented on code in PR #13827:
URL: https://github.com/apache/kafka/pull/13827#discussion_r1225352321
##
.github/workflows/stale.yml:
##
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: 'Close stale issues and PRs'
+on:
+ #schedule:
+ # - cron: '30 3 * * *'
+ workflow_dispatch:
+inputs:
+ dryRun:
+description: 'Dry Run'
+required: true
+default: true
+type: boolean
+ operationsPerRun:
+description: 'Max GitHub API operations'
+required: true
+default: 30
+type: number
+
+permissions:
+ issues: write
+ pull-requests: write
+
+jobs:
+ stale:
+runs-on: ubuntu-latest
+steps:
+ - uses: actions/stale@v8
+with:
+ debug-only: ${{ inputs.dryRun }}
+ operations-per-run: ${{ inputs.operationsPerRun }}
+ days-before-stale: 90
+ days-before-close: -1
Review Comment:
I'd like to in a future PR. Since we can't test the action until it's
committed, I wanted to hold off on doing anything "destructive" like closing a
bunch of PRs :)
After testing this manually with the dry-run option, I'll raise a PR to add
the schedule and close PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] mumrah commented on a diff in pull request #13827: KAFKA-15073: Add a Github action to mark PRs as stale
mumrah commented on code in PR #13827: URL: https://github.com/apache/kafka/pull/13827#discussion_r1225347286 ## .github/workflows/stale.yml: ## @@ -0,0 +1,48 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: 'Close stale issues and PRs' +on: + #schedule: Review Comment: We can't actually test the functionality of the action in a PR, so I was going to commit it without the automatic schedule so we could manually run it as a test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] yashmayya commented on a diff in pull request #13818: KAFKA-14784: Connect offset reset REST API
yashmayya commented on code in PR #13818:
URL: https://github.com/apache/kafka/pull/13818#discussion_r1224138055
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java:
##
@@ -1320,89 +1338,188 @@ void alterSinkConnectorOffsets(String connName,
Connector connector, Map> adminFutures = new ArrayList<>();
-
-Map offsetsToAlter =
parsedOffsets.entrySet()
-.stream()
-.filter(entry -> entry.getValue() != null)
-.collect(Collectors.toMap(Map.Entry::getKey, e ->
new OffsetAndMetadata(e.getValue(;
-
-if (!offsetsToAlter.isEmpty()) {
-log.debug("Committing the following consumer group
offsets using an admin client for sink connector {}: {}.",
-connName, offsetsToAlter);
-AlterConsumerGroupOffsetsOptions
alterConsumerGroupOffsetsOptions = new
AlterConsumerGroupOffsetsOptions().timeoutMs(
+Map offsetsToWrite;
+if (isReset) {
+offsetsToWrite = new HashMap<>();
+ListConsumerGroupOffsetsOptions
listConsumerGroupOffsetsOptions = new
ListConsumerGroupOffsetsOptions().timeoutMs(
(int)
ConnectResource.DEFAULT_REST_REQUEST_TIMEOUT_MS);
-AlterConsumerGroupOffsetsResult
alterConsumerGroupOffsetsResult = admin.alterConsumerGroupOffsets(groupId,
offsetsToAlter,
-alterConsumerGroupOffsetsOptions);
-
-
adminFutures.add(alterConsumerGroupOffsetsResult.all());
+try {
+admin.listConsumerGroupOffsets(groupId,
listConsumerGroupOffsetsOptions)
+.partitionsToOffsetAndMetadata()
+
.get(ConnectResource.DEFAULT_REST_REQUEST_TIMEOUT_MS, TimeUnit.MILLISECONDS)
+.forEach((topicPartition,
offsetAndMetadata) -> offsetsToWrite.put(topicPartition, null));
+
+log.debug("Found the following topic partitions
(to reset offsets) for sink connector {} and consumer group ID {}: {}",
+connName, groupId,
offsetsToWrite.keySet());
+} catch (Exception e) {
+Utils.closeQuietly(admin, "Offset reset admin for
sink connector " + connName);
+log.error("Failed to list offsets prior to
resetting sink connector offsets", e);
+cb.onCompletion(new ConnectException("Failed to
list offsets prior to resetting sink connector offsets", e), null);
+return;
+}
+} else {
+offsetsToWrite =
SinkUtils.parseSinkConnectorOffsets(offsets);
}
-Set partitionsToReset =
parsedOffsets.entrySet()
-.stream()
-.filter(entry -> entry.getValue() == null)
-.map(Map.Entry::getKey)
-.collect(Collectors.toSet());
-
-if (!partitionsToReset.isEmpty()) {
-log.debug("Deleting the consumer group offsets for the
following topic partitions using an admin client for sink connector {}: {}.",
-connName, partitionsToReset);
-DeleteConsumerGroupOffsetsOptions
deleteConsumerGroupOffsetsOptions = new
DeleteConsumerGroupOffsetsOptions().timeoutMs(
-(int)
ConnectResource.DEFAULT_REST_REQUEST_TIMEOUT_MS);
-DeleteConsumerGroupOffsetsResult
deleteConsumerGroupOffsetsResult = admin.deleteConsumerGroupOffsets(groupId,
partitionsToReset,
-deleteConsumerGroupOffsetsOptions);
+boolean alterOffsetsResult;
+try {
+alterOffsetsResult = ((SinkConnector)
connector).alterOffsets(connectorConfig, offsetsToWrite);
+} catch (UnsupportedOperationException e) {
+throw new ConnectException("Failed to modify offsets
for connector " + connName + " because it doesn't support external " +
+"modification of offsets", e);
+}
-
adminFutures.add(deleteConsumerGroupOffsetsResult.all());
+// This should only occur for an offset reset request when:
+// 1. There was a prior attempt to reset offsets
+// OR
+// 2. No offsets have been committed yet
+if (offsetsToWrite.isEmpty()) {
Review Comment:
I've made this change but it also bro
[GitHub] [kafka] dajac commented on pull request #13814: KAFKA-15057: Use new interface from zstd-jni
dajac commented on PR #13814: URL: https://github.com/apache/kafka/pull/13814#issuecomment-1585569363 @divijvaidya Nice one! Out of curiosity, have you tried to run kafka-producer-perf-test.sh before/after the patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KAFKA-15050) Prompts in the quickstarts
[
https://issues.apache.org/jira/browse/KAFKA-15050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731175#comment-17731175
]
Tom Bentley commented on KAFKA-15050:
-
Sure, go for it!
> Prompts in the quickstarts
> --
>
> Key: KAFKA-15050
> URL: https://issues.apache.org/jira/browse/KAFKA-15050
> Project: Kafka
> Issue Type: Improvement
> Components: documentation
>Reporter: Tom Bentley
>Priority: Trivial
> Labels: newbie
>
> In the quickstarts [Steps
> 1-5|https://kafka.apache.org/documentation/#quickstart] use {{$}} to indicate
> the command prompt. When we start to use Kafka Connect in [Step
> 6|https://kafka.apache.org/documentation/#quickstart_kafkaconnect] we switch
> to {{{}>{}}}. The [Kafka Streams
> quickstart|https://kafka.apache.org/documentation/streams/quickstart] also
> uses {{{}>{}}}. I don't think there's a reason for this, but if there is one
> (root vs user account?) it should be explained.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
