Re: [PR] Update subscriptions at the end. [kafka]

2024-02-08 Thread via GitHub


michaldo commented on PR #14720:
URL: https://github.com/apache/kafka/pull/14720#issuecomment-1933580667

   please review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MINOR: remove un used code [kafka]

2024-02-08 Thread via GitHub


mimaison merged PR #15301:
URL: https://github.com/apache/kafka/pull/15301


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (KAFKA-16236) Interactive Query v2 does not support Global KTables

2024-02-08 Thread Jira


[ 
https://issues.apache.org/jira/browse/KAFKA-16236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815567#comment-17815567
 ] 

Christian Zügner commented on KAFKA-16236:
--

The question came up during my communitcation in the mailing list:

[https://lists.apache.org/thread/lwqnt2tpwptrmyfs36v5wor5h2mtsc3w]

 

> Interactive Query v2 does not support Global KTables
> 
>
> Key: KAFKA-16236
> URL: https://issues.apache.org/jira/browse/KAFKA-16236
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Christian Zügner
>Priority: Major
>
> Query Global KTable using IQ v2 API is currently not supported:
> java.lang.IllegalArgumentException: Cannot get result for failed query. 
> Failure is UNKNOWN_QUERY_TYPE: Global stores do not yet support the 
> KafkaStreams#query API. Use KafkaStreams#store instead.
> I would kindly as ask if this feature could be implemented for GlobalKTable 
> as well?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (KAFKA-16236) Interactive Query v2 does not support Global KTables

2024-02-08 Thread Jira
Christian Zügner created KAFKA-16236:


 Summary: Interactive Query v2 does not support Global KTables
 Key: KAFKA-16236
 URL: https://issues.apache.org/jira/browse/KAFKA-16236
 Project: Kafka
  Issue Type: Improvement
Reporter: Christian Zügner


Query Global KTable using IQ v2 API is currently not supported:

java.lang.IllegalArgumentException: Cannot get result for failed query. Failure 
is UNKNOWN_QUERY_TYPE: Global stores do not yet support the KafkaStreams#query 
API. Use KafkaStreams#store instead.

I would kindly as ask if this feature could be implemented for GlobalKTable as 
well?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] KAFKA-15670: add "inter.broker.listener.name" config in KRaft controller config [kafka]

2024-02-08 Thread via GitHub


showuon commented on code in PR #14631:
URL: https://github.com/apache/kafka/pull/14631#discussion_r1482554789


##
docs/ops.html:
##
@@ -3898,6 +3904,12 @@ Migrating brokers to KRaft
 # Remove ZooKeeper client configuration
 # zookeeper.connect=localhost:2181
 
+# Remove the inter broker listener in brokers to allow KRaft controller send 
RPCs to brokers
+# inter.broker.listener.name=PLAINTEXT
+
+# Maps listener names to security protocols. Please add the inter broker 
listener protocol mapping
+# listener.security.protocol.map=PLAINTEXT:PLAINTEXT,CONTROLLER:PLAINTEXT
+

Review Comment:
   Had another look, I think I was wrong. This section is to remove the configs 
in the broker side, but what we want to add is in the KRaft controller config. 
Removed this change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KAFKA-15670: add "inter.broker.listener.name" config in KRaft controller config [kafka]

2024-02-08 Thread via GitHub


showuon commented on code in PR #14631:
URL: https://github.com/apache/kafka/pull/14631#discussion_r1482553721


##
docs/ops.html:
##
@@ -3819,6 +3819,12 @@ Provisioning the KRaft controller quorum
 # ZooKeeper client configuration
 zookeeper.connect=localhost:2181
 
+# The inter broker listener in brokers to allow KRaft controller send RPCs to 
brokers
+inter.broker.listener.name=PLAINTEXT
+
+# Maps listener names to security protocols. Please add the inter broker 
listener protocol mapping

Review Comment:
   I'm fine we don't add this and let users to add it if necessary, because the 
error log should be clear when broker start up if there's any wrong/missing 
config.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



<    1   2