Re: [PR] KAFKA-15894: Fix KafkaApis.updateRecordConversionStats to ensure MessageConversionsTimeMs and TemporaryMemoryBytes are recorded correctly [kafka]

2024-02-24 Thread via GitHub


github-actions[bot] commented on PR #14841:
URL: https://github.com/apache/kafka/pull/14841#issuecomment-1962800822

   This PR is being marked as stale since it has not had any activity in 90 
days. If you would like to keep this PR alive, please ask a committer for 
review. If the PR has  merge conflicts, please update it with the latest from 
trunk (or appropriate release branch)  If this PR is no longer valid or 
desired, please feel free to close it. If no activity occurs in the next 30 
days, it will be automatically closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KAFKA-15878: KIP-768 - Extend support for opaque (i.e. non-JWT) tokens in SASL/OAUTHBEARER [kafka]

2024-02-24 Thread via GitHub


omkreddy commented on PR #14818:
URL: https://github.com/apache/kafka/pull/14818#issuecomment-1962462708

   @jcme Thanks for the PR. Can you rebase the PR to latest trunk?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KAFKA-16265: KIP-994 (Part 1) Minor Enhancements to ListTransactionsRequest [kafka]

2024-02-24 Thread via GitHub


jolshan merged PR #15384:
URL: https://github.com/apache/kafka/pull/15384


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (KAFKA-15729) KRaft support in GetOffsetShellTest

2024-02-24 Thread Owen C.H. Leung (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-15729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820337#comment-17820337
 ] 

Owen C.H. Leung commented on KAFKA-15729:
-

I tried to work on this issue by extending this test to KRaft. However, I got 
the following exception when executing locally (FYI ZK mode works just fine): 

 
{code:java}
org.apache.kafka.common.KafkaException: Failed to create new KafkaAdminClient
at 
org.apache.kafka.clients.admin.KafkaAdminClient.createInternal(KafkaAdminClient.java:542)
at 
org.apache.kafka.clients.admin.KafkaAdminClient.createInternal(KafkaAdminClient.java:493)
at org.apache.kafka.clients.admin.Admin.create(Admin.java:137)

Caused by: org.apache.kafka.common.config.ConfigException: You must set either 
bootstrap.servers or bootstrap.controllers
at 
org.apache.kafka.clients.admin.internals.AdminBootstrapAddresses.fromConfig(AdminBootstrapAddresses.java:62){code}
>From the stdout, I can see that `bootstrap.servers` is an empty list: 

 
{code:java}
[2024-02-24 20:33:37,572] INFO AdminClientConfig values: 
auto.include.jmx.reporter = true
bootstrap.controllers = []
bootstrap.servers = [] {code}
Shouldn't the address of bootstrap server be sent over by controller 
automatically even in Kraft mode ?

> KRaft support in GetOffsetShellTest
> ---
>
> Key: KAFKA-15729
> URL: https://issues.apache.org/jira/browse/KAFKA-15729
> Project: Kafka
>  Issue Type: Task
>  Components: core
>Reporter: Sameer Tejani
>Priority: Minor
>  Labels: kraft, kraft-test, newbie
>
> The following tests in GetOffsetShellTest in 
> tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java need to be 
> updated to support KRaft
> 62 : def testNoFilterOptions(): Unit = {
> 68 : def testInternalExcluded(): Unit = {
> 74 : def testTopicNameArg(): Unit = {
> 82 : def testTopicPatternArg(): Unit = {
> 88 : def testPartitionsArg(): Unit = {
> 94 : def testTopicPatternArgWithPartitionsArg(): Unit = {
> 100 : def testTopicPartitionsArg(): Unit = {
> 116 : def testGetLatestOffsets(time: String): Unit = {
> 131 : def testGetEarliestOffsets(time: String): Unit = {
> 146 : def testGetOffsetsByMaxTimestamp(time: String): Unit = {
> 155 : def testGetOffsetsByTimestamp(): Unit = {
> 170 : def testNoOffsetIfTimestampGreaterThanLatestRecord(): Unit = {
> 177 : def testTopicPartitionsArgWithInternalExcluded(): Unit = {
> 192 : def testTopicPartitionsArgWithInternalIncluded(): Unit = {
> 198 : def testTopicPartitionsNotFoundForNonExistentTopic(): Unit = {
> 203 : def testTopicPartitionsNotFoundForExcludedInternalTopic(): Unit = {
> 208 : def testTopicPartitionsNotFoundForNonMatchingTopicPartitionPattern(): 
> Unit = {
> 213 : def testTopicPartitionsFlagWithTopicFlagCauseExit(): Unit = {
> 218 : def testTopicPartitionsFlagWithPartitionsFlagCauseExit(): Unit = {
> Scanned 279 lines. Found 0 KRaft tests out of 19 tests



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] KAFKA-16066: Upgrade apacheds to 2.0.0.AM27 With apache kerby [kafka]

2024-02-24 Thread via GitHub


highluck commented on PR #15277:
URL: https://github.com/apache/kafka/pull/15277#issuecomment-1962326771

   @mimaison 
   Please review this too :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KAFKA-15716: KRaft support in EpochDrivenReplicationProtocolAcceptanceTest [kafka]

2024-02-24 Thread via GitHub


highluck commented on PR #15295:
URL: https://github.com/apache/kafka/pull/15295#issuecomment-1962326652

   @mimaison @pasharik 
   thanks for review!
   I edited it :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org