[jira] [Assigned] (KAFKA-14254) Format timestamps in assignor logs as dates instead of integers
[ https://issues.apache.org/jira/browse/KAFKA-14254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashmeet Lamba reassigned KAFKA-14254: - Assignee: Ashmeet Lamba > Format timestamps in assignor logs as dates instead of integers > --- > > Key: KAFKA-14254 > URL: https://issues.apache.org/jira/browse/KAFKA-14254 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: John Roesler >Assignee: Ashmeet Lamba >Priority: Minor > Labels: newbie, newbie++ > > This is a follow-on task from [https://github.com/apache/kafka/pull/12582] > There is another log line that prints the same timestamp: "Triggering the > followup rebalance scheduled for ...", which should also be printed as a > date/time in the same manner as PR 12582. > We should also search the codebase a little to see if we're printing > timestamps in other log lines that would be better off as date/times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (KAFKA-14405) Log a warning when users attempt to set a config controlled by Streams
[ https://issues.apache.org/jira/browse/KAFKA-14405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashmeet Lamba reassigned KAFKA-14405: - Assignee: Ashmeet Lamba > Log a warning when users attempt to set a config controlled by Streams > -- > > Key: KAFKA-14405 > URL: https://issues.apache.org/jira/browse/KAFKA-14405 > Project: Kafka > Issue Type: Bug > Components: streams >Reporter: A. Sophie Blee-Goldman >Assignee: Ashmeet Lamba >Priority: Major > Labels: newbie > > Related to https://issues.apache.org/jira/browse/KAFKA-14404 > It's too easy for users to try overriding one of the client configs that > Streams hardcodes, and since we just silently ignore it there's no good way > for them to tell their config is not being used. Sometimes this may be > harmless but in cases like the Producer's partitioner, there could be > important application logic that's never being invoked. > When processing user configs in StreamsConfig, we should check for all these > configs and log a warning when any of them have been set -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-14073) Logging the reason for creating a snapshot
[ https://issues.apache.org/jira/browse/KAFKA-14073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567156#comment-17567156 ] Ashmeet Lamba commented on KAFKA-14073: --- Hi, I am new Kafka and notice that this issue is marked as newbie. I was looking to learn Scala and wanted to give this issue a try. I have gone through the PR link attached and read the KRaft README.md to understand what it's purpose is. Reading through the code base I believe changes required would be in this file - [BrokerMetadataListener|https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala], specifically in the lines - [BrokerMetadataListener(L142-L148)|https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala#L142-L148]. Along with the changes to log the reason in [BrokerMetadataSnapshotter|https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/metadata/BrokerMetadataSnapshotter.scala] Can I pick this issue? > Logging the reason for creating a snapshot > -- > > Key: KAFKA-14073 > URL: https://issues.apache.org/jira/browse/KAFKA-14073 > Project: Kafka > Issue Type: Improvement >Reporter: dengziming >Priority: Minor > Labels: kraft, newbie > > So far we have two reasons for creating a snapshot. 1. X bytes were applied. > 2. the metadata version changed. we should log the reason when creating > snapshot both in the broker side and controller side. see > https://github.com/apache/kafka/pull/12265#discussion_r915972383 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (KAFKA-14073) Logging the reason for creating a snapshot
[ https://issues.apache.org/jira/browse/KAFKA-14073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567156#comment-17567156 ] Ashmeet Lamba edited comment on KAFKA-14073 at 7/15/22 4:13 PM: Hi, I am new to Kafka and noticed that this issue is tagged as newbie. I would like to pick this issue up. I have gone through the PR attached. I also did go through the KRaft's README. Reading through the code base I believe the changes required would be in this file - [BrokerMetadataListener|https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala], specifically in the lines - [BrokerMetadataListener(L142-L148)|https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala#L142-L148]. Along with the changes required to log the reason of snapshot in - [BrokerMetadataSnapshotter|https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/metadata/BrokerMetadataSnapshotter.scala] If I have understood the issue accurately - can I pick this issue? was (Author: ashmeetlamba): Hi, I am new Kafka and notice that this issue is marked as newbie. I was looking to learn Scala and wanted to give this issue a try. I have gone through the PR link attached and read the KRaft README.md to understand what it's purpose is. Reading through the code base I believe changes required would be in this file - [BrokerMetadataListener|https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala], specifically in the lines - [BrokerMetadataListener(L142-L148)|https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala#L142-L148]. Along with the changes to log the reason in [BrokerMetadataSnapshotter|https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/metadata/BrokerMetadataSnapshotter.scala] Can I pick this issue? > Logging the reason for creating a snapshot > -- > > Key: KAFKA-14073 > URL: https://issues.apache.org/jira/browse/KAFKA-14073 > Project: Kafka > Issue Type: Improvement >Reporter: dengziming >Priority: Minor > Labels: kraft, newbie > > So far we have two reasons for creating a snapshot. 1. X bytes were applied. > 2. the metadata version changed. we should log the reason when creating > snapshot both in the broker side and controller side. see > https://github.com/apache/kafka/pull/12265#discussion_r915972383 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-14218) replace temp file handler with JUnit 5 Temporary Directory Support
[ https://issues.apache.org/jira/browse/KAFKA-14218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605717#comment-17605717 ] Ashmeet Lamba commented on KAFKA-14218: --- Hi [~showuon] ,[~divijvaidya], I see that this issue is tagged as `newbie`. I was trying to scope out the task and require help with it. Going through https://issues.apache.org/jira/browse/KAFKA-7339 I see that there are a lot of modules that have been ported to JUnit5 and there might be more that haven't been listed in the mentioned ticket. Would this task of upgrading the test cases be broken down into sub-tasks for ease? Since I am new to the code base I would like to pick up a smaller piece. Would you think this is possible? Thanks! > replace temp file handler with JUnit 5 Temporary Directory Support > -- > > Key: KAFKA-14218 > URL: https://issues.apache.org/jira/browse/KAFKA-14218 > Project: Kafka > Issue Type: Improvement > Components: unit tests >Reporter: Luke Chen >Priority: Major > Labels: Newbie, newbie > > We created many temp files in tests, and sometimes we forgot to delete them > after usage. Instead of polluting @AfterEach for each test, we should > consider to use JUnit 5 TempDirectory Extension. > > REF: 1. [https://github.com/apache/kafka/pull/12591#issuecomment-1243001431] > 2. [https://www.baeldung.com/junit-5-temporary-directory] > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-14254) Format timestamps in assignor logs as dates instead of integers
[ https://issues.apache.org/jira/browse/KAFKA-14254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608979#comment-17608979 ] Ashmeet Lamba commented on KAFKA-14254: --- Hi [~vvcephei], can I pick this up? I see that this is the log ([StreamsPartitionAssignor.java#L960-L961|https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java#L960-L961]) that still prints the timestamp. Also will be going through the codebase to find if there are any other instances where timestamps are being printed. > Format timestamps in assignor logs as dates instead of integers > --- > > Key: KAFKA-14254 > URL: https://issues.apache.org/jira/browse/KAFKA-14254 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: John Roesler >Priority: Minor > Labels: newbie, newbie++ > > This is a follow-on task from [https://github.com/apache/kafka/pull/12582] > There is another log line that prints the same timestamp: "Triggering the > followup rebalance scheduled for ...", which should also be printed as a > date/time in the same manner as PR 12582. > We should also search the codebase a little to see if we're printing > timestamps in other log lines that would be better off as date/times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
