[jira] [Assigned] (KAFKA-6253) Improve sink connector topic regex validation
[ https://issues.apache.org/jira/browse/KAFKA-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Klukas reassigned KAFKA-6253: -- Assignee: Jeff Klukas (was: Randall Hauch) > Improve sink connector topic regex validation > - > > Key: KAFKA-6253 > URL: https://issues.apache.org/jira/browse/KAFKA-6253 > Project: Kafka > Issue Type: Bug > Components: KafkaConnect >Reporter: Ewen Cheslack-Postava >Assignee: Jeff Klukas > Fix For: 1.1.0 > > > KAFKA-3073 adds topic regex support for sink connectors. The addition > requires that you only specify one of topics or topics.regex settings. This > is being validated in one place, but not during submission of connectors. We > should improve this since this means it's possible to get a bad connector > config into the config topic. > For more detailed discussion, see > https://github.com/apache/kafka/pull/4151#pullrequestreview-77300221 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KAFKA-3073) KafkaConnect should support regular expression for topics
[ https://issues.apache.org/jira/browse/KAFKA-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Klukas updated KAFKA-3073: --- Fix Version/s: (was: 1.0.1) 1.1.0 > KafkaConnect should support regular expression for topics > - > > Key: KAFKA-3073 > URL: https://issues.apache.org/jira/browse/KAFKA-3073 > Project: Kafka > Issue Type: Improvement > Components: KafkaConnect >Reporter: Gwen Shapira >Assignee: Jeff Klukas > Fix For: 1.1.0 > > > KafkaConsumer supports both a list of topics or a pattern when subscribing. > KafkaConnect only supports a list of topics, which is not just more of a > hassle to configure - it also requires more maintenance. > I suggest adding topics.pattern as a new configuration and letting users > choose between 'topics' or 'topics.pattern'. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KAFKA-3073) KafkaConnect should support regular expression for topics
[ https://issues.apache.org/jira/browse/KAFKA-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Klukas updated KAFKA-3073: --- Fix Version/s: 1.0.1 > KafkaConnect should support regular expression for topics > - > > Key: KAFKA-3073 > URL: https://issues.apache.org/jira/browse/KAFKA-3073 > Project: Kafka > Issue Type: Improvement > Components: KafkaConnect >Reporter: Gwen Shapira >Assignee: Jeff Klukas > Fix For: 1.0.1 > > > KafkaConsumer supports both a list of topics or a pattern when subscribing. > KafkaConnect only supports a list of topics, which is not just more of a > hassle to configure - it also requires more maintenance. > I suggest adding topics.pattern as a new configuration and letting users > choose between 'topics' or 'topics.pattern'. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KAFKA-3073) KafkaConnect should support regular expression for topics
[ https://issues.apache.org/jira/browse/KAFKA-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Klukas updated KAFKA-3073: --- Labels: (was: needs-kip) > KafkaConnect should support regular expression for topics > - > > Key: KAFKA-3073 > URL: https://issues.apache.org/jira/browse/KAFKA-3073 > Project: Kafka > Issue Type: Improvement > Components: KafkaConnect >Reporter: Gwen Shapira >Assignee: Jeff Klukas > > KafkaConsumer supports both a list of topics or a pattern when subscribing. > KafkaConnect only supports a list of topics, which is not just more of a > hassle to configure - it also requires more maintenance. > I suggest adding topics.pattern as a new configuration and letting users > choose between 'topics' or 'topics.pattern'. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KAFKA-3073) KafkaConnect should support regular expression for topics
[ https://issues.apache.org/jira/browse/KAFKA-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221559#comment-16221559 ] Jeff Klukas commented on KAFKA-3073: Created a KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-215%3A+Add+topic+regex+support+for+Connect+sinks > KafkaConnect should support regular expression for topics > - > > Key: KAFKA-3073 > URL: https://issues.apache.org/jira/browse/KAFKA-3073 > Project: Kafka > Issue Type: Improvement > Components: KafkaConnect >Reporter: Gwen Shapira >Assignee: Liquan Pei > Labels: needs-kip > > KafkaConsumer supports both a list of topics or a pattern when subscribing. > KafkaConnect only supports a list of topics, which is not just more of a > hassle to configure - it also requires more maintenance. > I suggest adding topics.pattern as a new configuration and letting users > choose between 'topics' or 'topics.pattern'. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KAFKA-3073) KafkaConnect should support regular expression for topics
[ https://issues.apache.org/jira/browse/KAFKA-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221506#comment-16221506 ] Jeff Klukas commented on KAFKA-3073: Since a significant segment of the Kafka user community come from a Java background, I would expect many users would be most comfortable with Java's regex library over PCREs. It seems reasonable to me to start there (since the Java consumer already includes a subscribe() variant that takes a Java regex Pattern) and leave it to a separate effort to find a suitable PCRE library and add a new subscribe() variant. If we add PCRE support in the future, we could control which type of regex is used via an additional 'topics.pattern.type' configuration option. > KafkaConnect should support regular expression for topics > - > > Key: KAFKA-3073 > URL: https://issues.apache.org/jira/browse/KAFKA-3073 > Project: Kafka > Issue Type: Improvement > Components: KafkaConnect >Reporter: Gwen Shapira >Assignee: Liquan Pei > Labels: needs-kip > > KafkaConsumer supports both a list of topics or a pattern when subscribing. > KafkaConnect only supports a list of topics, which is not just more of a > hassle to configure - it also requires more maintenance. > I suggest adding topics.pattern as a new configuration and letting users > choose between 'topics' or 'topics.pattern'. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
