[jira] [Updated] (KAFKA-8721) Metrics library upgrade
[ https://issues.apache.org/jira/browse/KAFKA-8721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mario Molina updated KAFKA-8721: Affects Version/s: (was: 2.3.0) 2.4.0 > Metrics library upgrade > --- > > Key: KAFKA-8721 > URL: https://issues.apache.org/jira/browse/KAFKA-8721 > Project: Kafka > Issue Type: Improvement > Components: metrics >Affects Versions: 2.4.0 >Reporter: Mario Molina >Assignee: Mario Molina >Priority: Major > > The current metrics library which Kafka is using is pretty old (version 2.2.0 > from Yammer and now we have 4.1.0 from Dropwizard). > In the latest versions of the Dropwizard library (which comes from Yammer and > this is deprecated), there are a lot of bugfixes and new features included > which could be interesting for the metrics (ie: Reservoris, support JDK9, > etc). > This patch includes the upgrade to this new version of the library so that we > could add new features in Kafka metrics. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (KAFKA-8721) Metrics library upgrade
[ https://issues.apache.org/jira/browse/KAFKA-8721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mario Molina updated KAFKA-8721: Affects Version/s: 2.5.0 > Metrics library upgrade > --- > > Key: KAFKA-8721 > URL: https://issues.apache.org/jira/browse/KAFKA-8721 > Project: Kafka > Issue Type: Improvement > Components: metrics >Affects Versions: 2.4.0, 2.5.0 >Reporter: Mario Molina >Assignee: Mario Molina >Priority: Major > > The current metrics library which Kafka is using is pretty old (version 2.2.0 > from Yammer and now we have 4.1.0 from Dropwizard). > In the latest versions of the Dropwizard library (which comes from Yammer and > this is deprecated), there are a lot of bugfixes and new features included > which could be interesting for the metrics (ie: Reservoris, support JDK9, > etc). > This patch includes the upgrade to this new version of the library so that we > could add new features in Kafka metrics. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (KAFKA-9780) Deprecate commit records without record metadata
Mario Molina created KAFKA-9780:
---
Summary: Deprecate commit records without record metadata
Key: KAFKA-9780
URL: https://issues.apache.org/jira/browse/KAFKA-9780
Project: Kafka
Issue Type: Improvement
Components: KafkaConnect
Affects Versions: 2.4.1
Reporter: Mario Molina
Assignee: Mario Molina
Fix For: 2.5.0, 2.6.0
Since KIP-382 (MirrorMaker 2.0) a new method {{commitRecord}} was included in
{{SourceTask}} class to be called by the worker adding a new parameter with the
record metadata. The old {{commitRecord}} method is called and from the new one
and it's preserved just for backwards compatibility.
The idea is to deprecate this method so that we could remove it in a future
release.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KAFKA-9780) Deprecate commit records without record metadata
[
https://issues.apache.org/jira/browse/KAFKA-9780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070159#comment-17070159
]
Mario Molina commented on KAFKA-9780:
-
Pull request:
[https://github.com/apache/kafka/pull/8379]
> Deprecate commit records without record metadata
>
>
> Key: KAFKA-9780
> URL: https://issues.apache.org/jira/browse/KAFKA-9780
> Project: Kafka
> Issue Type: Improvement
> Components: KafkaConnect
>Affects Versions: 2.4.1
>Reporter: Mario Molina
>Assignee: Mario Molina
>Priority: Minor
> Fix For: 2.5.0, 2.6.0
>
>
> Since KIP-382 (MirrorMaker 2.0) a new method {{commitRecord}} was included in
> {{SourceTask}} class to be called by the worker adding a new parameter with
> the record metadata. The old {{commitRecord}} method is called and from the
> new one and it's preserved just for backwards compatibility.
> The idea is to deprecate this method so that we could remove it in a future
> release.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (KAFKA-9780) Deprecate commit records without record metadata
[
https://issues.apache.org/jira/browse/KAFKA-9780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mario Molina updated KAFKA-9780:
Labels: (was: needs-kip)
> Deprecate commit records without record metadata
>
>
> Key: KAFKA-9780
> URL: https://issues.apache.org/jira/browse/KAFKA-9780
> Project: Kafka
> Issue Type: Improvement
> Components: KafkaConnect
>Affects Versions: 2.4.1
>Reporter: Mario Molina
>Assignee: Mario Molina
>Priority: Minor
>
> Since KIP-382 (MirrorMaker 2.0) a new method {{commitRecord}} was included in
> {{SourceTask}} class to be called by the worker adding a new parameter with
> the record metadata. The old {{commitRecord}} method is called and from the
> new one and it's preserved just for backwards compatibility.
> The idea is to deprecate this method so that we could remove it in a future
> release.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KAFKA-9780) Deprecate commit records without record metadata
[
https://issues.apache.org/jira/browse/KAFKA-9780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073283#comment-17073283
]
Mario Molina commented on KAFKA-9780:
-
Thanks for your comments [~rhauch].
I've create the KIP-586.
> Deprecate commit records without record metadata
>
>
> Key: KAFKA-9780
> URL: https://issues.apache.org/jira/browse/KAFKA-9780
> Project: Kafka
> Issue Type: Improvement
> Components: KafkaConnect
>Affects Versions: 2.4.1
>Reporter: Mario Molina
>Assignee: Mario Molina
>Priority: Minor
> Labels: needs-kip
>
> Since KIP-382 (MirrorMaker 2.0) a new method {{commitRecord}} was included in
> {{SourceTask}} class to be called by the worker adding a new parameter with
> the record metadata. The old {{commitRecord}} method is called and from the
> new one and it's preserved just for backwards compatibility.
> The idea is to deprecate this method so that we could remove it in a future
> release.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (KAFKA-9780) Deprecate commit records without record metadata
[
https://issues.apache.org/jira/browse/KAFKA-9780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mario Molina updated KAFKA-9780:
Description:
Since KIP-382 (MirrorMaker 2.0) a new method {{commitRecord}} was included in
{{SourceTask}} class to be called by the worker adding a new parameter with the
record metadata. The old {{commitRecord}} method is called and from the new one
and it's preserved just for backwards compatibility.
The idea is to deprecate this method so that we could remove it in a future
release.
This
was:
Since KIP-382 (MirrorMaker 2.0) a new method {{commitRecord}} was included in
{{SourceTask}} class to be called by the worker adding a new parameter with the
record metadata. The old {{commitRecord}} method is called and from the new one
and it's preserved just for backwards compatibility.
The idea is to deprecate this method so that we could remove it in a future
release.
> Deprecate commit records without record metadata
>
>
> Key: KAFKA-9780
> URL: https://issues.apache.org/jira/browse/KAFKA-9780
> Project: Kafka
> Issue Type: Improvement
> Components: KafkaConnect
>Affects Versions: 2.4.1
>Reporter: Mario Molina
>Assignee: Mario Molina
>Priority: Minor
>
> Since KIP-382 (MirrorMaker 2.0) a new method {{commitRecord}} was included in
> {{SourceTask}} class to be called by the worker adding a new parameter with
> the record metadata. The old {{commitRecord}} method is called and from the
> new one and it's preserved just for backwards compatibility.
> The idea is to deprecate this method so that we could remove it in a future
> release.
> This
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (KAFKA-9780) Deprecate commit records without record metadata
[
https://issues.apache.org/jira/browse/KAFKA-9780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073283#comment-17073283
]
Mario Molina edited comment on KAFKA-9780 at 4/2/20, 1:12 AM:
--
Thanks for your comments [~rhauch].
I've created the KIP-586.
was (Author: mmolimar):
Thanks for your comments [~rhauch].
I've create the KIP-586.
> Deprecate commit records without record metadata
>
>
> Key: KAFKA-9780
> URL: https://issues.apache.org/jira/browse/KAFKA-9780
> Project: Kafka
> Issue Type: Improvement
> Components: KafkaConnect
>Affects Versions: 2.4.1
>Reporter: Mario Molina
>Assignee: Mario Molina
>Priority: Minor
> Labels: needs-kip
>
> Since KIP-382 (MirrorMaker 2.0) a new method {{commitRecord}} was included in
> {{SourceTask}} class to be called by the worker adding a new parameter with
> the record metadata. The old {{commitRecord}} method is called and from the
> new one and it's preserved just for backwards compatibility.
> The idea is to deprecate this method so that we could remove it in a future
> release.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (KAFKA-9780) Deprecate commit records without record metadata
[
https://issues.apache.org/jira/browse/KAFKA-9780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mario Molina updated KAFKA-9780:
Description:
Since KIP-382 (MirrorMaker 2.0) a new method {{commitRecord}} was included in
{{SourceTask}} class to be called by the worker adding a new parameter with the
record metadata. The old {{commitRecord}} method is called and from the new one
and it's preserved just for backwards compatibility.
The idea is to deprecate this method so that we could remove it in a future
release.
There is a KIP for this ticket:
[https://cwiki.apache.org/confluence/display/KAFKA/KIP-586%3A+Deprecate+commit+records+without+record+metadata]
was:
Since KIP-382 (MirrorMaker 2.0) a new method {{commitRecord}} was included in
{{SourceTask}} class to be called by the worker adding a new parameter with the
record metadata. The old {{commitRecord}} method is called and from the new one
and it's preserved just for backwards compatibility.
The idea is to deprecate this method so that we could remove it in a future
release.
This
> Deprecate commit records without record metadata
>
>
> Key: KAFKA-9780
> URL: https://issues.apache.org/jira/browse/KAFKA-9780
> Project: Kafka
> Issue Type: Improvement
> Components: KafkaConnect
>Affects Versions: 2.4.1
>Reporter: Mario Molina
>Assignee: Mario Molina
>Priority: Minor
>
> Since KIP-382 (MirrorMaker 2.0) a new method {{commitRecord}} was included in
> {{SourceTask}} class to be called by the worker adding a new parameter with
> the record metadata. The old {{commitRecord}} method is called and from the
> new one and it's preserved just for backwards compatibility.
> The idea is to deprecate this method so that we could remove it in a future
> release.
> There is a KIP for this ticket:
> [https://cwiki.apache.org/confluence/display/KAFKA/KIP-586%3A+Deprecate+commit+records+without+record+metadata]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (KAFKA-6836) Upgrade metrics library
[ https://issues.apache.org/jira/browse/KAFKA-6836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mario Molina resolved KAFKA-6836. - Resolution: Won't Fix > Upgrade metrics library > --- > > Key: KAFKA-6836 > URL: https://issues.apache.org/jira/browse/KAFKA-6836 > Project: Kafka > Issue Type: Improvement > Components: metrics >Affects Versions: 1.1.0 >Reporter: Mario Molina >Assignee: Mario Molina >Priority: Major > > The current metrics library which Kafka is using is pretty old (version 2.2.0 > from Yammer and now we have 4.X from Dropwizard). > In the latest versions of the Dropwizard library (which comes from Yammer and > this is deprecated), there are a lot of bugfixes and new features included > which could be interesting for the metrics (ie: Reservoris, support JDK9, > etc). > This patch includes the upgrade to this new version of the library so that we > could add new features in Kafka metrics. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (KAFKA-8721) Metrics library upgrade
Mario Molina created KAFKA-8721: --- Summary: Metrics library upgrade Key: KAFKA-8721 URL: https://issues.apache.org/jira/browse/KAFKA-8721 Project: Kafka Issue Type: Improvement Components: metrics Affects Versions: 2.3.0 Reporter: Mario Molina The current metrics library which Kafka is using is pretty old (version 2.2.0 from Yammer and now we have 4.1.0 from Dropwizard). In the latest versions of the Dropwizard library (which comes from Yammer and this is deprecated), there are a lot of bugfixes and new features included which could be interesting for the metrics (ie: Reservoris, support JDK9, etc). This patch includes the upgrade to this new version of the library so that we could add new features in Kafka metrics. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (KAFKA-8721) Metrics library upgrade
[ https://issues.apache.org/jira/browse/KAFKA-8721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mario Molina reassigned KAFKA-8721: --- Assignee: Mario Molina > Metrics library upgrade > --- > > Key: KAFKA-8721 > URL: https://issues.apache.org/jira/browse/KAFKA-8721 > Project: Kafka > Issue Type: Improvement > Components: metrics >Affects Versions: 2.3.0 >Reporter: Mario Molina >Assignee: Mario Molina >Priority: Major > > The current metrics library which Kafka is using is pretty old (version 2.2.0 > from Yammer and now we have 4.1.0 from Dropwizard). > In the latest versions of the Dropwizard library (which comes from Yammer and > this is deprecated), there are a lot of bugfixes and new features included > which could be interesting for the metrics (ie: Reservoris, support JDK9, > etc). > This patch includes the upgrade to this new version of the library so that we > could add new features in Kafka metrics. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (KAFKA-6836) Upgrade metrics library
[ https://issues.apache.org/jira/browse/KAFKA-6836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895289#comment-16895289 ] Mario Molina commented on KAFKA-6836: - Sure [~cadonna] Actually, this improvement became obsolete for technical reasons in prior Kafka versions. I decided to close this issue and create another one which is KAFKA-8721 Its [PR|https://github.com/apache/kafka/pull/7121] is already submitted. > Upgrade metrics library > --- > > Key: KAFKA-6836 > URL: https://issues.apache.org/jira/browse/KAFKA-6836 > Project: Kafka > Issue Type: Improvement > Components: metrics >Affects Versions: 1.1.0 >Reporter: Mario Molina >Assignee: Mario Molina >Priority: Major > > The current metrics library which Kafka is using is pretty old (version 2.2.0 > from Yammer and now we have 4.X from Dropwizard). > In the latest versions of the Dropwizard library (which comes from Yammer and > this is deprecated), there are a lot of bugfixes and new features included > which could be interesting for the metrics (ie: Reservoris, support JDK9, > etc). > This patch includes the upgrade to this new version of the library so that we > could add new features in Kafka metrics. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (KAFKA-9018) Kafka Connect - throw clearer exceptions on serialisation errors
[
https://issues.apache.org/jira/browse/KAFKA-9018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mario Molina reassigned KAFKA-9018:
---
Assignee: Mario Molina
> Kafka Connect - throw clearer exceptions on serialisation errors
>
>
> Key: KAFKA-9018
> URL: https://issues.apache.org/jira/browse/KAFKA-9018
> Project: Kafka
> Issue Type: Improvement
> Components: KafkaConnect
>Reporter: Robin Moffatt
>Assignee: Mario Molina
>Priority: Minor
>
> When Connect fails on a deserialisation error, it doesn't show if that's the
> *key or value* that's thrown the error, nor does it give the user any
> indication of the *topic/partition/offset* of the message. Kafka Connect
> should be improved to return this information.
> Example message that user will get (in this case caused by reading non-Avro
> data with the Avro converter)
> {code:java}
> Caused by: org.apache.kafka.connect.errors.DataException: Failed to
> deserialize data for topic sample_topic to Avro:
> at
> io.confluent.connect.avro.AvroConverter.toConnectData(AvroConverter.java:110)
> at
> org.apache.kafka.connect.runtime.WorkerSinkTask.lambda$convertAndTransformRecord$1(WorkerSinkTask.java:487)
> at
> org.apache.kafka.connect.runtime.errors.RetryWithToleranceOperator.execAndRetry(RetryWithToleranceOperator.java:128)
> at
> org.apache.kafka.connect.runtime.errors.RetryWithToleranceOperator.execAndHandleError(RetryWithToleranceOperator.java:162)
> ... 13 more
> Caused by: org.apache.kafka.common.errors.SerializationException: Error
> deserializing Avro message for id -1
> Caused by: org.apache.kafka.common.errors.SerializationException: Unknown
> magic byte!{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (KAFKA-9018) Kafka Connect - throw clearer exceptions on serialisation errors
[
https://issues.apache.org/jira/browse/KAFKA-9018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mario Molina updated KAFKA-9018:
Affects Version/s: 2.5.0
2.4.1
> Kafka Connect - throw clearer exceptions on serialisation errors
>
>
> Key: KAFKA-9018
> URL: https://issues.apache.org/jira/browse/KAFKA-9018
> Project: Kafka
> Issue Type: Improvement
> Components: KafkaConnect
>Affects Versions: 2.5.0, 2.4.1
>Reporter: Robin Moffatt
>Assignee: Mario Molina
>Priority: Minor
>
> When Connect fails on a deserialisation error, it doesn't show if that's the
> *key or value* that's thrown the error, nor does it give the user any
> indication of the *topic/partition/offset* of the message. Kafka Connect
> should be improved to return this information.
> Example message that user will get (in this case caused by reading non-Avro
> data with the Avro converter)
> {code:java}
> Caused by: org.apache.kafka.connect.errors.DataException: Failed to
> deserialize data for topic sample_topic to Avro:
> at
> io.confluent.connect.avro.AvroConverter.toConnectData(AvroConverter.java:110)
> at
> org.apache.kafka.connect.runtime.WorkerSinkTask.lambda$convertAndTransformRecord$1(WorkerSinkTask.java:487)
> at
> org.apache.kafka.connect.runtime.errors.RetryWithToleranceOperator.execAndRetry(RetryWithToleranceOperator.java:128)
> at
> org.apache.kafka.connect.runtime.errors.RetryWithToleranceOperator.execAndHandleError(RetryWithToleranceOperator.java:162)
> ... 13 more
> Caused by: org.apache.kafka.common.errors.SerializationException: Error
> deserializing Avro message for id -1
> Caused by: org.apache.kafka.common.errors.SerializationException: Unknown
> magic byte!{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (KAFKA-9018) Kafka Connect - throw clearer exceptions on serialisation errors
[
https://issues.apache.org/jira/browse/KAFKA-9018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mario Molina updated KAFKA-9018:
Fix Version/s: 2.6.0
> Kafka Connect - throw clearer exceptions on serialisation errors
>
>
> Key: KAFKA-9018
> URL: https://issues.apache.org/jira/browse/KAFKA-9018
> Project: Kafka
> Issue Type: Improvement
> Components: KafkaConnect
>Affects Versions: 2.5.0, 2.4.1
>Reporter: Robin Moffatt
>Assignee: Mario Molina
>Priority: Minor
> Fix For: 2.6.0
>
>
> When Connect fails on a deserialisation error, it doesn't show if that's the
> *key or value* that's thrown the error, nor does it give the user any
> indication of the *topic/partition/offset* of the message. Kafka Connect
> should be improved to return this information.
> Example message that user will get (in this case caused by reading non-Avro
> data with the Avro converter)
> {code:java}
> Caused by: org.apache.kafka.connect.errors.DataException: Failed to
> deserialize data for topic sample_topic to Avro:
> at
> io.confluent.connect.avro.AvroConverter.toConnectData(AvroConverter.java:110)
> at
> org.apache.kafka.connect.runtime.WorkerSinkTask.lambda$convertAndTransformRecord$1(WorkerSinkTask.java:487)
> at
> org.apache.kafka.connect.runtime.errors.RetryWithToleranceOperator.execAndRetry(RetryWithToleranceOperator.java:128)
> at
> org.apache.kafka.connect.runtime.errors.RetryWithToleranceOperator.execAndHandleError(RetryWithToleranceOperator.java:162)
> ... 13 more
> Caused by: org.apache.kafka.common.errors.SerializationException: Error
> deserializing Avro message for id -1
> Caused by: org.apache.kafka.common.errors.SerializationException: Unknown
> magic byte!{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (KAFKA-9985) Sink connector may exhaust broker when writing in DLQ
Mario Molina created KAFKA-9985: --- Summary: Sink connector may exhaust broker when writing in DLQ Key: KAFKA-9985 URL: https://issues.apache.org/jira/browse/KAFKA-9985 Project: Kafka Issue Type: Bug Affects Versions: 2.4.1, 2.5.0, 2.3.1 Reporter: Mario Molina Assignee: Mario Molina Fix For: 2.6.0 When a sink connector is configured with a DLQ and its topic is the same (or matches) as the topic in which the connector reads, the broker and/or connector might be exhausted in case the record send to the topic is invalid. Based on the broker/connect config, the connector might fail throwing a RecordTooLargeException previous to exhaust the broker/connector. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (KAFKA-5975) No response when deleting topics and delete.topic.enable=false
Mario Molina created KAFKA-5975: --- Summary: No response when deleting topics and delete.topic.enable=false Key: KAFKA-5975 URL: https://issues.apache.org/jira/browse/KAFKA-5975 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.11.0.0 Reporter: Mario Molina Priority: Minor Fix For: 0.11.0.1, 0.11.0.2 When trying to delete topics using the KafkaAdminClient and the flag in server config is set as 'delete.topic.enable=false', the client cannot get a response and fails returning a timeout error. This is due to the object DelayedCreatePartitions cannot complete the operation. This bug fix modifies the KafkaApi key DELETE_TOPICS taking into account that the flag can be disabled and swallow the error to the client, this is, the topic is never removed and no error is returned to the client. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KAFKA-5975) No response when deleting topics and delete.topic.enable=false
[ https://issues.apache.org/jira/browse/KAFKA-5975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180783#comment-16180783 ] Mario Molina commented on KAFKA-5975: - Yes, I just included a new API Error: INCOMPATIBLE_WITH_CONFIG with its corresponding exception. > No response when deleting topics and delete.topic.enable=false > -- > > Key: KAFKA-5975 > URL: https://issues.apache.org/jira/browse/KAFKA-5975 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.11.0.0 >Reporter: Mario Molina >Priority: Minor > Fix For: 0.11.0.1, 0.11.0.2 > > > When trying to delete topics using the KafkaAdminClient and the flag in > server config is set as 'delete.topic.enable=false', the client cannot get a > response and fails returning a timeout error. This is due to the object > DelayedCreatePartitions cannot complete the operation. > This bug fix modifies the KafkaApi key DELETE_TOPICS taking into account that > the flag can be disabled and swallow the error to the client, this is, the > topic is never removed and no error is returned to the client. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KAFKA-5975) No response when deleting topics and delete.topic.enable=false
[ https://issues.apache.org/jira/browse/KAFKA-5975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242113#comment-16242113 ] Mario Molina commented on KAFKA-5975: - The error returned finally was INVALID_REQUEST in order to avoid modifying the API Errors. > No response when deleting topics and delete.topic.enable=false > -- > > Key: KAFKA-5975 > URL: https://issues.apache.org/jira/browse/KAFKA-5975 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.11.0.0 >Reporter: Mario Molina >Assignee: Mario Molina >Priority: Minor > Fix For: 0.11.0.1, 0.11.0.2 > > > When trying to delete topics using the KafkaAdminClient and the flag in > server config is set as 'delete.topic.enable=false', the client cannot get a > response and fails returning a timeout error. This is due to the object > DelayedCreatePartitions cannot complete the operation. > This bug fix modifies the KafkaApi key DELETE_TOPICS taking into account that > the flag can be disabled and swallow the error to the client, this is, the > topic is never removed and no error is returned to the client. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KAFKA-5975) No response when deleting topics and delete.topic.enable=false
[ https://issues.apache.org/jira/browse/KAFKA-5975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439572#comment-16439572 ] Mario Molina commented on KAFKA-5975: - What about this fix [~ewencp]? > No response when deleting topics and delete.topic.enable=false > -- > > Key: KAFKA-5975 > URL: https://issues.apache.org/jira/browse/KAFKA-5975 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.11.0.0 >Reporter: Mario Molina >Assignee: Mario Molina >Priority: Minor > Fix For: 1.0.2 > > > When trying to delete topics using the KafkaAdminClient and the flag in > server config is set as 'delete.topic.enable=false', the client cannot get a > response and fails returning a timeout error. This is due to the object > DelayedCreatePartitions cannot complete the operation. > This bug fix modifies the KafkaApi key DELETE_TOPICS taking into account that > the flag can be disabled and swallow the error to the client, this is, the > topic is never removed and no error is returned to the client. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (KAFKA-5975) No response when deleting topics and delete.topic.enable=false
[ https://issues.apache.org/jira/browse/KAFKA-5975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439572#comment-16439572 ] Mario Molina edited comment on KAFKA-5975 at 4/16/18 3:19 PM: -- What about this fix? [~ewencp] [~rsivaram] was (Author: mmolimar): What about this fix [~ewencp]? > No response when deleting topics and delete.topic.enable=false > -- > > Key: KAFKA-5975 > URL: https://issues.apache.org/jira/browse/KAFKA-5975 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.11.0.0 >Reporter: Mario Molina >Assignee: Mario Molina >Priority: Minor > Fix For: 1.0.2 > > > When trying to delete topics using the KafkaAdminClient and the flag in > server config is set as 'delete.topic.enable=false', the client cannot get a > response and fails returning a timeout error. This is due to the object > DelayedCreatePartitions cannot complete the operation. > This bug fix modifies the KafkaApi key DELETE_TOPICS taking into account that > the flag can be disabled and swallow the error to the client, this is, the > topic is never removed and no error is returned to the client. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KAFKA-5975) No response when deleting topics and delete.topic.enable=false
[ https://issues.apache.org/jira/browse/KAFKA-5975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mario Molina updated KAFKA-5975: Fix Version/s: 1.1.1 > No response when deleting topics and delete.topic.enable=false > -- > > Key: KAFKA-5975 > URL: https://issues.apache.org/jira/browse/KAFKA-5975 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.11.0.0 >Reporter: Mario Molina >Assignee: Mario Molina >Priority: Minor > Fix For: 1.0.2, 1.1.1 > > > When trying to delete topics using the KafkaAdminClient and the flag in > server config is set as 'delete.topic.enable=false', the client cannot get a > response and fails returning a timeout error. This is due to the object > DelayedCreatePartitions cannot complete the operation. > This bug fix modifies the KafkaApi key DELETE_TOPICS taking into account that > the flag can be disabled and swallow the error to the client, this is, the > topic is never removed and no error is returned to the client. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (KAFKA-6836) Upgrade metrics library
Mario Molina created KAFKA-6836: --- Summary: Upgrade metrics library Key: KAFKA-6836 URL: https://issues.apache.org/jira/browse/KAFKA-6836 Project: Kafka Issue Type: Improvement Components: metrics Affects Versions: 1.1.0 Reporter: Mario Molina Assignee: Mario Molina Fix For: 2.0.0, 1.1.1 The current metrics library which Kafka is using is pretty old (version 2.2.0 from Yammer and now we have 4.X from Dropwizard). In the latest versions of the Dropwizard library (which comes from Yammer and this is deprecated), there are a lot of bugfixes and new features included which could be interesting for the metrics (ie: Reservoris, support JDK9, etc). This patch includes the upgrade to this new version of the library so that we could add new features in Kafka metrics. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
