[jira] [Commented] (KAFKA-12213) Kafka Streams aggregation Initializer to accept record key
[ https://issues.apache.org/jira/browse/KAFKA-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17279709#comment-17279709 ] Piotr Fras commented on KAFKA-12213: [~mjsax] [~guozhang] thank you for your comments on the issue. Personally, I would prefer working up KIP-149 as it was already accepted by the community and can be progressed on. If we decide on breaking KIP-149 into smaller deliverables, how would you proceed with merging/releasing those features? Would you rather wait for all stories to be delivered and perform one big release of KIP-149? Re: backwards compatibility, as per KIP-149, it was decided to use method overloading in Transformers, Mappers, Joiners and Initializers to address backwards compatibility issue. While this works for Java API, it might not work for Scala API as method overloading is dangerous and discouraged, more details: https://stackoverflow.com/a/2512001/2145368 > Kafka Streams aggregation Initializer to accept record key > -- > > Key: KAFKA-12213 > URL: https://issues.apache.org/jira/browse/KAFKA-12213 > Project: Kafka > Issue Type: New Feature > Components: streams >Reporter: Piotr Fras >Assignee: Piotr Fras >Priority: Minor > Labels: needs-kip > > Sometimes Kafka record key contains useful information for creating a zero > object in aggregation Initializer. This feature is to add kafka record key to > Initializer. > There were two approaches I considered to implement this feature, one > respecting backwards compatibility for internal and external APIs and the > other one which is not. I chose the latter one as it was more strait-forward. > We may want to validate this approach tho. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (KAFKA-12213) Kafka Streams aggregation Initializer to accept record key
[ https://issues.apache.org/jira/browse/KAFKA-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17279709#comment-17279709 ] Piotr Fras edited comment on KAFKA-12213 at 2/5/21, 2:03 PM: - [~mjsax] [~guozhang] thank you for your comments on the issue. Personally, I would prefer working up KIP-149 as it was already accepted by the community and can be progressed on. If we decide on breaking KIP-149 into smaller deliverables, how would you proceed with merging/releasing those features? Would you rather wait for all stories to be delivered and perform one big release of KIP-149? I don't mind submitting one massive PR with all the features from KIP-149. Re: backwards compatibility, as per KIP-149, it was decided to use method overloading in Transformers, Mappers, Joiners and Initializers to address backwards compatibility issue. While this works for Java API, it might not work for Scala API as method overloading is dangerous and discouraged, more details: [https://stackoverflow.com/a/2512001/2145368] was (Author: moncalamari): [~mjsax] [~guozhang] thank you for your comments on the issue. Personally, I would prefer working up KIP-149 as it was already accepted by the community and can be progressed on. If we decide on breaking KIP-149 into smaller deliverables, how would you proceed with merging/releasing those features? Would you rather wait for all stories to be delivered and perform one big release of KIP-149? Re: backwards compatibility, as per KIP-149, it was decided to use method overloading in Transformers, Mappers, Joiners and Initializers to address backwards compatibility issue. While this works for Java API, it might not work for Scala API as method overloading is dangerous and discouraged, more details: https://stackoverflow.com/a/2512001/2145368 > Kafka Streams aggregation Initializer to accept record key > -- > > Key: KAFKA-12213 > URL: https://issues.apache.org/jira/browse/KAFKA-12213 > Project: Kafka > Issue Type: New Feature > Components: streams >Reporter: Piotr Fras >Assignee: Piotr Fras >Priority: Minor > Labels: needs-kip > > Sometimes Kafka record key contains useful information for creating a zero > object in aggregation Initializer. This feature is to add kafka record key to > Initializer. > There were two approaches I considered to implement this feature, one > respecting backwards compatibility for internal and external APIs and the > other one which is not. I chose the latter one as it was more strait-forward. > We may want to validate this approach tho. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (KAFKA-12213) Kafka Streams aggregation Initializer to accept record key
[ https://issues.apache.org/jira/browse/KAFKA-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280034#comment-17280034 ] Piotr Fras edited comment on KAFKA-12213 at 2/5/21, 11:02 PM: -- I am going to break down KIP-149 into five streams of work and submit individual pull request for each of the following interfaces, for both Java and Scala API: - ValueTransformer - ValueMapper - ValueJoiner - Initializer (already addressed in [https://github.com/apache/kafka/pull/9908]) - Reducer Let me know if that works for you. was (Author: moncalamari): I am going to break down KIP-149 into five streams of work and submit individual pull request for each of the following interfaces: - ValueTransformer - ValueMapper - ValueJoiner - Initializer (already addressed in [https://github.com/apache/kafka/pull/9908]) - Reducer Let me know if that works for you. > Kafka Streams aggregation Initializer to accept record key > -- > > Key: KAFKA-12213 > URL: https://issues.apache.org/jira/browse/KAFKA-12213 > Project: Kafka > Issue Type: New Feature > Components: streams >Reporter: Piotr Fras >Assignee: Piotr Fras >Priority: Minor > Labels: needs-kip > > Sometimes Kafka record key contains useful information for creating a zero > object in aggregation Initializer. This feature is to add kafka record key to > Initializer. > There were two approaches I considered to implement this feature, one > respecting backwards compatibility for internal and external APIs and the > other one which is not. I chose the latter one as it was more strait-forward. > We may want to validate this approach tho. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-12213) Kafka Streams aggregation Initializer to accept record key
[ https://issues.apache.org/jira/browse/KAFKA-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280034#comment-17280034 ] Piotr Fras commented on KAFKA-12213: I am going to break down KIP-149 into five streams of work and submit individual pull request for each of the following interfaces: - ValueTransformer - ValueMapper - ValueJoiner - Initializer (already addressed in [https://github.com/apache/kafka/pull/9908]) - Reducer Let me know if that works for you. > Kafka Streams aggregation Initializer to accept record key > -- > > Key: KAFKA-12213 > URL: https://issues.apache.org/jira/browse/KAFKA-12213 > Project: Kafka > Issue Type: New Feature > Components: streams >Reporter: Piotr Fras >Assignee: Piotr Fras >Priority: Minor > Labels: needs-kip > > Sometimes Kafka record key contains useful information for creating a zero > object in aggregation Initializer. This feature is to add kafka record key to > Initializer. > There were two approaches I considered to implement this feature, one > respecting backwards compatibility for internal and external APIs and the > other one which is not. I chose the latter one as it was more strait-forward. > We may want to validate this approach tho. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (KAFKA-12213) Kafka Streams aggregation Initializer to accept record key
[ https://issues.apache.org/jira/browse/KAFKA-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280034#comment-17280034 ] Piotr Fras edited comment on KAFKA-12213 at 2/5/21, 11:09 PM: -- I am going to break down KIP-149 into five streams of work and submit individual pull request for each of the following interfaces, for both Java and Scala API: - ValueTransformer - ValueMapper - ValueJoiner - Initializer (attempt made to address in [https://github.com/apache/kafka/pull/9908]) - Reducer Let me know if that works for you. was (Author: moncalamari): I am going to break down KIP-149 into five streams of work and submit individual pull request for each of the following interfaces, for both Java and Scala API: - ValueTransformer - ValueMapper - ValueJoiner - Initializer (already addressed in [https://github.com/apache/kafka/pull/9908]) - Reducer Let me know if that works for you. > Kafka Streams aggregation Initializer to accept record key > -- > > Key: KAFKA-12213 > URL: https://issues.apache.org/jira/browse/KAFKA-12213 > Project: Kafka > Issue Type: New Feature > Components: streams >Reporter: Piotr Fras >Assignee: Piotr Fras >Priority: Minor > Labels: needs-kip > > Sometimes Kafka record key contains useful information for creating a zero > object in aggregation Initializer. This feature is to add kafka record key to > Initializer. > There were two approaches I considered to implement this feature, one > respecting backwards compatibility for internal and external APIs and the > other one which is not. I chose the latter one as it was more strait-forward. > We may want to validate this approach tho. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-12213) Kafka Streams aggregation Initializer to accept record key
[ https://issues.apache.org/jira/browse/KAFKA-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17281463#comment-17281463 ] Piotr Fras commented on KAFKA-12213: Hi [~bbejeck], how are things with KIP-149 progressing? Is there anything I can help/assist with? > Kafka Streams aggregation Initializer to accept record key > -- > > Key: KAFKA-12213 > URL: https://issues.apache.org/jira/browse/KAFKA-12213 > Project: Kafka > Issue Type: New Feature > Components: streams >Reporter: Piotr Fras >Assignee: Piotr Fras >Priority: Minor > Labels: needs-kip > > Sometimes Kafka record key contains useful information for creating a zero > object in aggregation Initializer. This feature is to add kafka record key to > Initializer. > There were two approaches I considered to implement this feature, one > respecting backwards compatibility for internal and external APIs and the > other one which is not. I chose the latter one as it was more strait-forward. > We may want to validate this approach tho. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (KAFKA-12213) Kafka Streams aggregation Initializer to accept record key
Piotr Fras created KAFKA-12213: -- Summary: Kafka Streams aggregation Initializer to accept record key Key: KAFKA-12213 URL: https://issues.apache.org/jira/browse/KAFKA-12213 Project: Kafka Issue Type: Bug Components: streams Reporter: Piotr Fras Assignee: Piotr Fras Sometimes Kafka record key contains useful information for creating a zero object in aggregation Initializer. This feature is to add kafka record key to Initializer. There were two approaches I considered to implement this feature, one respecting backwards compatibility for internal and external APIs and the other one which is not. I chose the latter one as it was more strait forward. We may want to validate this approach tho. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (KAFKA-12213) Kafka Streams aggregation Initializer to accept record key
[ https://issues.apache.org/jira/browse/KAFKA-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Fras updated KAFKA-12213: --- Issue Type: New Feature (was: Bug) > Kafka Streams aggregation Initializer to accept record key > -- > > Key: KAFKA-12213 > URL: https://issues.apache.org/jira/browse/KAFKA-12213 > Project: Kafka > Issue Type: New Feature > Components: streams >Reporter: Piotr Fras >Assignee: Piotr Fras >Priority: Major > > Sometimes Kafka record key contains useful information for creating a zero > object in aggregation Initializer. This feature is to add kafka record key to > Initializer. > There were two approaches I considered to implement this feature, one > respecting backwards compatibility for internal and external APIs and the > other one which is not. I chose the latter one as it was more strait forward. > We may want to validate this approach tho. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (KAFKA-12213) Kafka Streams aggregation Initializer to accept record key
[ https://issues.apache.org/jira/browse/KAFKA-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Fras updated KAFKA-12213: --- Priority: Minor (was: Major) > Kafka Streams aggregation Initializer to accept record key > -- > > Key: KAFKA-12213 > URL: https://issues.apache.org/jira/browse/KAFKA-12213 > Project: Kafka > Issue Type: New Feature > Components: streams >Reporter: Piotr Fras >Assignee: Piotr Fras >Priority: Minor > > Sometimes Kafka record key contains useful information for creating a zero > object in aggregation Initializer. This feature is to add kafka record key to > Initializer. > There were two approaches I considered to implement this feature, one > respecting backwards compatibility for internal and external APIs and the > other one which is not. I chose the latter one as it was more strait forward. > We may want to validate this approach tho. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (KAFKA-12213) Kafka Streams aggregation Initializer to accept record key
[ https://issues.apache.org/jira/browse/KAFKA-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Fras updated KAFKA-12213: --- Description: Sometimes Kafka record key contains useful information for creating a zero object in aggregation Initializer. This feature is to add kafka record key to Initializer. There were two approaches I considered to implement this feature, one respecting backwards compatibility for internal and external APIs and the other one which is not. I chose the latter one as it was more strait-forward. We may want to validate this approach tho. was: Sometimes Kafka record key contains useful information for creating a zero object in aggregation Initializer. This feature is to add kafka record key to Initializer. There were two approaches I considered to implement this feature, one respecting backwards compatibility for internal and external APIs and the other one which is not. I chose the latter one as it was more strait forward. We may want to validate this approach tho. > Kafka Streams aggregation Initializer to accept record key > -- > > Key: KAFKA-12213 > URL: https://issues.apache.org/jira/browse/KAFKA-12213 > Project: Kafka > Issue Type: New Feature > Components: streams >Reporter: Piotr Fras >Assignee: Piotr Fras >Priority: Minor > > Sometimes Kafka record key contains useful information for creating a zero > object in aggregation Initializer. This feature is to add kafka record key to > Initializer. > There were two approaches I considered to implement this feature, one > respecting backwards compatibility for internal and external APIs and the > other one which is not. I chose the latter one as it was more strait-forward. > We may want to validate this approach tho. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (KAFKA-7885) Streams: TopologyDescription violates equals-hashCode contract.
Piotr Fras created KAFKA-7885: - Summary: Streams: TopologyDescription violates equals-hashCode contract. Key: KAFKA-7885 URL: https://issues.apache.org/jira/browse/KAFKA-7885 Project: Kafka Issue Type: Bug Reporter: Piotr Fras As per JavaSE documentation: > If two objects are *equal* according to the *equals*(Object) method, then >calling the *hashCode* method on each of the two objects must produce the same >integer result. This is not the case for TopologyDescription. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
