[jira] [Resolved] (KAFKA-1944) Rename LogCleaner and related classes to LogCompactor
[ https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranav Maniar resolved KAFKA-1944. -- Resolution: Won't Fix As discussed on Mailing List and KIP-184 discussion. This name changes will lead to many configuration name changes. Which seems to be unnecessary trouble for users. Also there are no evidence of users getting confused because of the naming. So it is decided that we will stick with the existing names > Rename LogCleaner and related classes to LogCompactor > - > > Key: KAFKA-1944 > URL: https://issues.apache.org/jira/browse/KAFKA-1944 > Project: Kafka > Issue Type: Bug >Reporter: Gwen Shapira >Assignee: Pranav Maniar > Labels: newbie > > Following a mailing list discussion: > "the name LogCleaner is seriously misleading. Its more of a log compactor. > Deleting old logs happens elsewhere from what I've seen." > Note that this may require renaming related classes, objects, configs and > metrics. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (KAFKA-2244) Document Kafka metrics configuration properties
[ https://issues.apache.org/jira/browse/KAFKA-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110426#comment-16110426 ] Pranav Maniar edited comment on KAFKA-2244 at 8/2/17 7:11 AM: -- [~granthenke], [~sslavic] can I take it up? was (Author: pranav.maniar): [~granthenke], [~sslavic] can I take it think ? > Document Kafka metrics configuration properties > --- > > Key: KAFKA-2244 > URL: https://issues.apache.org/jira/browse/KAFKA-2244 > Project: Kafka > Issue Type: Task > Components: config, website >Affects Versions: 0.8.2.1 >Reporter: Stevo Slavic >Assignee: Grant Henke > Labels: newbie > > Please have two configuration properties used in > kafka.metrics.KafkaMetricsConfig, namely "kafka.metrics.reporters" and > "kafka.metrics.polling.interval.secs", documented on > http://kafka.apache.org/documentation.html#configuration -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KAFKA-2244) Document Kafka metrics configuration properties
[ https://issues.apache.org/jira/browse/KAFKA-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110426#comment-16110426 ] Pranav Maniar commented on KAFKA-2244: -- [~granthenke], [~sslavic] can I take it think ? > Document Kafka metrics configuration properties > --- > > Key: KAFKA-2244 > URL: https://issues.apache.org/jira/browse/KAFKA-2244 > Project: Kafka > Issue Type: Task > Components: config, website >Affects Versions: 0.8.2.1 >Reporter: Stevo Slavic >Assignee: Grant Henke > Labels: newbie > > Please have two configuration properties used in > kafka.metrics.KafkaMetricsConfig, namely "kafka.metrics.reporters" and > "kafka.metrics.polling.interval.secs", documented on > http://kafka.apache.org/documentation.html#configuration -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (KAFKA-1944) Rename LogCleaner and related classes to LogCompactor
[
https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108462#comment-16108462
]
Pranav Maniar edited comment on KAFKA-1944 at 8/1/17 6:39 AM:
--
It seems that there are agreement/disagreement related to change...
So should I create KIP or first we discuss it over JIRA/mailing list ?
Also, what about other cleaner configs apart from {{log.cleaner.enable}} ? Does
any of the other cleaner config also requires renaming ? E.g.
{code}
log.cleaner.backoff.ms
log.cleaner.delete.retention.ms
log.cleaner.min.compaction.lag.ms
log.cleaner.threads
...
{code}
was (Author: pranav.maniar):
It seems that there are agreement/disagreement related to change...
So should I create KIP or first we discuss it over JIRA/mailing list ?
Also, what about other cleaner configs apart from {{log.cleaner.enable}} ? Does
any of the other cleaner config also requires renaming ? E.g.
{code}
log.cleaner.backoff.ms
log.cleaner.delete.retention.ms
log.cleaner.min.compaction.lag.ms
log.cleaner.threads
{code}
> Rename LogCleaner and related classes to LogCompactor
> -
>
> Key: KAFKA-1944
> URL: https://issues.apache.org/jira/browse/KAFKA-1944
> Project: Kafka
> Issue Type: Bug
>Reporter: Gwen Shapira
>Assignee: Pranav Maniar
> Labels: newbie
>
> Following a mailing list discussion:
> "the name LogCleaner is seriously misleading. Its more of a log compactor.
> Deleting old logs happens elsewhere from what I've seen."
> Note that this may require renaming related classes, objects, configs and
> metrics.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (KAFKA-1944) Rename LogCleaner and related classes to LogCompactor
[
https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108462#comment-16108462
]
Pranav Maniar edited comment on KAFKA-1944 at 8/1/17 6:39 AM:
--
It seems that there are agreement/disagreement related to change...
So should I create KIP or first we discuss it over JIRA/mailing list ?
Also, what about other cleaner configs apart from {{log.cleaner.enable}} ? Does
any of the other cleaner config also requires renaming ? E.g.
{code}
log.cleaner.backoff.ms
log.cleaner.delete.retention.ms
log.cleaner.min.compaction.lag.ms
log.cleaner.threads
{code}
was (Author: pranav.maniar):
It seems that there are agreement/disagreement related to change...
So should I create KIP or first we discuss it over JIRA/mailing list ?
Also, what about other cleaner configs apart from {{log.cleaner.enable}} ? Does
any of the other cleaner config also requires renaming ? E.g.
> Rename LogCleaner and related classes to LogCompactor
> -
>
> Key: KAFKA-1944
> URL: https://issues.apache.org/jira/browse/KAFKA-1944
> Project: Kafka
> Issue Type: Bug
>Reporter: Gwen Shapira
>Assignee: Pranav Maniar
> Labels: newbie
>
> Following a mailing list discussion:
> "the name LogCleaner is seriously misleading. Its more of a log compactor.
> Deleting old logs happens elsewhere from what I've seen."
> Note that this may require renaming related classes, objects, configs and
> metrics.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (KAFKA-1944) Rename LogCleaner and related classes to LogCompactor
[
https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108462#comment-16108462
]
Pranav Maniar commented on KAFKA-1944:
--
It seems that there are agreement/disagreement related to change...
So should I create KIP or first we discuss it over JIRA/mailing list ?
Also, what about other cleaner configs apart from {{log.cleaner.enable}} ? Does
any of the other cleaner config also requires renaming ? E.g.
> Rename LogCleaner and related classes to LogCompactor
> -
>
> Key: KAFKA-1944
> URL: https://issues.apache.org/jira/browse/KAFKA-1944
> Project: Kafka
> Issue Type: Bug
>Reporter: Gwen Shapira
>Assignee: Pranav Maniar
> Labels: newbie
>
> Following a mailing list discussion:
> "the name LogCleaner is seriously misleading. Its more of a log compactor.
> Deleting old logs happens elsewhere from what I've seen."
> Note that this may require renaming related classes, objects, configs and
> metrics.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (KAFKA-1944) Rename LogCleaner and related classes to LogCompactor
[ https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranav Maniar reassigned KAFKA-1944: Assignee: Pranav Maniar (was: Aravind Selvan) > Rename LogCleaner and related classes to LogCompactor > - > > Key: KAFKA-1944 > URL: https://issues.apache.org/jira/browse/KAFKA-1944 > Project: Kafka > Issue Type: Bug >Reporter: Gwen Shapira >Assignee: Pranav Maniar > Labels: newbie > > Following a mailing list discussion: > "the name LogCleaner is seriously misleading. Its more of a log compactor. > Deleting old logs happens elsewhere from what I've seen." > Note that this may require renaming related classes, objects, configs and > metrics. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KAFKA-1944) Rename LogCleaner and related classes to LogCompactor
[ https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107346#comment-16107346 ] Pranav Maniar commented on KAFKA-1944: -- Thanks [~becket_qin] , I will go through wiki page and try to create KIP. I see that I can't access KIP-template. If you can assign permission it will be great. Meanwhile I will also send mail to d...@kafka.apache.org as mentioned on wiki page. > Rename LogCleaner and related classes to LogCompactor > - > > Key: KAFKA-1944 > URL: https://issues.apache.org/jira/browse/KAFKA-1944 > Project: Kafka > Issue Type: Bug >Reporter: Gwen Shapira >Assignee: Aravind Selvan > Labels: newbie > > Following a mailing list discussion: > "the name LogCleaner is seriously misleading. Its more of a log compactor. > Deleting old logs happens elsewhere from what I've seen." > Note that this may require renaming related classes, objects, configs and > metrics. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KAFKA-1944) Rename LogCleaner and related classes to LogCompactor
[ https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106129#comment-16106129 ] Pranav Maniar commented on KAFKA-1944: -- Ok... So I will start working on it. [~becket_qin] , [~hachikuji] , I don't have permission to assign JIRA to me, can you please assign to me. Also, I am new here.. so for KIP creating I will require help .. or If you could create KIP that would be great... > Rename LogCleaner and related classes to LogCompactor > - > > Key: KAFKA-1944 > URL: https://issues.apache.org/jira/browse/KAFKA-1944 > Project: Kafka > Issue Type: Bug >Reporter: Gwen Shapira >Assignee: Aravind Selvan > Labels: newbie > > Following a mailing list discussion: > "the name LogCleaner is seriously misleading. Its more of a log compactor. > Deleting old logs happens elsewhere from what I've seen." > Note that this may require renaming related classes, objects, configs and > metrics. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KAFKA-2244) Document Kafka metrics configuration properties
[ https://issues.apache.org/jira/browse/KAFKA-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103652#comment-16103652 ] Pranav Maniar commented on KAFKA-2244: -- Is someone working on it?? I no : I can take it up > Document Kafka metrics configuration properties > --- > > Key: KAFKA-2244 > URL: https://issues.apache.org/jira/browse/KAFKA-2244 > Project: Kafka > Issue Type: Task > Components: config, website >Affects Versions: 0.8.2.1 >Reporter: Stevo Slavic >Assignee: Grant Henke > Labels: newbie > > Please have two configuration properties used in > kafka.metrics.KafkaMetricsConfig, namely "kafka.metrics.reporters" and > "kafka.metrics.polling.interval.secs", documented on > http://kafka.apache.org/documentation.html#configuration -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KAFKA-1944) Rename LogCleaner and related classes to LogCompactor
[ https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103571#comment-16103571 ] Pranav Maniar commented on KAFKA-1944: -- Is someone working on this?? If not I can take it up. I am new to kafka and this seems like a refactoring task, which will be easy to start with.. P.S. : This issue seems to be old, so this still needs to be refactored ?? > Rename LogCleaner and related classes to LogCompactor > - > > Key: KAFKA-1944 > URL: https://issues.apache.org/jira/browse/KAFKA-1944 > Project: Kafka > Issue Type: Bug >Reporter: Gwen Shapira >Assignee: Aravind Selvan > Labels: newbie > > Following a mailing list discussion: > "the name LogCleaner is seriously misleading. Its more of a log compactor. > Deleting old logs happens elsewhere from what I've seen." > Note that this may require renaming related classes, objects, configs and > metrics. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
