[jira] [Commented] (KAFKA-16959) ConfigCommand should not allow to define both `entity-default` and `entity-name`

2024-06-18 Thread Tai Le Manh (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17856121#comment-17856121
 ] 

Tai Le Manh commented on KAFKA-16959:
-

[~chia7712] [~m1a2st] I agree with Chia-Ping Tsai's point, making it work with 
both entities really makes sense.

> ConfigCommand should not allow to define both `entity-default` and 
> `entity-name`
> 
>
> Key: KAFKA-16959
> URL: https://issues.apache.org/jira/browse/KAFKA-16959
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: 黃竣陽
>Priority: Minor
>
> When users input both `entity-default` and `entity-name`, only `entity-name` 
> will get evaluated. It seems to me that is error-prone. We should throw 
> exception directly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (KAFKA-16959) ConfigCommand should not allow to define both `entity-default` and `entity-name`

2024-06-18 Thread Tai Le Manh (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17856048#comment-17856048
 ] 

Tai Le Manh commented on KAFKA-16959:
-

hm, it seems that using `entity-name` and `entity-default` at the same time is 
legal, it is allowed and described in 
[KIP-543|https://cwiki.apache.org/confluence/display/KAFKA/KIP-543%3A+Expand+ConfigCommand%27s+non-ZK+functionality]

> ConfigCommand should not allow to define both `entity-default` and 
> `entity-name`
> 
>
> Key: KAFKA-16959
> URL: https://issues.apache.org/jira/browse/KAFKA-16959
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: 黃竣陽
>Priority: Minor
>
> When users input both `entity-default` and `entity-name`, only `entity-name` 
> will get evaluated. It seems to me that is error-prone. We should throw 
> exception directly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)