[jira] [Commented] (KAFKA-7082) Concurrent createTopics calls may throw NodeExistsException

2018-07-20 Thread williamguan (JIRA)


[ 
https://issues.apache.org/jira/browse/KAFKA-7082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550587#comment-16550587
 ] 

williamguan commented on KAFKA-7082:


Hi, I think the broker should only accept the first create request when 
handling more than one request.

What if there are two people trying to create a topic with different 
partitions? One of them would found his messages were send to wrong partitions 
because both of them receive no exception while trying to create.

> Concurrent createTopics calls may throw NodeExistsException
> ---
>
> Key: KAFKA-7082
> URL: https://issues.apache.org/jira/browse/KAFKA-7082
> Project: Kafka
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Ismael Juma
>Assignee: Ismael Juma
>Priority: Critical
>  Labels: regression
> Fix For: 1.1.1, 2.0.0
>
>
> This exception is unexpected causing an `UnknownServerException` to be thrown 
> back to the client. Example below:
> {code}
> org.apache.zookeeper.KeeperException$NodeExistsException: KeeperErrorCode = 
> NodeExists for /config/topics/connect-configs
> at 
> org.apache.zookeeper.KeeperException.create(KeeperException.java:119)
> at 
> org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
> at kafka.zookeeper.AsyncResponse.maybeThrow(ZooKeeperClient.scala:472)
> at kafka.zk.KafkaZkClient.createRecursive(KafkaZkClient.scala:1400)
> at kafka.zk.KafkaZkClient.create$1(KafkaZkClient.scala:262)
> at 
> kafka.zk.KafkaZkClient.setOrCreateEntityConfigs(KafkaZkClient.scala:269)
> at 
> kafka.zk.AdminZkClient.createOrUpdateTopicPartitionAssignmentPathInZK(AdminZkClient.scala:99)
> at kafka.server.AdminManager$$anonfun$2.apply(AdminManager.scala:126)
> at kafka.server.AdminManager$$anonfun$2.apply(AdminManager.scala:81)
> at 
> scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:234)
> at 
> scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:234)
> at scala.collection.Iterator$class.foreach(Iterator.scala:891)
> at scala.collection.AbstractIterator.foreach(Iterator.scala:1334)
> at scala.collection.IterableLike$class.foreach(IterableLike.scala:72)
> at scala.collection.AbstractIterable.foreach(Iterable.scala:54)
> at 
> scala.collection.TraversableLike$class.map(TraversableLike.scala:234)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KAFKA-3530) Making the broker-list option consistent across all tools

2018-07-16 Thread williamguan (JIRA)


 [ 
https://issues.apache.org/jira/browse/KAFKA-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

williamguan updated KAFKA-3530:
---
Affects Version/s: 0.10.0.0
   0.10.1.1
   0.10.2.1

> Making the broker-list option consistent across all tools
> -
>
> Key: KAFKA-3530
> URL: https://issues.apache.org/jira/browse/KAFKA-3530
> Project: Kafka
>  Issue Type: Bug
>Affects Versions: 0.9.0.1, 0.10.0.0, 0.10.1.1, 0.10.2.1
>Reporter: Jun Rao
>Assignee: williamguan
>Priority: Major
>
> Currently, console-producer uses --broker-list and console-consumer uses 
> --bootstrap-server. This can be confusing to the users. We should standardize 
> the name on all tools using broker list.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (KAFKA-3530) Making the broker-list option consistent across all tools

2018-07-16 Thread williamguan (JIRA)


 [ 
https://issues.apache.org/jira/browse/KAFKA-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

williamguan reassigned KAFKA-3530:
--

Assignee: williamguan  (was: Liquan Pei)

> Making the broker-list option consistent across all tools
> -
>
> Key: KAFKA-3530
> URL: https://issues.apache.org/jira/browse/KAFKA-3530
> Project: Kafka
>  Issue Type: Bug
>Affects Versions: 0.9.0.1
>Reporter: Jun Rao
>Assignee: williamguan
>Priority: Major
>
> Currently, console-producer uses --broker-list and console-consumer uses 
> --bootstrap-server. This can be confusing to the users. We should standardize 
> the name on all tools using broker list.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KAFKA-7160) Add check for group ID length

2018-07-13 Thread williamguan (JIRA)


[ 
https://issues.apache.org/jira/browse/KAFKA-7160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543196#comment-16543196
 ] 

williamguan commented on KAFKA-7160:


Hi,sounds very reasonable.  Is it hard to add limit to the group ID's length?

> Add check for group ID length
> -
>
> Key: KAFKA-7160
> URL: https://issues.apache.org/jira/browse/KAFKA-7160
> Project: Kafka
>  Issue Type: Improvement
>  Components: core
>Reporter: lambdaliu
>Priority: Minor
>  Labels: newbie
>
> We should limit the length of the group ID, because other system(such as 
> monitor system) would use the group ID when we using  kafka in production 
> environment.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)