C0urante commented on PR #14309: URL: https://github.com/apache/kafka/pull/14309#issuecomment-1707264425
> I wonder if we can unify these approaches, and maybe even use the "enrich" patten for producer/consumer/admin instead of the "merge" style. I honestly find the `EnrichablePlugin` class pretty hard to read, and prefer the merge style when it can be used. The extra logic involved in supporting aliases and overriding the base `ConfigDef` is already fairly complex, and we'd also have to expand the class to allow plugins to optionally return null `ConfigDef` objects. If the stylistic suggestions are not blockers for review, but blockers for merging, do you think we could establish the ideal user-facing behavior here and then use a separate PR for a refactoring? I can target this branch with that PR (which would allow review to take place on it without having to merge this one to trunk), or target trunk (if we feel comfortable merging this without blocking on a refactor). And of course, if the stylistic suggestions are blockers for review, let me know and I can take a stab at that without doing anything fancy 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
