[GitHub] [kafka] C0urante commented on pull request #8357: KAFKA-9767: Add logging to basic auth rest extension

2020-05-20 Thread GitBox 


C0urante commented on pull request #8357:
URL: https://github.com/apache/kafka/pull/8357#issuecomment-631682508


   Thanks @rhauch; I've added the requested unit test. This is ready for 
another round when you have time



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] C0urante commented on pull request #8357: KAFKA-9767: Add logging to basic auth rest extension

2020-05-07 Thread GitBox 


C0urante commented on pull request #8357:
URL: https://github.com/apache/kafka/pull/8357#issuecomment-625571686


   Thanks for the review, @rhauch. After reading your comments and trying to 
put them into practice, I noticed a few additional areas where it seemed 
improvements could be made; let me know how this looks.
   I've also tested locally and confirmed that no `WARN`-level messages are 
emitted when malformed or invalid credentials are provided.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org