C0urante opened a new pull request #9669:
URL: https://github.com/apache/kafka/pull/9669


   [Jira](https://issues.apache.org/jira/browse/KAFKA-10792)
   
   The functional changes are simple: change the `WorkerSourceTask` class to 
only call `SourceTask::stop` from one location, during task shutdown, and only 
if an attempt has been made to start the task (which will not be the case if it 
was created in the paused state and then shut down before being started).
   
   Unit tests are tweaked where necessary to account for this new logic, which 
covers some edge cases mentioned in https://github.com/apache/kafka/pull/5020 
that were unaddressed up until now.
   
   The existing integration tests for blocking connectors are expanded to also 
include cases for blocking source and sink tasks. Full coverage of every 
source/sink task method is intentionally omitted from these expanded tests in 
order to avoid inflating test runtime (each one adds an extra 5 seconds at 
minimum) and because the tests that are added here were sufficient to reproduce 
the bug with source task shutdown.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to