[GitHub] [kafka] Hangleton commented on pull request #13378: KAFKA-14793: Propagate Topic Ids to the Group Coordinator during Offsets Commit
Hangleton commented on PR #13378: URL: https://github.com/apache/kafka/pull/13378#issuecomment-1469954905 Thanks for the merge David. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] Hangleton commented on pull request #13378: KAFKA-14793: Propagate Topic Ids to the Group Coordinator during Offsets Commit
Hangleton commented on PR #13378: URL: https://github.com/apache/kafka/pull/13378#issuecomment-1468290773 Thanks David @mumrah for the follow-up! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] Hangleton commented on pull request #13378: KAFKA-14793: Propagate Topic Ids to the Group Coordinator during Offsets Commit
Hangleton commented on PR #13378: URL: https://github.com/apache/kafka/pull/13378#issuecomment-1467716320 `testConnectionsByClientMetric()` in `SelectorTest` failed because the client connection could not be established before the test timeout. What about introducing a connection timeout and a retry in the `PlaintextSender` from where the connection attempt is made? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] Hangleton commented on pull request #13378: KAFKA-14793: Propagate Topic Ids to the Group Coordinator during Offsets Commit
Hangleton commented on PR #13378: URL: https://github.com/apache/kafka/pull/13378#issuecomment-1467614446 The following tests (seems unrelated to this PR) are failing: ``` org.apache.kafka.common.network.SelectorTest.testConnectionsByClientMetric() kafka.zk.ZkMigrationIntegrationTest.[1] Type=ZK, Name=testDualWrite, MetadataVersion=3.4-IV0, Security=PLAINTEXT ``` Is this expected? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] Hangleton commented on pull request #13378: KAFKA-14793: Propagate Topic Ids to the Group Coordinator during Offsets Commit
Hangleton commented on PR #13378: URL: https://github.com/apache/kafka/pull/13378#issuecomment-1467610318 Thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] Hangleton commented on pull request #13378: KAFKA-14793 - Propagate Topic Ids to the Group Coordinator during Offsets Commit
Hangleton commented on PR #13378: URL: https://github.com/apache/kafka/pull/13378#issuecomment-1466756969 Thanks David for the review, addressed the comments and inlined the declaration of topic-id-partitions in the locations above and in few other remaining places. The PR has just been rebased. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] Hangleton commented on pull request #13378: KAFKA-14793 - Propagate Topic Ids to the Group Coordinator during Offsets Commit
Hangleton commented on PR #13378: URL: https://github.com/apache/kafka/pull/13378#issuecomment-1466343813 Thanks David for the review, all comments should be addressed with the new commits. I wonder how useful it would be to extend the tests in `GroupCoordinatorTest` to exercise the operations on one `TopicIdPartition` while another topic id is already registered? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] Hangleton commented on pull request #13378: KAFKA-14793 - Propagate Topic Ids to the Group Coordinator during Offsets Commit
Hangleton commented on PR #13378: URL: https://github.com/apache/kafka/pull/13378#issuecomment-1466175146 Thank you David for the continued review, updating the PR to address the review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] Hangleton commented on pull request #13378: KAFKA-14793 - Propagate Topic Ids to the Group Coordinator during Offsets Commit
Hangleton commented on PR #13378: URL: https://github.com/apache/kafka/pull/13378#issuecomment-1464417180 Apologies for the delay, David - I have applied the changes to correct the PR. There may still be under-propagation of topic ids, though. The class `GroupMetadata` is intentionally left unchanged. The PR is not yet completed because I need to review the tests and ensure we have proper coverage, although there exists coverage already from the existing updated tests. I will aim to set the PR ready for review on Monday by EOD. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
