[GitHub] [kafka] Montyleo commented on pull request #9675: KAFKA-10794 Replica leader election is too slow in the case of too many partitions
Montyleo commented on pull request #9675: URL: https://github.com/apache/kafka/pull/9675#issuecomment-747942928 > @chia7712 does the patch can resolve the issue ? I find the only differences is that controllerContext.allPartitions can be invoked once or the number of partition times . please correct me if I am wrong. thanks. Hi，lqjack Thanks for your question. There is a saying that: quantitative change leads to qualitative change. when the function controllerContext.allPartitions was called too many time, the rebalance will become too slow. I'll show you the effect after the PR published，1.3ms VS 35541ms   This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] Montyleo commented on pull request #9675: KAFKA-10794 Replica leader election is too slow in the case of too many partitions
Montyleo commented on pull request #9675: URL: https://github.com/apache/kafka/pull/9675#issuecomment-737283188 > > I'll find the reason. > > Is there a existent ticket? If not, could you file a jira to log it? Also, you can assign the ticket to yourself ( I have given the permission to you) if you have free cycle to trace it. > > I will merge this PR tomorrow if no objection. Ok，I have no objection. I have created a jira to log it, [https://issues.apache.org/jira/projects/KAFKA/issues/KAFKA-10797?filter=allissues]. I'll trace it in my local environment. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] Montyleo commented on pull request #9675: KAFKA-10794 Replica leader election is too slow in the case of too many partitions
Montyleo commented on pull request #9675: URL: https://github.com/apache/kafka/pull/9675#issuecomment-737199358 > @Montyleo Is the failed test related to this PR? Hi, chia7712 Thanks for your reply. The failed test is about SaslAuthenticator, not related to this PR, even not related the component:kafkacontroller. It seems that the jdk 8 version is too low. I'll find the reason. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] Montyleo commented on pull request #9675: KAFKA-10794 Replica leader election is too slow in the case of too many partitions
Montyleo commented on pull request #9675: URL: https://github.com/apache/kafka/pull/9675#issuecomment-737187007 @huxihx Please help me review the code, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] Montyleo commented on pull request #9675: KAFKA-10794 Replica leader election is too slow in the case of too many partitions
Montyleo commented on pull request #9675: URL: https://github.com/apache/kafka/pull/9675#issuecomment-737185013 > @Montyleo nice finding. LGTM Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
