[GitHub] [kafka] SpacRocket commented on pull request #13382: KAFKA-14722: Make BooleanSerde public
SpacRocket commented on PR #13382: URL: https://github.com/apache/kafka/pull/13382#issuecomment-1502183087 @mjsax Sure thanks for the suggestion. I've pushed a new commit in this pull request: https://github.com/apache/kafka/pull/13491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] SpacRocket commented on pull request #13382: KAFKA-14722: Make BooleanSerde public
SpacRocket commented on PR #13382: URL: https://github.com/apache/kafka/pull/13382#issuecomment-1489249233 @wcarlson5 Thank you for your time, a question what do you mean exactly by upgrade notes? I've searched for it in wiki and couldn't find it: The KIP is currently in this table: https://user-images.githubusercontent.com/95596717/228657245-1d8f9341-50c6-4855-8526-83681094b7f8.png;> also I've seen that JIRA story hasn't been closed automatically so I left a comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] SpacRocket commented on pull request #13382: KAFKA-14722: Make BooleanSerde public
SpacRocket commented on PR #13382: URL: https://github.com/apache/kafka/pull/13382#issuecomment-1481980186 Apple M1: JDK 17, Scala 2.13 testDeleteInternalTopic [1st test] **(2/2 tests passed)** testDescribeQuorumStatusSuccesful [2nd test] **(6/6 tests passed)** testTaskRequestWithOldStartMsGetsUpdated [3rd test] **(test passed)** -- JDK 8, Scala 2.12.17 I've run this test without any issues testDynamicListenerConnectionCreationRateQuota [4th test] **(test passed)** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] SpacRocket commented on pull request #13382: KAFKA-14722: Make BooleanSerde public
SpacRocket commented on PR #13382: URL: https://github.com/apache/kafka/pull/13382#issuecomment-1480696323 Hello I've looked into the pr-merge and the only warning that I see is this: [2023-03-22T22:21:56.566Z] Recording test results [2023-03-22T22:22:14.166Z] [Checks API] No suitable checks publisher found. So I think now the changes should be ok. I've tried to run ./gradlew test on my computer but I got many errors in unrelated modules from this change for some reason. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
