[GitHub] [kafka] Staniel commented on a diff in pull request #13944: KAFKA-14953: Add tiered storage related metrics
Staniel commented on code in PR #13944:
URL: https://github.com/apache/kafka/pull/13944#discussion_r1267173038
##
core/src/main/java/kafka/log/remote/RemoteLogReader.java:
##
@@ -54,10 +60,14 @@ public Void call() {
logger.debug("Reading records from remote storage for topic
partition {}", fetchInfo.topicPartition);
FetchDataInfo fetchDataInfo = rlm.read(fetchInfo);
+
brokerTopicStats.topicStats(fetchInfo.topicPartition.topic()).remoteBytesInRate().mark(fetchDataInfo.records.sizeInBytes());
+
brokerTopicStats.allTopicsStats().remoteBytesInRate().mark(fetchDataInfo.records.sizeInBytes());
result = new RemoteLogReadResult(Optional.of(fetchDataInfo),
Optional.empty());
} catch (OffsetOutOfRangeException e) {
result = new RemoteLogReadResult(Optional.empty(), Optional.of(e));
Review Comment:
https://issues.apache.org/jira/browse/KAFKA-15214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] Staniel commented on a diff in pull request #13944: KAFKA-14953: Add tiered storage related metrics
Staniel commented on code in PR #13944:
URL: https://github.com/apache/kafka/pull/13944#discussion_r1267143752
##
core/src/main/java/kafka/log/remote/RemoteLogReader.java:
##
@@ -54,10 +60,14 @@ public Void call() {
logger.debug("Reading records from remote storage for topic
partition {}", fetchInfo.topicPartition);
FetchDataInfo fetchDataInfo = rlm.read(fetchInfo);
+
brokerTopicStats.topicStats(fetchInfo.topicPartition.topic()).remoteBytesInRate().mark(fetchDataInfo.records.sizeInBytes());
+
brokerTopicStats.allTopicsStats().remoteBytesInRate().mark(fetchDataInfo.records.sizeInBytes());
result = new RemoteLogReadResult(Optional.of(fetchDataInfo),
Optional.empty());
} catch (OffsetOutOfRangeException e) {
result = new RemoteLogReadResult(Optional.empty(), Optional.of(e));
Review Comment:
Thank you. I will create a JIRA to track that discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] Staniel commented on a diff in pull request #13944: KAFKA-14953: Add tiered storage related metrics
Staniel commented on code in PR #13944:
URL: https://github.com/apache/kafka/pull/13944#discussion_r1265980556
##
core/src/main/java/kafka/log/remote/RemoteLogReader.java:
##
@@ -54,10 +60,14 @@ public Void call() {
logger.debug("Reading records from remote storage for topic
partition {}", fetchInfo.topicPartition);
FetchDataInfo fetchDataInfo = rlm.read(fetchInfo);
+
brokerTopicStats.topicStats(fetchInfo.topicPartition.topic()).remoteBytesInRate().mark(fetchDataInfo.records.sizeInBytes());
+
brokerTopicStats.allTopicsStats().remoteBytesInRate().mark(fetchDataInfo.records.sizeInBytes());
result = new RemoteLogReadResult(Optional.of(fetchDataInfo),
Optional.empty());
} catch (OffsetOutOfRangeException e) {
result = new RemoteLogReadResult(Optional.empty(), Optional.of(e));
Review Comment:
Hi, came across this PR and have a qq, why we don't include the
OffsetOutOfRangeException result into the failed remote read request rate
metrics? If for some reason we can not, can we have a separate metrics to
capture that error in metrics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
