[GitHub] [kafka] abbccdda commented on a change in pull request #10135: KAFKA-10348: Share client channel between forwarding and auto creation manager

[GitBox]

abbccdda commented on a change in pull request #10135:
URL: https://github.com/apache/kafka/pull/10135#discussion_r593492752



##
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##
@@ -179,17 +181,16 @@ class BrokerServer(
   val controllerNodes = 
RaftConfig.quorumVoterStringsToNodes(controllerQuorumVotersFuture.get()).asScala
   val controllerNodeProvider = RaftControllerNodeProvider(metaLogManager, 
config, controllerNodes)
 
-  val forwardingChannelManager = BrokerToControllerChannelManager(
+  clientToControllerChannelManager = BrokerToControllerChannelManager(
 controllerNodeProvider,
 time,
 metrics,
 config,
-channelName = "forwarding",
+channelName = "clientToControllerChannel",

Review comment:
   Sg!





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] abbccdda commented on a change in pull request #10135: KAFKA-10348: Share client channel between forwarding and auto creation manager

[GitBox]

abbccdda commented on a change in pull request #10135:
URL: https://github.com/apache/kafka/pull/10135#discussion_r577322703



##
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##
@@ -134,6 +134,8 @@ class KafkaServer(
 
   var autoTopicCreationManager: AutoTopicCreationManager = null
 
+  var clientToControllerChannelManager: 
Option[BrokerToControllerChannelManager] = None
+
   var alterIsrManager: AlterIsrManager = null

Review comment:
   We are planning to consolidate into two channels eventually:
   1. broker to controller channel
   2. client to controller channel
   
   here, auto topic creation and forwarding fall into the 2nd category, while 
AlterIsr would be the 1st category.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org