[GitHub] [kafka] ableegoldman commented on a diff in pull request #13063: MINOR: Update KRaft cluster upgrade documentation for 3.4

2022-12-30 Thread GitBox


ableegoldman commented on code in PR #13063:
URL: https://github.com/apache/kafka/pull/13063#discussion_r1059604660


##
docs/upgrade.html:
##
@@ -103,7 +122,7 @@ Upgrading 
to 3.3.1 from any vers
 
 
 
-Upgrading a KRaft-based 
cluster to 3.3.1 from any version 3.0.x through 3.2.x

Review Comment:
   also, I noticed the duplicate header -- fixing this won't break anything I 
hope?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] ableegoldman commented on a diff in pull request #13063: MINOR: Update KRaft cluster upgrade documentation for 3.4

2022-12-30 Thread GitBox


ableegoldman commented on code in PR #13063:
URL: https://github.com/apache/kafka/pull/13063#discussion_r1059604603


##
docs/upgrade.html:
##
@@ -61,6 +61,25 @@ Upgrading to 
3.4.0 from any vers
 
 
 
+Upgrading a KRaft-based 
cluster to 3.4.0 from any version 3.0.x through 3.3.x
+
+If you are upgrading from a version prior to 3.4.0, please see the 
note below. Once you have changed the metadata.version to the latest version, 
it will not be possible to downgrade to a version prior to 3.4-IV0.
+
+For a rolling upgrade:
+
+
+Upgrade the brokers one at a time: shut down the broker, update 
the code, and restart it. Once you have done so, the
+brokers will be running the latest version and you can verify that 
the cluster's behavior and performance meets expectations.
+
+Once the cluster's behavior and performance has been verified, 
bump the metadata.version by running
+
+./bin/kafka-features.sh upgrade --metadata 3.4
+
+
+Note that the cluster metadata version cannot be downgraded to a 
pre-production 3.0.x, 3.1.x, 3.2.x, or 3.3.x version once it has been upgraded.
+However, it is possible to downgrade to production versions such 
as 3.3-IV0, 3.3-IV1, etc.

Review Comment:
   Gotcha, fixed the pre-prod version list. Still not sure what the `-IV0` 
suffixes are, but this make sense now?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] ableegoldman commented on a diff in pull request #13063: MINOR: Update KRaft cluster upgrade documentation for 3.4

2022-12-30 Thread GitBox


ableegoldman commented on code in PR #13063:
URL: https://github.com/apache/kafka/pull/13063#discussion_r1059585428


##
docs/upgrade.html:
##
@@ -61,6 +61,25 @@ Upgrading to 
3.4.0 from any vers
 
 
 
+Upgrading a KRaft-based 
cluster to 3.4.0 from any version 3.0.x through 3.3.x
+
+If you are upgrading from a version prior to 3.4.0, please see the 
note below. Once you have changed the metadata.version to the latest version, 
it will not be possible to downgrade to a version prior to 3.4-IV0.
+
+For a rolling upgrade:
+
+
+Upgrade the brokers one at a time: shut down the broker, update 
the code, and restart it. Once you have done so, the
+brokers will be running the latest version and you can verify that 
the cluster's behavior and performance meets expectations.
+
+Once the cluster's behavior and performance has been verified, 
bump the metadata.version by running
+
+./bin/kafka-features.sh upgrade --metadata 3.4
+
+
+Note that the cluster metadata version cannot be downgraded to a 
pre-production 3.0.x, 3.1.x, 3.2.x, or 3.3.x version once it has been upgraded.
+However, it is possible to downgrade to production versions such 
as 3.3-IV0, 3.3-IV1, etc.

Review Comment:
   hey @mumrah or @cmccabe or @hachikuji or whoever would know best, can you 
double check this section and specifically this line? The KRaft upgrade section 
in 3.3 also had `3.3-IV0, 3.3-IV1` as examples but I wasn't sure if it would 
make sense to bump this to `3.4-IV0, 3.4-IV1`, or some combination of those?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] ableegoldman commented on a diff in pull request #13063: MINOR: Update KRaft cluster upgrade documentation for 3.4

2022-12-30 Thread GitBox


ableegoldman commented on code in PR #13063:
URL: https://github.com/apache/kafka/pull/13063#discussion_r1059585428


##
docs/upgrade.html:
##
@@ -61,6 +61,25 @@ Upgrading to 
3.4.0 from any vers
 
 
 
+Upgrading a KRaft-based 
cluster to 3.4.0 from any version 3.0.x through 3.3.x
+
+If you are upgrading from a version prior to 3.4.0, please see the 
note below. Once you have changed the metadata.version to the latest version, 
it will not be possible to downgrade to a version prior to 3.4-IV0.
+
+For a rolling upgrade:
+
+
+Upgrade the brokers one at a time: shut down the broker, update 
the code, and restart it. Once you have done so, the
+brokers will be running the latest version and you can verify that 
the cluster's behavior and performance meets expectations.
+
+Once the cluster's behavior and performance has been verified, 
bump the metadata.version by running
+
+./bin/kafka-features.sh upgrade --metadata 3.4
+
+
+Note that the cluster metadata version cannot be downgraded to a 
pre-production 3.0.x, 3.1.x, 3.2.x, or 3.3.x version once it has been upgraded.
+However, it is possible to downgrade to production versions such 
as 3.3-IV0, 3.3-IV1, etc.

Review Comment:
   hey @mumrah or @cmccabe or whoever would know best, can you double check 
this section and specifically this line? The KRaft upgrade section in 3.3 also 
had `3.3-IV0, 3.3-IV1` as examples but I wasn't sure if it would make sense to 
bump this to `3.4-IV0, 3.4-IV1`, or some combination of those?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org