[GitHub] [kafka] ableegoldman commented on pull request #10355: KAFKA-12500: fix memory leak in thread cache

2021-03-19 Thread GitBox


ableegoldman commented on pull request #10355:
URL: https://github.com/apache/kafka/pull/10355#issuecomment-803214918


   Merged to trunk and cherrypicked to 2.8 cc @vvcephei 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] ableegoldman commented on pull request #10355: KAFKA-12500: fix memory leak in thread cache

2021-03-18 Thread GitBox


ableegoldman commented on pull request #10355:
URL: https://github.com/apache/kafka/pull/10355#issuecomment-802535398


   Alright I added two integration tests, lmk if this looks good @vvcephei 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] ableegoldman commented on pull request #10355: KAFKA-12500: fix memory leak in thread cache

2021-03-18 Thread GitBox


ableegoldman commented on pull request #10355:
URL: https://github.com/apache/kafka/pull/10355#issuecomment-802298961


   @vvcephei yeah I'm on it, just wanted to see if there were any concerns 
about the proposed fix first. I'll ping you again when it's ready


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] ableegoldman commented on pull request #10355: KAFKA-12500: fix memory leak in thread cache

2021-03-18 Thread GitBox


ableegoldman commented on pull request #10355:
URL: https://github.com/apache/kafka/pull/10355#issuecomment-802252651


   @wcarlson5 @cadonna  @lct45 
   
   Should be cherrypicked to 2.8 cc @vvcephei 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org