[GitHub] [kafka] ableegoldman commented on pull request #10356: KAFKA-12503: cache size set by the thread
ableegoldman commented on pull request #10356: URL: https://github.com/apache/kafka/pull/10356#issuecomment-802493975 Merged and cherrypicked to 2.8 cc @vvcephei -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10356: KAFKA-12503: cache size set by the thread
ableegoldman commented on pull request #10356: URL: https://github.com/apache/kafka/pull/10356#issuecomment-802491798 I don't think we should aim to catch things in soak, although I'm not on the side of "we should never catch anything in soak/everything must have an integration test" either. This particular issue does seem appropriate for an integration test -- as I said concurrency bugs are hard to actually reproduce, but we should absolutely be flexing the cache resize codepath in an integration test. I'm happy to leave that as followup work as long as we do get around to it. This looks good and the build passed so I'll merge this to unblock the release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10356: KAFKA-12503: cache size set by the thread
ableegoldman commented on pull request #10356: URL: https://github.com/apache/kafka/pull/10356#issuecomment-802411941 One unrelated test failure: `kafka.api.SaslGssapiSslEndToEndAuthorizationTest.testNoConsumeWithDescribeAclViaAssign` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
