[GitHub] [kafka] ableegoldman commented on pull request #11867: KAFKA-12648: fix #getMinThreadVersion and include IOException + topologyName in StreamsException when topology dir cleanup fails

2022-03-09 Thread GitBox


ableegoldman commented on pull request #11867:
URL: https://github.com/apache/kafka/pull/11867#issuecomment-1063520672


   Merged to trunk


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] ableegoldman commented on pull request #11867: KAFKA-12648: fix #getMinThreadVersion and include IOException + topologyName in StreamsException when topology dir cleanup fails

2022-03-09 Thread GitBox


ableegoldman commented on pull request #11867:
URL: https://github.com/apache/kafka/pull/11867#issuecomment-1063520314


   Found a somewhat more involved bug that was responsible for this test 
failing, so I opened a second bugfix PR you can find here
   
   Without this followup PR, the test may continue to see failures (as we see 
in the build results here). 
   
   But otherwise test failures are unrelated, going to merge this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] ableegoldman commented on pull request #11867: KAFKA-12648: fix #getMinThreadVersion and include IOException + topologyName in StreamsException when topology dir cleanup fails

2022-03-08 Thread GitBox


ableegoldman commented on pull request #11867:
URL: https://github.com/apache/kafka/pull/11867#issuecomment-1062571710


   Hey @wcarlson5 @guozhangwang @vvcephei @showuon can I get a very quick 
review for this ~10 line fix?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org