[GitHub] [kafka] ableegoldman commented on pull request #14149: HOTFIX: avoid placement of unnecessary transient standby tasks

2023-08-30 Thread via GitHub


ableegoldman commented on PR #14149:
URL: https://github.com/apache/kafka/pull/14149#issuecomment-1699897638

   Thanks! Merged to trunk and cherrypicked to 3.6 & 3.5


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] ableegoldman commented on pull request #14149: HOTFIX: avoid placement of unnecessary transient standby tasks

2023-08-29 Thread via GitHub


ableegoldman commented on PR #14149:
URL: https://github.com/apache/kafka/pull/14149#issuecomment-1698311063

   Test failures are unrelated
   
   @bbejeck @guozhangwang @mjsax @showuon @cadonna @vvcephei  
   
   Can someone give this a final pass when you have a few minutes? Would really 
like to get this (and especially the logging improvements) in before the 3.6 
code freeze tomorrow.
   
   (Btw, see my previous comment for a more in-depth explanation with examples)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] ableegoldman commented on pull request #14149: HOTFIX: avoid placement of unnecessary transient standby tasks

2023-08-04 Thread via GitHub


ableegoldman commented on PR #14149:
URL: https://github.com/apache/kafka/pull/14149#issuecomment-1666170754

   Test failures are unrelated
   
   Super small fix, would like to get it into 3.6 though
   
   ping also @vvcephei @showuon @wcarlson5 for a review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] ableegoldman commented on pull request #14149: HOTFIX: avoid placement of unnecessary transient standby tasks

2023-08-03 Thread via GitHub


ableegoldman commented on PR #14149:
URL: https://github.com/apache/kafka/pull/14149#issuecomment-1664835905

   call for review anyone cc @guozhangwang @cadonna @mjsax @lihaosky 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org