[GitHub] [kafka] ableegoldman commented on pull request #9978: KAFKA-10716: persist UUID in state directory for stable processId across restarts

2021-02-03 Thread GitBox 


ableegoldman commented on pull request #9978:
URL: https://github.com/apache/kafka/pull/9978#issuecomment-772967981


   The cherrypick seems to have a lot of merge conflicts so I'll open a 
separate PR for 2.7/2.6



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] ableegoldman commented on pull request #9978: KAFKA-10716: persist UUID in state directory for stable processId across restarts

2021-02-03 Thread GitBox 


ableegoldman commented on pull request #9978:
URL: https://github.com/apache/kafka/pull/9978#issuecomment-772967546


   Merged to trunk



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] ableegoldman commented on pull request #9978: KAFKA-10716: persist UUID in state directory for stable processId across restarts

2021-02-03 Thread GitBox 


ableegoldman commented on pull request #9978:
URL: https://github.com/apache/kafka/pull/9978#issuecomment-772966815


   Opened https://issues.apache.org/jira/browse/KAFKA-12288 for followup 
cleaning out of filesystem locks



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] ableegoldman commented on pull request #9978: KAFKA-10716: persist UUID in state directory for stable processId across restarts

2021-02-02 Thread GitBox 


ableegoldman commented on pull request #9978:
URL: https://github.com/apache/kafka/pull/9978#issuecomment-771948268


   A few unrelated test failures:
   ```
   Build / JDK 11 / 
org.apache.kafka.clients.consumer.internals.FetcherTest.testEarlierOffsetResetArrivesLate()
   Build / JDK 8 / kafka.api.CustomQuotaCallbackTest.testCustomQuotaCallback()
   Build / JDK 8 / 
kafka.api.PlaintextConsumerTest.testMultiConsumerStickyAssignment()
   Build / JDK 15 / kafka.api.CustomQuotaCallbackTest.testCustomQuotaCallback()
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] ableegoldman commented on pull request #9978: KAFKA-10716: persist UUID in state directory for stable processId across restarts

2021-02-02 Thread GitBox 


ableegoldman commented on pull request #9978:
URL: https://github.com/apache/kafka/pull/9978#issuecomment-771948268


   A few unrelated test failures:
   ```
   Build / JDK 11 / 
org.apache.kafka.clients.consumer.internals.FetcherTest.testEarlierOffsetResetArrivesLate()
   Build / JDK 8 / kafka.api.CustomQuotaCallbackTest.testCustomQuotaCallback()
   Build / JDK 8 / 
kafka.api.PlaintextConsumerTest.testMultiConsumerStickyAssignment()
   Build / JDK 15 / kafka.api.CustomQuotaCallbackTest.testCustomQuotaCallback()
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] ableegoldman commented on pull request #9978: KAFKA-10716: persist UUID in state directory for stable processId across restarts

2021-01-27 Thread GitBox 


ableegoldman commented on pull request #9978:
URL: https://github.com/apache/kafka/pull/9978#issuecomment-768786220


   Not done with the tests, but I'd appreciate some feedback on the non-testing 
code and general idea -- any takers for review? @cadonna @vvcephei 
@guozhangwang @wcarlson5 @lct45 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org