ableegoldman edited a comment on pull request #10356:
URL: https://github.com/apache/kafka/pull/10356#issuecomment-802491798


   I don't think we should aim to catch things in soak, although I'm not on the 
side of "we should never catch anything in soak/everything must have an 
integration test" either. It's just that this particular issue, and this 
feature in general really, calls for an integration test -- we should be 
flexing the cache resize codepath in a realistic scenario. I'm happy to leave 
that as followup work as long as we do get around to it.
   
   This looks good and the build passed so I'll merge this to unblock the 
release


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to