[GitHub] [kafka] afalko commented on pull request #8794: KAFKA-10092: Remove unused code branches in NioEchoServer

2020-10-25 Thread GitBox 


afalko commented on pull request #8794:
URL: https://github.com/apache/kafka/pull/8794#issuecomment-716195533


   I'll merge master once more



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] afalko commented on pull request #8794: KAFKA-10092: Remove unused code branches in NioEchoServer

2020-10-25 Thread GitBox 


afalko commented on pull request #8794:
URL: https://github.com/apache/kafka/pull/8794#issuecomment-716195452


   > @afalko Could you rebase PR to trigger QA?
   
   Thanks @chia7712 
   
   > @afalko Thanks for updating code. Are those failed tests related to this 
patch?
   
   @chia7712  These are not, last time it ran the jdk8 and jdk11 tests passed, 
but the jdk15 tests failed, this time it is the other way around.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] afalko commented on pull request #8794: KAFKA-10092: Remove unused code branches in NioEchoServer

2020-10-24 Thread GitBox 


afalko commented on pull request #8794:
URL: https://github.com/apache/kafka/pull/8794#issuecomment-716058925


   > @afalko Could you rebase PR to trigger QA?
   
   Thanks! Looks like it partially passed. I'll merge master against and see if 
it does better. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] afalko commented on pull request #8794: KAFKA-10092: Remove unused code branches in NioEchoServer

2020-06-03 Thread GitBox 


afalko commented on pull request #8794:
URL: https://github.com/apache/kafka/pull/8794#issuecomment-638478890


   @jghoman 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org