[GitHub] [kafka] albert02lowis commented on a change in pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

[GitBox]

albert02lowis commented on a change in pull request #9108:
URL: https://github.com/apache/kafka/pull/9108#discussion_r469707761



##
File path: 
streams/src/test/java/org/apache/kafka/streams/integration/AbstractJoinIntegrationTest.java
##
@@ -123,25 +117,18 @@
 public static void setupConfigsAndUtils() {
 
 STREAMS_CONFIG.put(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, 
"earliest");
-STREAMS_CONFIG.put(StreamsConfig.BOOTSTRAP_SERVERS_CONFIG, 
CLUSTER.bootstrapServers());

Review comment:
   Hi @bbejeck I have done the required change in a new commit. I have also 
extracted out redundant calls to set `BOOTSTRAP_SERVERS_CONFIG` in the 
subclasses' test methods.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] albert02lowis commented on a change in pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

[GitBox]

albert02lowis commented on a change in pull request #9108:
URL: https://github.com/apache/kafka/pull/9108#discussion_r469704319



##
File path: 
streams/src/test/java/org/apache/kafka/streams/integration/AbstractJoinIntegrationTest.java
##
@@ -123,25 +117,18 @@
 public static void setupConfigsAndUtils() {
 
 STREAMS_CONFIG.put(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, 
"earliest");
-STREAMS_CONFIG.put(StreamsConfig.BOOTSTRAP_SERVERS_CONFIG, 
CLUSTER.bootstrapServers());

Review comment:
   I see, let me add back this BOOTSTRAP_SERVERS_CONFIG inside 
setupConfigsAndUtils then 👍🏻 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] albert02lowis commented on a change in pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

[GitBox]

albert02lowis commented on a change in pull request #9108:
URL: https://github.com/apache/kafka/pull/9108#discussion_r469704319



##
File path: 
streams/src/test/java/org/apache/kafka/streams/integration/AbstractJoinIntegrationTest.java
##
@@ -123,25 +117,18 @@
 public static void setupConfigsAndUtils() {
 
 STREAMS_CONFIG.put(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, 
"earliest");
-STREAMS_CONFIG.put(StreamsConfig.BOOTSTRAP_SERVERS_CONFIG, 
CLUSTER.bootstrapServers());

Review comment:
   I see, let me add back this BOOTSTRAP_SERVERS_CONFIG then 👍🏻 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org