[GitHub] [kafka] bbejeck commented on a change in pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

2020-08-12 Thread GitBox 


bbejeck commented on a change in pull request #9108:
URL: https://github.com/apache/kafka/pull/9108#discussion_r469593164



##
File path: 
streams/src/test/java/org/apache/kafka/streams/integration/AbstractJoinIntegrationTest.java
##
@@ -123,25 +117,18 @@
 public static void setupConfigsAndUtils() {
 
 STREAMS_CONFIG.put(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, 
"earliest");
-STREAMS_CONFIG.put(StreamsConfig.BOOTSTRAP_SERVERS_CONFIG, 
CLUSTER.bootstrapServers());

Review comment:
   @albert02lowis I've confirmed locally that the test failures are 
related.  The `TopologyTestDriver` still needs a bootstrap servers config value.
   Adding something like 
`STREAMS_CONFIG.put(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, "test:");` 
into the `AbstractJoinIntegrationTest.setupConfigsAndUtils()` gets all tests 
passing. 
   
   I'm not sure how the JDK 14 tests passed as locally I got the same errors as 
the JDK 8 and 11 build locally.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] bbejeck commented on a change in pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

2020-08-12 Thread GitBox 


bbejeck commented on a change in pull request #9108:
URL: https://github.com/apache/kafka/pull/9108#discussion_r469593164



##
File path: 
streams/src/test/java/org/apache/kafka/streams/integration/AbstractJoinIntegrationTest.java
##
@@ -123,25 +117,18 @@
 public static void setupConfigsAndUtils() {
 
 STREAMS_CONFIG.put(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, 
"earliest");
-STREAMS_CONFIG.put(StreamsConfig.BOOTSTRAP_SERVERS_CONFIG, 
CLUSTER.bootstrapServers());

Review comment:
   @albert02lowis I've confirmed locally that the test failures are 
related.  The `TopologyTestDriver` still needs a bootstrap servers config value.
   Adding something like 
`STREAMS_CONFIG.put(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, "test:");` 
into the `AbstractJoinIntegrationTest.setupConfigsAndUtils()` gets all tests 
passing. 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org