[GitHub] [kafka] beardt commented on pull request #13168: Kafka 14565: Interceptor Resource Leak

2023-02-13 Thread via GitHub


beardt commented on PR #13168:
URL: https://github.com/apache/kafka/pull/13168#issuecomment-1428692304

   @C0urante  Can we move forward with this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] beardt commented on pull request #13168: Kafka 14565: Interceptor Resource Leak

2023-02-02 Thread via GitHub


beardt commented on PR #13168:
URL: https://github.com/apache/kafka/pull/13168#issuecomment-1413758244

   I went ahead and reintroduced  the InterceptorTestConfig as I do not think 
it adds anymore complexity than `TestConfig` and `ClassTestConfig` while also 
making  `testConfiguredInstancesClosedOnFailure` less confusing due to the 
usage of `MetricReporters` configs with consumer interceptors.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org