[GitHub] [kafka] cadonna commented on pull request #9087: HOTFIX: Set session timeout and heartbeat interval to default to decrease flakiness

[GitBox]

cadonna commented on pull request #9087:
URL: https://github.com/apache/kafka/pull/9087#issuecomment-666311943


   Java 14 failed due to the following failing test:
   
   ```
   org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest > 
shouldUpgradeFromEosAlphaToEosBeta[true]
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] cadonna commented on pull request #9087: HOTFIX: Set session timeout and heartbeat interval to default to decrease flakiness

[GitBox]

cadonna commented on pull request #9087:
URL: https://github.com/apache/kafka/pull/9087#issuecomment-666202514







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] cadonna commented on pull request #9087: HOTFIX: Set session timeout and heartbeat interval to default to decrease flakiness

[GitBox]

cadonna commented on pull request #9087:
URL: https://github.com/apache/kafka/pull/9087#issuecomment-665526207


   I did some runs of the `RestoreIntegrationTest` and the runtime does not 
significantly change between runs with default values for session timeout and 
heartbeat interval and reduced values for session timeout and heartbeat 
interval. Hence, I set the two configs to their default values for the entire 
test.  



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] cadonna commented on pull request #9087: HOTFIX: Set session timeout and heartbeat interval to default to decrease flakiness

[GitBox]

cadonna commented on pull request #9087:
URL: https://github.com/apache/kafka/pull/9087#issuecomment-664621717


   @abbccdda Looking at this test class again, I even think that we could set 
session timeout and heartbeat interval to default for all tests. The main 
motivation to reduce them was to not need to change the application ID for each 
test (see https://github.com/apache/kafka/pull/8530#discussion_r413170584). 
However, in the meanwhile each test has its own application ID, so I guess it 
would be fine to use again the defaults here. Is this correct @guozhangwang ?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org