[GitHub] [kafka] chia7712 commented on a change in pull request #10084: MINOR: Rename DecommissionBrokers to UnregisterBrokers
chia7712 commented on a change in pull request #10084: URL: https://github.com/apache/kafka/pull/10084#discussion_r572633977 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -217,6 +217,7 @@ class KafkaApis(val requestChannel: RequestChannel, case ApiKeys.ENVELOPE => handleEnvelope(request) case ApiKeys.DESCRIBE_CLUSTER => handleDescribeCluster(request) case ApiKeys.DESCRIBE_PRODUCERS => handleDescribeProducersRequest(request) +case ApiKeys.UNREGISTER_BROKER => maybeForwardToController(request, handleUnregisterBrokerRequest) Review comment: @cmccabe Thanks for explanation. It seems the [comment](https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaApis.scala#L221) gets invalid now. ``` Handle requests that should have been sent to the KIP-500 controlle ``` Could you revise the comment as well? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #10084: MINOR: Rename DecommissionBrokers to UnregisterBrokers
chia7712 commented on a change in pull request #10084: URL: https://github.com/apache/kafka/pull/10084#discussion_r572538990 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -217,6 +217,7 @@ class KafkaApis(val requestChannel: RequestChannel, case ApiKeys.ENVELOPE => handleEnvelope(request) case ApiKeys.DESCRIBE_CLUSTER => handleDescribeCluster(request) case ApiKeys.DESCRIBE_PRODUCERS => handleDescribeProducersRequest(request) +case ApiKeys.UNREGISTER_BROKER => maybeForwardToController(request, handleUnregisterBrokerRequest) Review comment: The other APIs from KIP-500 is just closed. Maybe this API could follow same pattern? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
