[GitHub] [kafka] clolov commented on a diff in pull request #12285: KAFKA-14001: Migrate streams module to JUnit 5 - Part 1

[GitBox]

clolov commented on code in PR #12285:
URL: https://github.com/apache/kafka/pull/12285#discussion_r926625230


##
streams/src/test/java/org/apache/kafka/streams/integration/ErrorHandlingIntegrationTest.java:
##
@@ -52,36 +52,46 @@
 import static org.hamcrest.CoreMatchers.equalTo;
 import static org.hamcrest.MatcherAssert.assertThat;
 
+@Timeout(600)
 @Category(IntegrationTest.class)
 public class ErrorHandlingIntegrationTest {
 
+private final String testId;
+private final String appId;
+private final Properties properties;
+
+// Task 0
+private final String inputTopic;
+private final String outputTopic;
+// Task 1
+private final String errorInputTopic;
+private final String errorOutputTopic;
+
 private static final EmbeddedKafkaCluster CLUSTER = new 
EmbeddedKafkaCluster(1);
 
-@BeforeClass
+ErrorHandlingIntegrationTest(final TestInfo testInfo) {
+testId = safeUniqueTestName(getClass(), testInfo);
+appId = "appId_" + testId;
+properties = props();
+
+inputTopic = "input" + testId;
+outputTopic = "output" + testId;
+
+errorInputTopic = "error-input" + testId;
+errorOutputTopic = "error-output" + testId;
+}

Review Comment:
   I cannot remember, so maybe there was no reason. When I was rebasing I 
noticed that this test has since been deleted (or moved to 
`org.apache.kafka.connect.integration`) so I believe it is safe to say I do not 
need to address this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] clolov commented on a diff in pull request #12285: KAFKA-14001: Migrate streams module to JUnit 5 - Part 1

[GitBox]

clolov commented on code in PR #12285:
URL: https://github.com/apache/kafka/pull/12285#discussion_r899092186


##
streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java:
##
@@ -236,6 +238,16 @@ public static String safeUniqueTestName(final Class 
testClass, final TestName
 .replace('=', '_');
 }
 
+public static String safeUniqueTestName(final Class testClass, final 
TestInfo testInfo) {

Review Comment:
   Fair point, I will make the changes in the next commit.



##
streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java:
##
@@ -87,37 +85,34 @@
 import static 
org.apache.kafka.streams.integration.utils.IntegrationTestUtils.waitForStandbyCompletion;
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.core.IsEqual.equalTo;
-import static org.junit.Assert.assertTrue;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
-@Category({IntegrationTest.class})
+@Timeout(600)
+@Tag("integration")

Review Comment:
   This is also a fair point, I will make the changes in the new commit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org