[GitHub] [kafka] clolov commented on pull request #12777: Replace EasyMock and PowerMock with Mockito - TimeOrderedWindowStoreTest

2023-02-03 Thread via GitHub


clolov commented on PR #12777:
URL: https://github.com/apache/kafka/pull/12777#issuecomment-1416159492

   Great, thank you very much @guozhangwang!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] clolov commented on pull request #12777: Replace EasyMock and PowerMock with Mockito - TimeOrderedWindowStoreTest

2023-02-02 Thread via GitHub


clolov commented on PR #12777:
URL: https://github.com/apache/kafka/pull/12777#issuecomment-1413738931

   @cadonna is it possible get a review here as well? @shekhar-rajak, if there 
are any comments is it possible for you to address them. I will circle back in 
a week's time and if there are still outstanding comments I will takeover this 
pull request to get it to completion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] clolov commented on pull request #12777: Replace EasyMock and PowerMock with Mockito - TimeOrderedWindowStoreTest

2022-11-22 Thread GitBox


clolov commented on PR #12777:
URL: https://github.com/apache/kafka/pull/12777#issuecomment-1323475825

   Hello @bbejeck! I have seen you collaborate with Divij Vaidya on a few pull 
requests and I was hoping you would lend us a hand in reviewing this pull 
request to get https://issues.apache.org/jira/browse/KAFKA-14133 over the line 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org