clolov opened a new pull request, #13068: URL: https://github.com/apache/kafka/pull/13068
_Summary_ This PR provides an implementation of KIP-847 (https://cwiki.apache.org/confluence/display/KAFKA/KIP-847%3A+Add+ProducerIdCount+metrics). As far as I can tell, the original author @artemlivshits has not provided a pull request since the KIP was approved so I took the liberty of picking it up. Of course, if they provide a pull request I am happy to close this one. I do not understand why the metric ought to be surfaced from `kafka.server:type=ReplicaManager,name=ProducerIdCount` when the information is stored in `ProducerStateManager`. I have thus taken the further liberty of surfacing the metric from `ProducerStateManager` directly under `kafka.log:type=ProducerStateManager,name=ProducerIdCount`. I am happy to revise this given the feedback or if this is accepted to update the KIP. _Testing_ Grafana dashboard showing ProducerIdCount increasing when adding idempotent producers and decreasing whenever the the producer ids expire: https://g-576b9cd7b5.grafana-workspace.us-east-1.amazonaws.com/dashboard/snapshot/U5NfIDaMlm0VTIvmF4ZHJio7Kwuc1pTk I do not know whether we carry out any unit/integration testing upon addition of new metrics, but if I am pointed to similar test cases I am happy to revise this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
