[GitHub] [kafka] cmccabe commented on a change in pull request #11175: MINOR: Fix getting started documentation
cmccabe commented on a change in pull request #11175: URL: https://github.com/apache/kafka/pull/11175#discussion_r682788755 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1725,7 +1725,14 @@ private long maybeSendRequest( return Long.MAX_VALUE; } -return connection.remainingRequestTimeMs(currentTimeMs); +long connectionWaitTimeMs = connection.remainingRequestTimeMs(currentTimeMs); +logger.trace( Review comment: can we use less vertical space here ## File path: config/kraft/broker.properties ## @@ -24,7 +24,7 @@ process.roles=broker # The node id associated with this instance's roles -node.id=1 +node.id=2 Review comment: This isn't strictly necessary because the id space for brokers and controllers is distinct. I guess it's fine to do this though, to avoid confusion? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] cmccabe commented on a change in pull request #11175: MINOR: Fix getting started documentation
cmccabe commented on a change in pull request #11175: URL: https://github.com/apache/kafka/pull/11175#discussion_r682789187 ## File path: config/kraft/broker.properties ## @@ -24,7 +24,7 @@ process.roles=broker # The node id associated with this instance's roles -node.id=1 +node.id=2 Review comment: This isn't strictly necessary because the id space for brokers and controllers is distinct. I guess it's fine to do this though, to avoid confusion? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] cmccabe commented on a change in pull request #11175: MINOR: Fix getting started documentation
cmccabe commented on a change in pull request #11175: URL: https://github.com/apache/kafka/pull/11175#discussion_r682788755 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1725,7 +1725,14 @@ private long maybeSendRequest( return Long.MAX_VALUE; } -return connection.remainingRequestTimeMs(currentTimeMs); +long connectionWaitTimeMs = connection.remainingRequestTimeMs(currentTimeMs); +logger.trace( Review comment: can we use less vertical space here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
