[GitHub] [kafka] cmccabe commented on pull request #10292: MINOR: fix client_compatibility_features_test.py

2021-03-17 Thread GitBox


cmccabe commented on pull request #10292:
URL: https://github.com/apache/kafka/pull/10292#issuecomment-801266689


   Thanks, @chia7712 !



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] cmccabe commented on pull request #10292: MINOR: fix client_compatibility_features_test.py

2021-03-16 Thread GitBox


cmccabe commented on pull request #10292:
URL: https://github.com/apache/kafka/pull/10292#issuecomment-800670554


   @rondagostino : thanks for the explanation.
   
   It's a bit weird to use the devel version of the tool when ZK is enabled, 
and the old version when it's not.  I think this will lead to some odd issues 
down the road.
   
   @chia7712 : Can we just use a separate node for the client, unconditionally? 
 Then that separate node can always have the devel software.
   
   Or, I suppose, we could change the path that the compat tool is invoked via 
(maybe that's annoying, though...)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org