[GitHub] [kafka] cmccabe commented on pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

2023-04-03 Thread via GitHub


cmccabe commented on PR #13374:
URL: https://github.com/apache/kafka/pull/13374#issuecomment-1494895163

   I looked in `org.apache.kafka.clients.admin.ScramMechanism` and didn't see 
any message about the other ScramMechanism enum. So it seems like someone 
changing this code could still make a mistake and change one but not the other,.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] cmccabe commented on pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

2023-03-23 Thread via GitHub


cmccabe commented on PR #13374:
URL: https://github.com/apache/kafka/pull/13374#issuecomment-1481634752

   This seems to have broken `FeatureCommandUnitTest.testHandleDowngrade` , 
which is concerning since I don't think that tests SCRAM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org