[GitHub] [kafka] dajac commented on a change in pull request #11230: KAFKA-12840; Removing `compact` cleaning on a topic should abort on-going compactions
dajac commented on a change in pull request #11230:
URL: https://github.com/apache/kafka/pull/11230#discussion_r691396770
##
File path: core/src/main/scala/kafka/server/ConfigHandler.scala
##
@@ -66,8 +66,13 @@ class TopicConfigHandler(private val logManager: LogManager,
kafkaConfig: KafkaC
topicConfig.asScala.forKeyValue { (key, value) =>
if (!configNamesToExclude.contains(key)) props.put(key, value)
}
- val logConfig =
LogConfig.fromProps(logManager.currentDefaultConfig.originals, props)
- logs.foreach(_.updateConfig(logConfig))
+ val newLogConfig =
LogConfig.fromProps(logManager.currentDefaultConfig.originals, props)
Review comment:
That is correct. Yeah, that's a good suggestion. I will do this.
##
File path: core/src/main/scala/kafka/server/ConfigHandler.scala
##
@@ -66,8 +66,13 @@ class TopicConfigHandler(private val logManager: LogManager,
kafkaConfig: KafkaC
topicConfig.asScala.forKeyValue { (key, value) =>
if (!configNamesToExclude.contains(key)) props.put(key, value)
}
- val logConfig =
LogConfig.fromProps(logManager.currentDefaultConfig.originals, props)
- logs.foreach(_.updateConfig(logConfig))
+ val newLogConfig =
LogConfig.fromProps(logManager.currentDefaultConfig.originals, props)
Review comment:
Another way would be to move `updateLogConfig` in the LogManager. It
would make sense to delegate the whole logic to it. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] dajac commented on a change in pull request #11230: KAFKA-12840; Removing `compact` cleaning on a topic should abort on-going compactions
dajac commented on a change in pull request #11230:
URL: https://github.com/apache/kafka/pull/11230#discussion_r691400434
##
File path: core/src/main/scala/kafka/server/ConfigHandler.scala
##
@@ -66,8 +66,13 @@ class TopicConfigHandler(private val logManager: LogManager,
kafkaConfig: KafkaC
topicConfig.asScala.forKeyValue { (key, value) =>
if (!configNamesToExclude.contains(key)) props.put(key, value)
}
- val logConfig =
LogConfig.fromProps(logManager.currentDefaultConfig.originals, props)
- logs.foreach(_.updateConfig(logConfig))
+ val newLogConfig =
LogConfig.fromProps(logManager.currentDefaultConfig.originals, props)
Review comment:
Another way would be to move `updateLogConfig` in the LogManager. It
would make sense to delegate the whole logic to it. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] dajac commented on a change in pull request #11230: KAFKA-12840; Removing `compact` cleaning on a topic should abort on-going compactions
dajac commented on a change in pull request #11230:
URL: https://github.com/apache/kafka/pull/11230#discussion_r691396770
##
File path: core/src/main/scala/kafka/server/ConfigHandler.scala
##
@@ -66,8 +66,13 @@ class TopicConfigHandler(private val logManager: LogManager,
kafkaConfig: KafkaC
topicConfig.asScala.forKeyValue { (key, value) =>
if (!configNamesToExclude.contains(key)) props.put(key, value)
}
- val logConfig =
LogConfig.fromProps(logManager.currentDefaultConfig.originals, props)
- logs.foreach(_.updateConfig(logConfig))
+ val newLogConfig =
LogConfig.fromProps(logManager.currentDefaultConfig.originals, props)
Review comment:
That is correct. Yeah, that's a good suggestion. I will do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
