[GitHub] [kafka] dajac commented on a diff in pull request #13747: MINOR: Fix ListOffsetsRequestTest.testResponseIncludesLeaderEpoch

2023-05-24 Thread via GitHub 


dajac commented on code in PR #13747:
URL: https://github.com/apache/kafka/pull/13747#discussion_r1203652500


##
core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala:
##
@@ -192,7 +192,7 @@ class ListOffsetsRequestTest extends BaseRequestTest {
 killBroker(firstLeaderId)
 val secondLeaderId = TestUtils.awaitLeaderChange(servers, partition, 
firstLeaderId)
 // make sure high watermark of new leader has caught up
-TestUtils.waitUntilTrue(() => sendRequest(secondLeaderId, 0L, 
-1).errorCode() != Errors.OFFSET_NOT_AVAILABLE.code(),
+TestUtils.waitUntilTrue(() => sendRequest(secondLeaderId, 
ListOffsetsRequest.LATEST_TIMESTAMP, -1).errorCode != 
Errors.OFFSET_NOT_AVAILABLE.code,

Review Comment:
   Yep. This is correct.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] dajac commented on a diff in pull request #13747: MINOR: Fix ListOffsetsRequestTest.testResponseIncludesLeaderEpoch

2023-05-23 Thread via GitHub 


dajac commented on code in PR #13747:
URL: https://github.com/apache/kafka/pull/13747#discussion_r1202331207


##
core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala:
##
@@ -192,7 +192,7 @@ class ListOffsetsRequestTest extends BaseRequestTest {
 killBroker(firstLeaderId)
 val secondLeaderId = TestUtils.awaitLeaderChange(servers, partition, 
firstLeaderId)
 // make sure high watermark of new leader has caught up
-TestUtils.waitUntilTrue(() => sendRequest(secondLeaderId, 0L, 
-1).errorCode() != Errors.OFFSET_NOT_AVAILABLE.code(),
+TestUtils.waitUntilTrue(() => sendRequest(secondLeaderId, 
ListOffsetsRequest.LATEST_TIMESTAMP, -1).errorCode != 
Errors.OFFSET_NOT_AVAILABLE.code,

Review Comment:
   `OFFSET_NOT_AVAILABLE` is only returned when `LATEST_TIMESTAMP` or 
`MAX_TIMESTAMP` are used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org