[GitHub] [kafka] dajac commented on pull request #12783: KAFKA-14334: complete delayed purgatory after replication

2022-11-16 Thread GitBox


dajac commented on PR #12783:
URL: https://github.com/apache/kafka/pull/12783#issuecomment-1317073961

   Merged to trunk and 3.3.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] dajac commented on pull request #12783: KAFKA-14334: complete delayed purgatory after replication

2022-11-16 Thread GitBox


dajac commented on PR #12783:
URL: https://github.com/apache/kafka/pull/12783#issuecomment-1317056696

   Failed tests are unrelated:
   ```
   Build / JDK 17 and Scala 2.13 / 
kafka.api.TransactionsExpirationTest.testTransactionAfterProducerIdExpires(String).quorum=kraft
   Build / JDK 11 and Scala 2.13 / 
org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegrationTest.testCreatePartitionsUseProvidedForwardingAdmin()
   Build / JDK 11 and Scala 2.13 / 
org.apache.kafka.controller.QuorumControllerTest.testDelayedConfigurationOperations()
   Build / JDK 11 and Scala 2.13 / 
org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated()
   Build / JDK 8 and Scala 2.12 / 
org.apache.kafka.controller.QuorumControllerTest.testEarlyControllerResults()
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] dajac commented on pull request #12783: KAFKA-14334: complete delayed purgatory after replication

2022-11-15 Thread GitBox


dajac commented on PR #12783:
URL: https://github.com/apache/kafka/pull/12783#issuecomment-1315579909

   @jeffkbkim `testAlterReplicaLogDirs(String)` has failed in the last few 
builds. I don't see the same in other PRs. Are you sure that it is not related? 
I haven't had the time to investigate it myself.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] dajac commented on pull request #12783: KAFKA-14334: complete delayed purgatory after replication

2022-11-11 Thread GitBox


dajac commented on PR #12783:
URL: https://github.com/apache/kafka/pull/12783#issuecomment-1312016123

   @jeffkbkim There are failed tests. Could you take a look please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] dajac commented on pull request #12783: KAFKA-14334: complete delayed purgatory after replication

2022-10-27 Thread GitBox


dajac commented on PR #12783:
URL: https://github.com/apache/kafka/pull/12783#issuecomment-1293497553

   @jeffkbkim Thanks for the update. I left a few more comments/suggestions. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org